summaryrefslogtreecommitdiff
path: root/methods/http.cc
diff options
context:
space:
mode:
authorEugene V. Lyubimkin <jackyf@1501-debian>2008-12-15 21:17:39 +0200
committerEugene V. Lyubimkin <jackyf@1501-debian>2008-12-15 21:17:39 +0200
commit788a8f42c1ec146c812550d076e5fb720e83ae52 (patch)
tree5cdb4e7b98f3bbb57fb76def64c4a334cbf89279 /methods/http.cc
parentfef5d395460ad45c097e8563c8b822173a9ae918 (diff)
downloadapt-788a8f42c1ec146c812550d076e5fb720e83ae52.tar.gz
Make apt proxy options have the highest priority, unified proxy determining code.
Diffstat (limited to 'methods/http.cc')
-rw-r--r--methods/http.cc31
1 files changed, 18 insertions, 13 deletions
diff --git a/methods/http.cc b/methods/http.cc
index b3c791fa0..5d18b3adc 100644
--- a/methods/http.cc
+++ b/methods/http.cc
@@ -309,22 +309,27 @@ bool ServerState::Open()
Persistent = true;
// Determine the proxy setting
- if (getenv("http_proxy") == 0)
+ string SpecificProxy = _config->Find("Acquire::http::Proxy::" + ServerName.Host);
+ if (!SpecificProxy.empty())
{
- string DefProxy = _config->Find("Acquire::http::Proxy");
- string SpecificProxy = _config->Find("Acquire::http::Proxy::" + ServerName.Host);
- if (SpecificProxy.empty() == false)
- {
- if (SpecificProxy == "DIRECT")
- Proxy = "";
- else
- Proxy = SpecificProxy;
- }
- else
- Proxy = DefProxy;
+ if (SpecificProxy == "DIRECT")
+ Proxy = "";
+ else
+ Proxy = SpecificProxy;
}
else
- Proxy = getenv("http_proxy");
+ {
+ string DefProxy = _config->Find("Acquire::http::Proxy");
+ if (!DefProxy.empty())
+ {
+ Proxy = DefProxy;
+ }
+ else
+ {
+ char* result = getenv("http_proxy");
+ Proxy = result ? result : "";
+ }
+ }
// Parse no_proxy, a , separated list of domains
if (getenv("no_proxy") != 0)