diff options
| author | Chengwei Yang <chengwei.yang@intel.com> | 2013-10-09 09:39:43 +0800 |
|---|---|---|
| committer | Simon McVittie <simon.mcvittie@collabora.co.uk> | 2013-11-01 12:08:33 +0000 |
| commit | 1e52889d2e64c6cc9085ba615420082bee18b611 (patch) | |
| tree | 8d01541f76af6d2e26b1a6ef1f2b204583bd5834 | |
| parent | 7c540d743db0d7b2f00d35782defcacda8b1479c (diff) | |
| download | dbus-1e52889d2e64c6cc9085ba615420082bee18b611.tar.gz | |
Remove unnecessary dbus_setenv()
DBUS_ACTIVATION_ADDRESS changed to DBUS_STARTER_ADDRESS and
DBUS_ACTIVATION_BUS_TYPE changed to DBUS_STARTER_BUS_TYPE since 2005 by
this commit - 8873c90
So the dbus_setenv() which used to unset the above two wrong environment
variables has no effect in fact. And giving that setenv(3) and putenv(3)
are not threadsafe, so it's better to remove them.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68308
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Acked-by: Colin Walters <walters@verbum.org>
| -rw-r--r-- | dbus/dbus-bus.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/dbus/dbus-bus.c b/dbus/dbus-bus.c index 9d2095f9..0fd48311 100644 --- a/dbus/dbus-bus.c +++ b/dbus/dbus-bus.c @@ -294,12 +294,6 @@ init_connections_unlocked (void) * the above code will work right */ - if (!dbus_setenv ("DBUS_ACTIVATION_ADDRESS", NULL)) - return FALSE; - - if (!dbus_setenv ("DBUS_ACTIVATION_BUS_TYPE", NULL)) - return FALSE; - if (!_dbus_register_shutdown_func (addresses_shutdown_func, NULL)) return FALSE; |