diff options
author | Simon McVittie <smcv@debian.org> | 2011-06-01 16:31:11 +0100 |
---|---|---|
committer | Simon McVittie <smcv@debian.org> | 2011-06-01 16:31:11 +0100 |
commit | 8452b2beee58590f7f5047dbef7292b1d702d891 (patch) | |
tree | 9cab065c9b29e9aa358bf4f54c0ebba482168cdf /HACKING | |
parent | 3e6b351f189f89af76fe1fd6e63a5171fae18284 (diff) | |
download | dbus-8452b2beee58590f7f5047dbef7292b1d702d891.tar.gz |
Imported Upstream version 1.5.2upstream/1.5.2
Diffstat (limited to 'HACKING')
-rw-r--r-- | HACKING | 17 |
1 files changed, 15 insertions, 2 deletions
@@ -303,6 +303,20 @@ rules are: - if there's a live unresolved controversy about a change, don't commit it while the argument is still raging. + - at their discretion, members of the reviewer group may also commit + branches/patches under these conditions: + + - the branch does not add or change API, ABI or wire-protocol + + - the branch solves a known problem and is covered by the regression tests + + - there are no objections from the rest of the review group within + a week of the patches being attached to Bugzilla + + - the committer gets a positive review on Bugzilla from someone they + consider qualified to review the change (e.g. a colleague with D-Bus + experience; not necessarily a member of the reviewer group) + - regardless of reviews, to commit a patch: - make check must pass - the test suite must be extended to cover the new code @@ -331,5 +345,4 @@ John Palmieri <johnp@redhat.com> Scott James Remnant <scott@netsplit.com> Will Thompson <will.thompson@collabora.co.uk> Simon McVittie <simon.mcvittie@collabora.co.uk> - - +David Zeuthen <davidz@redhat.com> |