diff options
| author | Guillem Jover <guillem@debian.org> | 2013-01-03 00:17:45 +0100 |
|---|---|---|
| committer | Guillem Jover <guillem@debian.org> | 2013-05-08 04:58:07 +0200 |
| commit | 6e2750d65d278b641b638251ef607f607a59e4c6 (patch) | |
| tree | 8b4b458cdcb285e92470ff994f4ca89abe52bbdf | |
| parent | 90baddbae257b517cd09a3a6b5d03a40cadd58d6 (diff) | |
| download | dpkg-6e2750d65d278b641b638251ef607f607a59e4c6.tar.gz | |
scripts: Do not use indirect object syntax
Fixes Objects::ProhibitIndirectSyntax.
Warned-by: perlcritic
| -rwxr-xr-x | scripts/dpkg-scanpackages.pl | 2 | ||||
| -rw-r--r-- | scripts/t/200_Dpkg_Shlibs.t | 4 | ||||
| -rw-r--r-- | test/100_critic.t | 1 |
3 files changed, 4 insertions, 3 deletions
diff --git a/scripts/dpkg-scanpackages.pl b/scripts/dpkg-scanpackages.pl index bce37b9fc..e894c538e 100755 --- a/scripts/dpkg-scanpackages.pl +++ b/scripts/dpkg-scanpackages.pl @@ -172,7 +172,7 @@ defined($override) and (-e $override or $pathprefix //= ''; -my $find_h = new IO::Handle; +my $find_h = IO::Handle->new(); open($find_h, '-|', 'find', '-L', "$binarydir/", @find_args, '-print') or syserr(_g("Couldn't open %s for reading"), $binarydir); FILE: diff --git a/scripts/t/200_Dpkg_Shlibs.t b/scripts/t/200_Dpkg_Shlibs.t index 545905278..2072e201a 100644 --- a/scripts/t/200_Dpkg_Shlibs.t +++ b/scripts/t/200_Dpkg_Shlibs.t @@ -169,9 +169,9 @@ use File::Basename qw(basename); sub save_load_test { my ($symfile, $comment, @opts) = @_; - my $save_file = new File::Temp; + my $save_file = File::Temp->new(); $symfile->save($save_file->filename, @opts); - my $dup = new Dpkg::Shlibs::SymbolFile(file => $save_file->filename); + my $dup = Dpkg::Shlibs::SymbolFile->new(file => $save_file->filename); # Force sync of non-stored attributes $dup->{file} = $symfile->{file}; $dup->{arch} = $symfile->{arch}; diff --git a/test/100_critic.t b/test/100_critic.t index 671c6d3ea..307b8b08a 100644 --- a/test/100_critic.t +++ b/test/100_critic.t @@ -66,6 +66,7 @@ my @policies = qw( Modules::RequireEndWithOne Modules::RequireExplicitPackage Modules::RequireFilenameMatchesPackage + Objects::ProhibitIndirectSyntax Subroutines::ProhibitExplicitReturnUndef Subroutines::ProhibitNestedSubs Subroutines::ProhibitReturnSort |