summaryrefslogtreecommitdiff
path: root/scripts/Dpkg.pm
diff options
context:
space:
mode:
authorGuillem Jover <guillem@debian.org>2012-12-31 21:43:39 +0100
committerGuillem Jover <guillem@debian.org>2013-05-04 19:03:13 +0200
commit6a73e3078b01a71d4a6ea90c85da16523ed56f1d (patch)
tree4cc7a210e7e851395f7ba4989e3aac4aa9d32710 /scripts/Dpkg.pm
parent62bc788a45e4a641c28ca9c8c5b9bb08f29faed8 (diff)
downloaddpkg-6a73e3078b01a71d4a6ea90c85da16523ed56f1d.tar.gz
Do not use double-quotes on strings that do not need interpolation
Using double-quotes imposes a small performance penalty as the perl parser needs to check if any interpolation is needed. Use double-quotes only when the string contains single-quotes. Ideally we'd use double-quotes too for escaped meta-characters that might otherwise be confusing to immediately see if they need interpolation or not, but the policy does not (currently) allow to ignore these. Fixes ValuesAndExpressions::ProhibitInterpolationOfLiterals. Warned-by: perlcritic
Diffstat (limited to 'scripts/Dpkg.pm')
-rw-r--r--scripts/Dpkg.pm10
1 files changed, 5 insertions, 5 deletions
diff --git a/scripts/Dpkg.pm b/scripts/Dpkg.pm
index 0d92916fd..ba41ede34 100644
--- a/scripts/Dpkg.pm
+++ b/scripts/Dpkg.pm
@@ -16,7 +16,7 @@ package Dpkg;
use strict;
use warnings;
-our $VERSION = "1.00";
+our $VERSION = '1.00';
use base qw(Exporter);
our @EXPORT = qw($version $progname $admindir $dpkglibdir $pkgdatadir);
@@ -24,10 +24,10 @@ our @EXPORT = qw($version $progname $admindir $dpkglibdir $pkgdatadir);
our ($progname) = $0 =~ m#(?:.*/)?([^/]*)#;
# The following lines are automatically fixed at install time
-our $version = "1.17.x";
-our $admindir = "/var/lib/dpkg";
-our $dpkglibdir = ".";
-our $pkgdatadir = "..";
+our $version = '1.17.x';
+our $admindir = '/var/lib/dpkg';
+our $dpkglibdir = '.';
+our $pkgdatadir = '..';
$pkgdatadir = $ENV{DPKG_DATADIR} if defined $ENV{DPKG_DATADIR};
1;