diff options
| author | Guillem Jover <guillem@debian.org> | 2012-12-31 21:43:39 +0100 |
|---|---|---|
| committer | Guillem Jover <guillem@debian.org> | 2013-05-04 19:03:13 +0200 |
| commit | 6a73e3078b01a71d4a6ea90c85da16523ed56f1d (patch) | |
| tree | 4cc7a210e7e851395f7ba4989e3aac4aa9d32710 /scripts/Dpkg/Conf.pm | |
| parent | 62bc788a45e4a641c28ca9c8c5b9bb08f29faed8 (diff) | |
| download | dpkg-6a73e3078b01a71d4a6ea90c85da16523ed56f1d.tar.gz | |
Do not use double-quotes on strings that do not need interpolation
Using double-quotes imposes a small performance penalty as the perl
parser needs to check if any interpolation is needed. Use double-quotes
only when the string contains single-quotes. Ideally we'd use
double-quotes too for escaped meta-characters that might otherwise be
confusing to immediately see if they need interpolation or not, but the
policy does not (currently) allow to ignore these.
Fixes ValuesAndExpressions::ProhibitInterpolationOfLiterals.
Warned-by: perlcritic
Diffstat (limited to 'scripts/Dpkg/Conf.pm')
| -rw-r--r-- | scripts/Dpkg/Conf.pm | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/scripts/Dpkg/Conf.pm b/scripts/Dpkg/Conf.pm index 98475db62..8e11d49ca 100644 --- a/scripts/Dpkg/Conf.pm +++ b/scripts/Dpkg/Conf.pm @@ -18,7 +18,7 @@ package Dpkg::Conf; use strict; use warnings; -our $VERSION = "1.01"; +our $VERSION = '1.01'; use Dpkg::Gettext; use Dpkg::ErrorHandling; @@ -102,7 +102,7 @@ sub parse { s/\s+/=/ unless m/=/; # First spaces becomes = if no = next if /^#/ or /^$/; # Skip empty lines and comments if (/^-[^-]/ and not $self->{allow_short}) { - warning(_g("short option not allowed in %s, line %d"), $desc, $.); + warning(_g('short option not allowed in %s, line %d'), $desc, $.); next; } if (/^([^=]+)(?:=(.*))?$/) { @@ -116,7 +116,7 @@ sub parse { } $count++; } else { - warning(_g("invalid syntax for option in %s, line %d"), $desc, $.); + warning(_g('invalid syntax for option in %s, line %d'), $desc, $.); } } return $count; @@ -160,7 +160,7 @@ Save the options in a file. sub output { my ($self, $fh) = @_; - my $ret = ""; + my $ret = ''; foreach my $opt ($self->get_options()) { $opt =~ s/^--//; if ($opt =~ s/^([^=]+)=/$1 = "/) { |