Do not use double-quotes on strings that do not need interpolation

Using double-quotes imposes a small performance penalty as the perl
parser needs to check if any interpolation is needed. Use double-quotes
only when the string contains single-quotes. Ideally we'd use
double-quotes too for escaped meta-characters that might otherwise be
confusing to immediately see if they need interpolation or not, but the
policy does not (currently) allow to ignore these.

Fixes ValuesAndExpressions::ProhibitInterpolationOfLiterals.

Warned-by: perlcritic

1 files changed, 3 insertions, 3 deletions

diff --git a/scripts/Dpkg/Package.pm b/scripts/Dpkg/Package.pm
index f3ed4698c..719e3941e 100644
--- a/scripts/Dpkg/Package.pm
+++ b/scripts/Dpkg/Package.pm
@@ -19,7 +19,7 @@ package Dpkg::Package;
 use strict;
 use warnings;
 
-our $VERSION = "0.01";
+our $VERSION = '0.01';
 
 use Dpkg::Gettext;
 
@@ -30,11 +30,11 @@ sub pkg_name_is_illegal($) {
     my $name = shift || '';
 
     $name eq '' &&
-        return _g("may not be empty string");
+        return _g('may not be empty string');
     $name =~ m/[^-+.0-9a-z]/o &&
         return sprintf(_g("character '%s' not allowed"), $&);
     $name =~ m/^[0-9a-z]/o ||
-        return _g("must start with an alphanumeric character");
+        return _g('must start with an alphanumeric character');
 
     return;
 }