diff options
| author | Guillem Jover <guillem@debian.org> | 2013-11-25 21:18:28 +0100 |
|---|---|---|
| committer | Guillem Jover <guillem@debian.org> | 2013-12-04 06:56:56 +0100 |
| commit | ee37c9202bb80ea4ee50bf463df1495eaf0d3a7c (patch) | |
| tree | e6fd1c2c6a0e4e13ecba2804ea909a5c8c7e2eee /scripts/Dpkg/Source/Package/V3/Bzr.pm | |
| parent | 0f802f0071e0efd7a260f83c5efc554f0ba585d9 (diff) | |
| download | dpkg-ee37c9202bb80ea4ee50bf463df1495eaf0d3a7c.tar.gz | |
perl: Try to avoid boolean operators after predicates on error checks
Using boolean operators after predicates for error checking makes the
code flow slightly confusing, do that only after actions, to check if
they succeeded and error out otherwise.
Diffstat (limited to 'scripts/Dpkg/Source/Package/V3/Bzr.pm')
| -rw-r--r-- | scripts/Dpkg/Source/Package/V3/Bzr.pm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/Dpkg/Source/Package/V3/Bzr.pm b/scripts/Dpkg/Source/Package/V3/Bzr.pm index 86ca1826d..725ed6ffd 100644 --- a/scripts/Dpkg/Source/Package/V3/Bzr.pm +++ b/scripts/Dpkg/Source/Package/V3/Bzr.pm @@ -141,7 +141,7 @@ sub do_build { my $tardir = "$tmp/$dirname"; system('bzr', 'branch', $dir, $tardir); - $? && subprocerr("bzr branch $dir $tardir"); + subprocerr("bzr branch $dir $tardir") if $?; # Remove the working tree. system('bzr', 'remove-tree', $tardir); |