diff options
| author | Guillem Jover <guillem@debian.org> | 2013-01-04 02:51:56 +0100 |
|---|---|---|
| committer | Guillem Jover <guillem@debian.org> | 2013-04-30 15:50:47 +0200 |
| commit | d6851023a9ab87e3109fca3f2f9c6b5210575663 (patch) | |
| tree | 08783c201e5357d328bed20113fb952367509c82 /scripts/Dpkg/Source/Package | |
| parent | 39e0a3b9a62705098253ca4830654b6e9567a743 (diff) | |
| download | dpkg-d6851023a9ab87e3109fca3f2f9c6b5210575663.tar.gz | |
Do not quote simple identifier hash keys in initializations
Do not quote the keys for any hash which will always use simple
identifiers, as that is taken care of by the => operator. So this does
not apply to overload pragmas, version operators, field names, substvars,
command line options or filenames.
Addresses ValuesAndExpressions::ProhibitInterpolationOfLiterals.
Warned-by: perlcritic
Diffstat (limited to 'scripts/Dpkg/Source/Package')
| -rw-r--r-- | scripts/Dpkg/Source/Package/V1.pm | 2 | ||||
| -rw-r--r-- | scripts/Dpkg/Source/Package/V2.pm | 2 | ||||
| -rw-r--r-- | scripts/Dpkg/Source/Package/V3/bzr.pm | 2 | ||||
| -rw-r--r-- | scripts/Dpkg/Source/Package/V3/native.pm | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/scripts/Dpkg/Source/Package/V1.pm b/scripts/Dpkg/Source/Package/V1.pm index eae7748ce..f278c5c46 100644 --- a/scripts/Dpkg/Source/Package/V1.pm +++ b/scripts/Dpkg/Source/Package/V1.pm @@ -307,7 +307,7 @@ sub do_build { my $tar = Dpkg::Source::Archive->new(filename => $newtar, compression => compression_guess_from_filename($tarname), compression_level => $self->{'options'}{'comp_level'}); - $tar->create(options => \@tar_ignore, 'chdir' => $tardirbase); + $tar->create(options => \@tar_ignore, chdir => $tardirbase); $tar->add_directory($tardirname); $tar->finish(); rename($newtar, $tarname) || diff --git a/scripts/Dpkg/Source/Package/V2.pm b/scripts/Dpkg/Source/Package/V2.pm index c05d9895d..ee9687386 100644 --- a/scripts/Dpkg/Source/Package/V2.pm +++ b/scripts/Dpkg/Source/Package/V2.pm @@ -530,7 +530,7 @@ sub do_build { my $debianfile = "$basenamerev.debian.tar." . $self->{'options'}{'comp_ext'}; info(_g("building %s in %s"), $sourcepackage, $debianfile); my $tar = Dpkg::Source::Archive->new(filename => $debianfile); - $tar->create(options => \@tar_ignore, 'chdir' => $dir); + $tar->create(options => \@tar_ignore, chdir => $dir); $tar->add_directory("debian"); foreach my $binary ($binaryfiles->get_seen_binaries()) { $tar->add_file($binary) unless $binary =~ m{^debian/}; diff --git a/scripts/Dpkg/Source/Package/V3/bzr.pm b/scripts/Dpkg/Source/Package/V3/bzr.pm index 08bbd13af..bba97fb21 100644 --- a/scripts/Dpkg/Source/Package/V3/bzr.pm +++ b/scripts/Dpkg/Source/Package/V3/bzr.pm @@ -155,7 +155,7 @@ sub do_build { my $tar = Dpkg::Source::Archive->new(filename => $debianfile, compression => $self->{'options'}{'compression'}, compression_level => $self->{'options'}{'comp_level'}); - $tar->create('chdir' => $tmp); + $tar->create(chdir => $tmp); $tar->add_directory($dirname); $tar->finish(); diff --git a/scripts/Dpkg/Source/Package/V3/native.pm b/scripts/Dpkg/Source/Package/V3/native.pm index 211e8fe6a..de0b43c5f 100644 --- a/scripts/Dpkg/Source/Package/V3/native.pm +++ b/scripts/Dpkg/Source/Package/V3/native.pm @@ -91,7 +91,7 @@ sub do_build { my $tar = Dpkg::Source::Archive->new(filename => $newtar, compression => compression_guess_from_filename($tarname), compression_level => $self->{'options'}{'comp_level'}); - $tar->create(options => \@tar_ignore, 'chdir' => $dirbase); + $tar->create(options => \@tar_ignore, chdir => $dirbase); $tar->add_directory($dirname); $tar->finish(); rename($newtar, $tarname) || |