diff options
| author | Guillem Jover <guillem@debian.org> | 2012-12-31 21:43:39 +0100 |
|---|---|---|
| committer | Guillem Jover <guillem@debian.org> | 2013-05-04 19:03:13 +0200 |
| commit | 6a73e3078b01a71d4a6ea90c85da16523ed56f1d (patch) | |
| tree | 4cc7a210e7e851395f7ba4989e3aac4aa9d32710 /scripts/Dpkg/Vars.pm | |
| parent | 62bc788a45e4a641c28ca9c8c5b9bb08f29faed8 (diff) | |
| download | dpkg-6a73e3078b01a71d4a6ea90c85da16523ed56f1d.tar.gz | |
Do not use double-quotes on strings that do not need interpolation
Using double-quotes imposes a small performance penalty as the perl
parser needs to check if any interpolation is needed. Use double-quotes
only when the string contains single-quotes. Ideally we'd use
double-quotes too for escaped meta-characters that might otherwise be
confusing to immediately see if they need interpolation or not, but the
policy does not (currently) allow to ignore these.
Fixes ValuesAndExpressions::ProhibitInterpolationOfLiterals.
Warned-by: perlcritic
Diffstat (limited to 'scripts/Dpkg/Vars.pm')
| -rw-r--r-- | scripts/Dpkg/Vars.pm | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/Dpkg/Vars.pm b/scripts/Dpkg/Vars.pm index d0ccb29f2..944e61511 100644 --- a/scripts/Dpkg/Vars.pm +++ b/scripts/Dpkg/Vars.pm @@ -19,7 +19,7 @@ package Dpkg::Vars; use strict; use warnings; -our $VERSION = "0.02"; +our $VERSION = '0.02'; use Dpkg::ErrorHandling; use Dpkg::Gettext; @@ -37,7 +37,7 @@ sub set_source_package { if (defined($sourcepackage)) { $v eq $sourcepackage || - error(_g("source package has two conflicting values - %s and %s"), + error(_g('source package has two conflicting values - %s and %s'), $sourcepackage, $v); } else { $sourcepackage = $v; |