perl: Slurp files more efficiently

Do not read each line to then join it, just switch on slurp mode and
do it in one go. Use the newly created function file_slurp.

Fixes InputOutput::ProhibitJoinedReadline.

Warned-by: perlcritic

1 files changed, 4 insertions, 3 deletions

diff --git a/src/t/100_dpkg_divert.t b/src/t/100_dpkg_divert.t
index 40af7a9f8..2e798075f 100644
--- a/src/t/100_dpkg_divert.t
+++ b/src/t/100_dpkg_divert.t
@@ -15,6 +15,7 @@
 
 use Test::More;
 use File::Spec;
+use Dpkg::File;
 use Dpkg::IPC;
 
 use strict;
@@ -97,13 +98,13 @@ sub call {
         is(join('', @output), join('', @expect), "@$args stdout");
     }
     if (defined $opts{expect_stdout_like}) {
-        like(join('', <$output>), $opts{expect_stdout_like}, "@$args stdout");
+        like(file_slurp($output), $opts{expect_stdout_like}, "@$args stdout");
     }
     if (defined $opts{expect_stderr}) {
-        is(join('', <$error>), $opts{expect_stderr}, "@$args stderr");
+        is(file_slurp($error), $opts{expect_stderr}, "@$args stderr");
     }
     if (defined $opts{expect_stderr_like}) {
-        like(join('', <$error>), $opts{expect_stderr_like}, "@$args stderr");
+        like(file_slurp($error), $opts{expect_stderr_like}, "@$args stderr");
     }
 
     close($output);