summaryrefslogtreecommitdiff
path: root/t/critic
diff options
context:
space:
mode:
authorGuillem Jover <guillem@debian.org>2017-01-26 13:21:49 +0100
committerGuillem Jover <guillem@debian.org>2017-01-26 23:26:32 +0100
commit1bb3cb87b16eefefb1e7e2728f50b2c7bad38846 (patch)
tree2613d6e4d05a14f8fd7273f26b244f4b731a8177 /t/critic
parent9d5e55d449a32a70158c81314649d312babd2684 (diff)
downloaddpkg-1bb3cb87b16eefefb1e7e2728f50b2c7bad38846.tar.gz
test: Disable perlcritic ValuesAndExpressions::RequireNumberSeparators
This test produces false positives on long hex numbers, even when they have been separated with underscores.
Diffstat (limited to 't/critic')
-rw-r--r--t/critic/perlcriticrc7
1 files changed, 3 insertions, 4 deletions
diff --git a/t/critic/perlcriticrc b/t/critic/perlcriticrc
index 1708e1f35..a968009ff 100644
--- a/t/critic/perlcriticrc
+++ b/t/critic/perlcriticrc
@@ -23,10 +23,6 @@ minimum_regex_length_to_complain_about = 60
# TODO: switch these to q{} ?
allow_if_string_contains_single_quote = 1
-[ValuesAndExpressions::RequireNumberSeparators]
-# Up to 5 digits considered visually clear.
-min_value = 99999
-
##
## Disable tests
##
@@ -127,3 +123,6 @@ min_value = 99999
# TODO: Check it out, some magic numbers are fine, octals for example.
[-ValuesAndExpressions::ProhibitMagicNumbers]
+
+# FIXME: False positives on long hex numbers, even when separated.
+[-ValuesAndExpressions::RequireNumberSeparators]