Merge https://salsa.debian.org/dpkg-team/dpkg

1 files changed, 70 insertions, 0 deletions

diff --git a/t/shellcheck.t b/t/shellcheck.t
new file mode 100644
index 000000000..0eb64bd05
--- /dev/null
+++ b/t/shellcheck.t
@@ -0,0 +1,70 @@
+#!/usr/bin/perl
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <https://www.gnu.org/licenses/>.
+
+use strict;
+use warnings;
+
+use Test::More;
+use Test::Dpkg qw(:needs);
+
+test_needs_author();
+test_needs_command('shellcheck');
+test_needs_srcdir_switch();
+
+my @todofiles = qw(
+    dselect/methods/disk/install
+    dselect/methods/disk/setup
+    dselect/methods/disk/update
+    dselect/methods/multicd/install
+    dselect/methods/multicd/setup
+    dselect/methods/multicd/update
+);
+my @files = qw(
+    autogen
+    get-version
+    run-script
+    debian/dpkg.cron.daily
+    debian/dpkg.postinst
+    debian/dpkg.postrm
+    scripts/dpkg-maintscript-helper.sh
+);
+my @shellcheck_opts = (
+    '--exclude=SC2039', # Allow local keyword.
+    '--exclude=SC2166', # Allow -a and -o.
+    '--exclude=SC2034', # Allow unused variables for colors.
+);
+
+plan tests => scalar @files;
+
+sub shell_syntax_ok
+{
+    my $file = shift;
+
+    my $tags = qx(shellcheck @shellcheck_opts $file 2>&1);
+
+    # Fixup the output:
+    chomp $tags;
+
+    my $ok = length $tags == 0;
+
+    ok($ok, 'shellcheck');
+    if (not $ok) {
+        diag($tags);
+    }
+}
+
+foreach my $file (@files) {
+    shell_syntax_ok($file);
+}