u-a: Fix TOCTOU race in rename_mv()

This does not have any security implications, but it makes the code
more robust.

Warned-by: coverity

1 files changed, 9 insertions, 13 deletions

diff --git a/utils/update-alternatives.c b/utils/update-alternatives.c
index 3fe9d44f8..3dd9414be 100644
--- a/utils/update-alternatives.c
+++ b/utils/update-alternatives.c
@@ -459,23 +459,19 @@ subcall(const char *prog, ...)
 static bool
 rename_mv(const char *src, const char *dst)
 {
-	struct stat st;
+	const char *args[] = { "mv", src, dst, NULL };
+	int rc;
 
-	if (lstat(src, &st) != 0)
+	if (rename(src, dst) == 0)
+		return true;
+	if (errno == ENOENT)
 		return false;
 
-	if (rename(src, dst) != 0) {
-		const char *args[] = { "mv", src, dst, NULL };
-		int rc;
-
-		rc = spawn("mv", args);
-		if (WIFEXITED(rc) && WEXITSTATUS(rc) == 0)
-			return true;
-
-		return false;
-	}
+	rc = spawn("mv", args);
+	if (WIFEXITED(rc) && WEXITSTATUS(rc) == 0)
+		return true;
 
-	return true;
+	return false;
 }
 
 static void