summaryrefslogtreecommitdiff
path: root/dselect/methods
AgeCommit message (Collapse)AuthorFilesLines
2017-09-24Dselect::Ftp: Avoid many function arguments in do_connect()Guillem Jover4-54/+56
Addresses: Subroutines::ProhibitManyArgs Warned-by: perlcritic
2017-05-07build: Use libexec variable for auxiliary internal programsGuillem Jover1-1/+1
Using libdir is wrong, and doubly so when being referred from architecture independent files such as perl modules. This affects non-Debian based systems, which might by default use an arch varying libdir per architecture, for example when using the obsolete multilib layout.
2017-05-06doc: Spelling fixesJosh Soref2-2/+2
Signed-off-by: Guillem Jover <guillem@debian.org>
2017-01-22doc: Fix typos in documentation and code commentsGuillem Jover1-1/+1
Warned-by: codespell, spellintian
2016-10-30perl: Remove default «.» from @INC before loading modulesGuillem Jover3-2/+9
When loading eval'ed modules we should remove «.» from @INC, or we might end up loading code under the caller's control. Fixes: CVE-2016-1238
2016-10-29build: Use two space indentation for shell codeGuillem Jover1-2/+2
2015-10-18Update Heiko Schlittermann's email addressGuillem Jover3-3/+3
2015-10-18Update Ian Jackson's email addressGuillem Jover3-4/+4
2015-09-17dselect: Switch multicd method license from GPL2 to GPL2+Guillem Jover3-6/+9
All authors have agreed to the change: Heiko in <https://lists.debian.org/debian-dpkg/2010/04/msg00057.html> Martin in <https://lists.debian.org/debian-dpkg/2010/04/msg00055.html> Ian in <https://lists.debian.org/debian-dpkg/2015/08/msg00029.html> Raphaël in <https://lists.debian.org/debian-dpkg/2010/04/msg00054.html> Guillem with this commit. Signed-off-by: Heiko Schlittermann <hs@schlittermann.de> Signed-off-by: Martin Schulze <joey@infodrom.org> Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk> Signed-off-by: Raphaël Hertzog <hertzog@debian.org> Signed-off-by: Guillem Jover <guillem@debian.org>
2015-09-14perl: Split overlong regexes into multiline extended regexesGuillem Jover1-2/+9
This should make the regular expressions easier to read and understand, and allows to add comments describing specific parts. Addresses RegularExpressions::RequireExtendedFormatting. Warned-by: perlcritic
2015-05-30scripts, dselsect/methods: Switch from `` to operator qx()Guillem Jover4-10/+10
2015-05-18dselect: Remove outdated local copy of the Debian README.mirrors.txt fileGuillem Jover3-267/+4
This file was a very outdated copy from before 2001, the user is better served by downloading it once they are doing the setup, in case they use Debian. There's no point in doing it ourselves, as the download methods need a major revamp anyway. Closes: #784966
2015-05-09build: Use single suffix rules instead of non-portable %-pattern rulesGuillem Jover1-1/+3
2015-04-10Consistently use proper quotation marks all over the placeGuillem Jover1-1/+1
That is "" or '', and not the unbalanced `' pair.
2015-03-31Say directory instead of dir in output messagesGuillem Jover1-2/+2
2015-03-31Use "<enter>" instead of "return" or "enter" in input promptsGuillem Jover1-1/+1
This should make it more clear we are talking about the key and not something else.
2015-03-30perl: Rework use and exporter declarationsGuillem Jover1-4/+13
Place 'use' strict and warnings first, then Exporter 'our' declarations, then Test module imports, then system module imports, then Dpkg module imports, then 'use' parent and overload pragmas, separated by a blank line for each block. Split each exported symbol declaration into its own line to ease modifications.
2015-01-28perl: Switch from legacy File::Path functions to new onesGuillem Jover1-4/+4
Use make_path() instead of mkpath(), and remove_tree() instead of rmtree().
2015-01-28build: Rename perl scripts to have a .pl extensionGuillem Jover5-4/+26
This allows to easily replace the shebang at installation time to use the system perl interpreter and will make it easier to analyze all perl scripts in the source tree.
2014-10-06perl: Use length instead of /^$/ to test for an empty stringGuillem Jover1-2/+2
Addresses RegularExpressions::ProhibitFixedStringMatches. Warned-by: perlcritic
2014-10-06dselect: Quote the FTP package name instead of trying to manually escape itGuillem Jover1-3/+1
2014-10-06scripts: Use named variables instead of using the topic variableGuillem Jover1-12/+12
Switch code that uses roughly more explicit instances of the topic variable than implicit ones. Addresses BuiltinFunctions::ProhibitUselessTopic. Warned-by: perlcritic
2014-10-06dselect: Remove unnecessary handling of obsolete Package_Revision fieldGuillem Jover1-1/+0
This is automatically handled by «dpkg-deb --field» now that it uses the libdpkg deb822 parser.
2014-08-09Use https:// URLs instead of http:// when possible (round two)Guillem Jover1-1/+1
Switch more URLs, now that these services have had SSL enabled.
2014-05-17perl: Fix unused capture groups false positivesGuillem Jover1-2/+2
These are false positives, as when there's no match perl will leave the subpattern variables untouched. We'll just use the opportunity to unconfuse perlcritic, making some of those variable usages more clear by using intermediate variables. Fixes RegularExpressions::ProhibitUnusedCapture. Warned-by: perlcritic
2014-05-17perl: Do not use global match variablesGuillem Jover2-6/+6
Fixes Variables::ProhibitMatchVars. Warned-by: perlcritic
2013-12-07Use https:// URLs instead of http:// when possibleGuillem Jover13-13/+13
2013-12-04perl: Surround FileHandles with braces in print callsGuillem Jover2-2/+2
Fixes InputOutput::RequireBracedFileHandleWithPrint. Warned-by: perlcritic
2013-12-04dselect: Use warn instead of print STDERR in method scriptsGuillem Jover5-8/+8
Addresses InputOutput::RequireBracedFileHandleWithPrint. Warned-by: perlcritic
2013-12-04perl: Use croak instead of die on programming errors in modulesGuillem Jover1-1/+2
Addresses ErrorHandling::RequireCarping. Warned-by: perlcritic
2013-12-04perl: Switch to use low precedence boolean operators for error checksGuillem Jover4-11/+11
This will make it safe to remove parenthesis around builtins.
2013-12-04perl: Try to avoid boolean operators after predicates on error checksGuillem Jover2-10/+16
Using boolean operators after predicates for error checking makes the code flow slightly confusing, do that only after actions, to check if they succeeded and error out otherwise.
2013-11-24perl: Always check open() return valueGuillem Jover1-2/+4
Fixes InputOutput::RequireCheckedOpen. Warned-by: perlcritic
2013-11-24Consistently use regex instead of regexp when possibleGuillem Jover1-1/+1
All changed instances are documentation or private code interfaces. The only remaining variable instance with a regexp name is a publicly exposed variable, which will eventually disappear once it has gone through the deprecation process.
2013-11-24Dselect::Ftp: Uppercase public %config package variableGuillem Jover4-54/+55
This module has a problematic license, so there's no point in doing a more intrusive cleanup, just uppercase the variable and be done with it. Addresses Variables::ProhibitPackageVars. Warned-by: perlcritic
2013-11-24dselect: Make $ftp variable file global in ftp install methodGuillem Jover1-6/+6
The code is already using a $::ftp variable to be able to cleanup on errors, just move the definition of the $ftp variable outside of the download() function. Addresses Variables::ProhibitPackageVars. Warned-by: perlcritic
2013-11-23perl: Do not allow hard tabs anywhere other than leading positionGuillem Jover2-7/+10
Fixes CodeLayout::ProhibitHardTabs. Warned-by: perlcritic
2013-09-19Decapitalize error and warning messagesGuillem Jover5-16/+17
2013-06-22perl: Add a VERSION to all modulesGuillem Jover1-0/+2
Addresses Modules::RequireVersionVar.
2013-06-22perl: Place strict and warning pragma uses as the first thingGuillem Jover1-3/+3
2013-06-22perl: Decapitalize variable namesGuillem Jover1-5/+5
Addresses NamingConventions::Capitalization.
2013-05-08perl: Use my-style lexical loop iterator variablesGuillem Jover3-27/+20
The variables used on a foreach loop are local to that block, so if we wanted to use it after the loop is finished the last value would be gone. Fixes Variables::RequireLexicalLoopIterators. Warned-by: perlcritic
2013-05-08perl: Conditionally include modules with require instead of useGuillem Jover1-2/+2
Fixes Modules::ProhibitConditionalUseStatements. Warned-by: perlcritic
2013-05-08perl: Unify regex delimiters to //, {} or <>Guillem Jover2-4/+4
Fixes RegularExpressions::ProhibitUnusualDelimiters. Warned-by: perlcritic
2013-05-08Remove trailing whitespacesGuillem Jover3-5/+5
Do not fix the shlibs conffiles to avoid possible useless prompts. Fixes CodeLayout::ProhibitTrailingWhitespace. Warned-by: perlcritic
2013-05-08perl: Use correct comparison operator for each typeGuillem Jover1-1/+1
Fixes ValuesAndExpressions::ProhibitMismatchedOperators. Warned-by: perlcritic
2013-05-08perl: Remove unused variablesGuillem Jover3-4/+2
Fixes Variables::ProhibitUnusedVariables. Warned-by: perlcritic
2013-05-04Do not use double-quotes on strings that do not need interpolationGuillem Jover4-92/+94
Using double-quotes imposes a small performance penalty as the perl parser needs to check if any interpolation is needed. Use double-quotes only when the string contains single-quotes. Ideally we'd use double-quotes too for escaped meta-characters that might otherwise be confusing to immediately see if they need interpolation or not, but the policy does not (currently) allow to ignore these. Fixes ValuesAndExpressions::ProhibitInterpolationOfLiterals. Warned-by: perlcritic
2013-04-30Do not quote simple identifier hash keys in element accessesGuillem Jover6-52/+54
Addresses ValuesAndExpressions::ProhibitInterpolationOfLiterals. Warned-by: perlcritic
2013-04-28Fix file descriptor leaks in perl codeGuillem Jover1-0/+1
generated by cgit v1.2.3 (git 2.39.1) at 2025-03-03 23:03:45 +0000