Age | Commit message (Collapse) | Author | Files | Lines |
|
This is detected by codespell as a spelling error. Just use the
non-abbreviated form to make it more clear and stop triggering
codespell.
Warned-by: codespell
|
|
This has been obsoleted long ago.
|
|
|
|
Addresses: Subroutines::ProhibitManyArgs
Warned-by: perlcritic
|
|
Using libdir is wrong, and doubly so when being referred from
architecture independent files such as perl modules. This affects
non-Debian based systems, which might by default use an arch varying
libdir per architecture, for example when using the obsolete multilib
layout.
|
|
Signed-off-by: Guillem Jover <guillem@debian.org>
|
|
Warned-by: codespell, spellintian
|
|
When loading eval'ed modules we should remove «.» from @INC, or we
might end up loading code under the caller's control.
Fixes: CVE-2016-1238
|
|
|
|
|
|
|
|
All authors have agreed to the change:
Heiko in <https://lists.debian.org/debian-dpkg/2010/04/msg00057.html>
Martin in <https://lists.debian.org/debian-dpkg/2010/04/msg00055.html>
Ian in <https://lists.debian.org/debian-dpkg/2015/08/msg00029.html>
Raphaël in <https://lists.debian.org/debian-dpkg/2010/04/msg00054.html>
Guillem with this commit.
Signed-off-by: Heiko Schlittermann <hs@schlittermann.de>
Signed-off-by: Martin Schulze <joey@infodrom.org>
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Signed-off-by: Raphaël Hertzog <hertzog@debian.org>
Signed-off-by: Guillem Jover <guillem@debian.org>
|
|
This should make the regular expressions easier to read and understand,
and allows to add comments describing specific parts.
Addresses RegularExpressions::RequireExtendedFormatting.
Warned-by: perlcritic
|
|
|
|
This file was a very outdated copy from before 2001, the user is better
served by downloading it once they are doing the setup, in case they use
Debian. There's no point in doing it ourselves, as the download methods
need a major revamp anyway.
Closes: #784966
|
|
|
|
That is "" or '', and not the unbalanced `' pair.
|
|
|
|
This should make it more clear we are talking about the key and not
something else.
|
|
Place 'use' strict and warnings first, then Exporter 'our' declarations,
then Test module imports, then system module imports, then Dpkg module
imports, then 'use' parent and overload pragmas, separated by a blank
line for each block.
Split each exported symbol declaration into its own line to ease
modifications.
|
|
Use make_path() instead of mkpath(), and remove_tree() instead of
rmtree().
|
|
This allows to easily replace the shebang at installation time to use
the system perl interpreter and will make it easier to analyze all
perl scripts in the source tree.
|
|
Addresses RegularExpressions::ProhibitFixedStringMatches.
Warned-by: perlcritic
|
|
|
|
Switch code that uses roughly more explicit instances of the topic
variable than implicit ones.
Addresses BuiltinFunctions::ProhibitUselessTopic.
Warned-by: perlcritic
|
|
This is automatically handled by «dpkg-deb --field» now that it uses
the libdpkg deb822 parser.
|
|
Switch more URLs, now that these services have had SSL enabled.
|
|
These are false positives, as when there's no match perl will leave
the subpattern variables untouched. We'll just use the opportunity to
unconfuse perlcritic, making some of those variable usages more clear
by using intermediate variables.
Fixes RegularExpressions::ProhibitUnusedCapture.
Warned-by: perlcritic
|
|
Fixes Variables::ProhibitMatchVars.
Warned-by: perlcritic
|
|
|
|
Fixes InputOutput::RequireBracedFileHandleWithPrint.
Warned-by: perlcritic
|
|
Addresses InputOutput::RequireBracedFileHandleWithPrint.
Warned-by: perlcritic
|
|
Addresses ErrorHandling::RequireCarping.
Warned-by: perlcritic
|
|
This will make it safe to remove parenthesis around builtins.
|
|
Using boolean operators after predicates for error checking makes the
code flow slightly confusing, do that only after actions, to check if
they succeeded and error out otherwise.
|
|
Fixes InputOutput::RequireCheckedOpen.
Warned-by: perlcritic
|
|
All changed instances are documentation or private code interfaces.
The only remaining variable instance with a regexp name is a publicly
exposed variable, which will eventually disappear once it has gone
through the deprecation process.
|
|
This module has a problematic license, so there's no point in doing
a more intrusive cleanup, just uppercase the variable and be done
with it.
Addresses Variables::ProhibitPackageVars.
Warned-by: perlcritic
|
|
The code is already using a $::ftp variable to be able to cleanup on
errors, just move the definition of the $ftp variable outside of the
download() function.
Addresses Variables::ProhibitPackageVars.
Warned-by: perlcritic
|
|
Fixes CodeLayout::ProhibitHardTabs.
Warned-by: perlcritic
|
|
|
|
Addresses Modules::RequireVersionVar.
|
|
|
|
Addresses NamingConventions::Capitalization.
|
|
The variables used on a foreach loop are local to that block, so if
we wanted to use it after the loop is finished the last value would
be gone.
Fixes Variables::RequireLexicalLoopIterators.
Warned-by: perlcritic
|
|
Fixes Modules::ProhibitConditionalUseStatements.
Warned-by: perlcritic
|
|
Fixes RegularExpressions::ProhibitUnusualDelimiters.
Warned-by: perlcritic
|
|
Do not fix the shlibs conffiles to avoid possible useless prompts.
Fixes CodeLayout::ProhibitTrailingWhitespace.
Warned-by: perlcritic
|
|
Fixes ValuesAndExpressions::ProhibitMismatchedOperators.
Warned-by: perlcritic
|
|
Fixes Variables::ProhibitUnusedVariables.
Warned-by: perlcritic
|