summaryrefslogtreecommitdiff
path: root/dselect
AgeCommit message (Collapse)AuthorFilesLines
2019-11-27German dselect translation updateSven Joachim1-7/+8
Update to 274t.
2019-11-26dpkg: Fix and clarify behavior for packages marked to be on “hold”Guillem Jover1-2/+2
A package marked to be on hold, denotes that the package should be kept in its current version and should not be automatically installed, upgraded or removed. The same applies to frontends. This behavior does not apply when the user explicitly requested one of these actions, or the --force-hold option is used. It should never prevent dpkg from processing these for configuration (if they were already in unpacked state) or from trigger processing, otherwise we might get into trigger loops. Some of the code was already doing this, but this was not consistently done. We update also the help output and documentation to clarify the fixed behavior. Closes: #926472
2019-10-30dselect: Make baselist::draw_column_*() col arguments constGuillem Jover2-6/+6
Warned-by: cppcheck Fixes: constParameter
2019-10-30libdpkg: Add new C locale switch over supportGuillem Jover1-0/+1
This will make it possible to select either the current locale or a specified one, currently only C is selectable. We use this because the uselocale(3) POSIX API is recent, and the system might not have it available, so we might need to fallback to use setlocale(3) instead, which even though is not thread-safe, it's better than nothing.
2019-10-30dselect: Reduce scope of variableGuillem Jover1-2/+3
The variable was being assigned in one side of an if branch, but the result never used. Let's reduce the scope to the if branch that actually assigns and uses it. Warned-by: cppcheck
2019-06-03po: Regenerate .pot files and merge .po files with themGuillem Jover31-32/+32
2019-06-03doc: Fix typosGuillem Jover1-1/+1
Warned-by: codespell
2019-05-09po: Update Catalan translationsGuillem Jover1-4/+4
2019-03-25po: Regenerate .pot files and merge .po files with themGuillem Jover31-32/+32
2019-02-23po: Regenerate .pot files and merge .po files with themGuillem Jover31-32/+32
2019-01-22po: Regenerate .pot files and merge .po files with themGuillem Jover31-32/+32
2019-01-22libdpkg: Rename pkg_db symbols to pkg_hashGuillem Jover1-5/+5
These are handling a package hash, and db seems to imply some kind of on-disk storage. Rename the pkgiterator too to pkg_hash_iter to make it consistent.
2019-01-22dselect: Rename variable r to pkgbinGuillem Jover1-4/+5
This makes it clear what the variable is all about.
2018-10-08po: Regenerate .pot files and merge .po files with themGuillem Jover31-32/+32
2018-09-26po: Regenerate .pot files and merge .po files with themGuillem Jover31-370/+295
2018-08-30dselect: Rename $ans variable to $answer in multicd methodGuillem Jover1-2/+2
This is detected by codespell as a spelling error. Just use the non-abbreviated form to make it more clear and stop triggering codespell. Warned-by: codespell
2018-08-30Switch from strchr() + strlen() to strchrnul()Guillem Jover2-6/+7
2018-08-30libdpkg: Split push_cleanup() into push_cleanup_fallback()Guillem Jover2-2/+2
We separate the function in one that takes one callback, and another that takes two. This simplifies most of the call sites which only need one callback.
2018-08-30libdpkg: Rename struct pkginfo files member to archivesGuillem Jover1-1/+1
Rename matching types and macros, so that the purpose of the symbols is clear, and to open the way for moving the fsys files list from the dpkg clientdata.
2018-08-30libdpkg, dselect: Use new pkg_name_const() and pkgbin_name_const()Guillem Jover1-1/+1
This will make it possible to switch the pkg_name() and pkgbin_name() back to take non-const structs, and then fill the pkgname_archqual cache on demand.
2018-08-01dselect: Disable copy constructor and = operator for methodlist classGuillem Jover1-0/+2
The constructor deals with dynamically allocated memory, so we should not be using the default copy constructor and = operators, disabled them to avoid surprises. Warned-by: cppcheck
2018-08-01dselect: Use override attribute for virtual methods in derived classesGuillem Jover2-19/+19
C++11 makes it possible to use these attributes so that errors can be avoided, by helping the compiler know when we mean methods to override the ones from the parent class. Warned-by: cppcheck
2018-08-01dselect: Declare constructor with one argument as explicitGuillem Jover1-1/+1
Warned-by: cppcheck
2018-08-01dselect: Remove duplicate searchstring member declaration in derived classGuillem Jover1-3/+0
This is already declared in class baselist, no need to declare it too in class methodlist. Warned-by: cppcheck
2018-07-24po: Fix boilerplate in .po filesGuillem Jover7-20/+17
Warned-by: i18nspector Fixes: boilerplate-in-initial-comments
2018-03-26Use internerr() or BUG() instead of assert()Guillem Jover9-25/+46
The problem with assert() is that it does not print the contents of the variables. It also can be disabled on NDEBUG. But we always want these consistency checks no matter what, and they are not performance sensitive anyway. Enable -Wno-nonnull-compare so that we can keep doing run-time non-NULL checks in functions, instead of just compile-time checks.
2018-03-26dselect: Fix assert() to expect methlockfd to be initializedGuillem Jover1-1/+1
The assert should be checking whether the method lock fd has been initialized, not whether it's not zero, which happens to be the case with the default uninitialized -1 value.
2018-03-26dselect: Assume that m_malloc() never returns NULLGuillem Jover1-13/+2
The m_-prefixed functions are already taking care of that.
2017-11-08Update Spanish translationJavier Fernandez-Sanguino1-66/+28
2017-10-21po: Remove obsolete FIXME comments in translationsGuillem Jover1-2/+1
These have been fixed in the original msgid.
2017-10-21dselect: Stop marking an untranslatable string as suchGuillem Jover1-1/+1
Spotted-by: Santiago Vila <sanvila@debian.org>
2017-10-17po: Regenerate .pot files and merge .po files with themGuillem Jover31-32/+32
2017-10-09dselect: Remove traces of non-US support from methodsGuillem Jover9-38/+13
This has been obsoleted long ago.
2017-10-09dselect: Remove long obsolete floppy methodGuillem Jover6-307/+0
2017-09-24Dselect::Ftp: Avoid many function arguments in do_connect()Guillem Jover4-54/+56
Addresses: Subroutines::ProhibitManyArgs Warned-by: perlcritic
2017-05-18po: Regenerate .pot files and merge .po files with themGuillem Jover31-34/+34
2017-05-07build: Use libexec variable for auxiliary internal programsGuillem Jover2-2/+3
Using libdir is wrong, and doubly so when being referred from architecture independent files such as perl modules. This affects non-Debian based systems, which might by default use an arch varying libdir per architecture, for example when using the obsolete multilib layout.
2017-05-07po: Update Catalan translationGuillem Jover1-64/+30
2017-05-06doc: Spelling fixesJosh Soref5-5/+5
Signed-off-by: Guillem Jover <guillem@debian.org>
2017-05-06Updated Czech translationMiroslav Kure1-118/+85
2017-03-06po: Regenerate .pot files and merge .po files with themGuillem Jover31-32/+32
2017-02-26dselect: Do not depend on cxxabi.h to have declared __cxa_pure_virtualJörg Sonnenberger1-1/+5
The C++ ABI specifies that these functions are within the “__cxxabiv1” namespace, and that “abi” is an alias to be used by userland. But in this case as we are replacing the implementation we should also use the same canonical namespace. Signed-off-by: Guillem Jover <guillem@debian.org>
2017-02-01po: Regenerate .pot files and merge .po files with themGuillem Jover31-32/+32
2017-01-29po: Regenerate .pot files and merge .po files with themGuillem Jover31-32/+32
2017-01-28po: Regenerate .pot files and merge .po files with themGuillem Jover31-32/+32
2017-01-27po: Regenerate .pot files and merge .po files with themGuillem Jover31-32/+32
2017-01-22doc: Fix typos in documentation and code commentsGuillem Jover1-1/+1
Warned-by: codespell, spellintian
2016-12-20po: Regenerate .pot files and merge .po files with themGuillem Jover31-32/+32
2016-12-19po: Regenerate .pot files and merge .po files with themGuillem Jover31-32/+32
2016-12-17po: Regenerate .pot files and merge .po files with themGuillem Jover31-32/+32