Age | Commit message (Collapse) | Author | Files | Lines |
|
These were referring to the type and not the instance, which makes
using the incorrect nomenclature confusing.
|
|
If we are not using signal handling code we should not be imposing the
additional load times over most modules using the transparent compression
support, which currently includes all Dpkg::Control users.
|
|
|
|
Avoid the indirection, and use the more current module.
|
|
Rename private functions names, so that they have an underscore and
more uniform names. This way it is made explicit that those functions
are not expected to be used by external modules, and provide no
guarantees on their API stability.
|
|
Make it compile.
|
|
These are strongly discouraged by the man-pages project, because they
are redundant with the copyright notices, and tend to get out-of-sync.
In addition their format is inconsitent. Just remove them in the same
way we did for man pages in the past.
|
|
|
|
This has two purposes, first it will make it easier to know if the
module version needs to be bumped for the current development release,
and second it will make it easier for users to know how "old" that
module version is, and to which dpkg series and specific version it
corresponds to.
|
|
Place 'use' strict and warnings first, then Exporter 'our' declarations,
then Test module imports, then system module imports, then Dpkg module
imports, then 'use' parent and overload pragmas, separated by a blank
line for each block.
Split each exported symbol declaration into its own line to ease
modifications.
|
|
|
|
The old function name was inconsistent with the other gettext family
of short aliases which has already caused some code typos, and functions
starting with underscore are considered by convention private in Perl.
|
|
This makes it clear what is the current version of the module, and that
it is a public interface.
|
|
Addresses Subroutines::RequireArgUnpacking.
Warned-by: perlcritic
|
|
Switch code that uses roughly more explicit instances of the topic
variable than implicit ones.
Addresses BuiltinFunctions::ProhibitUselessTopic.
Warned-by: perlcritic
|
|
This options will be passed down the the (un)compressor spawn()'s
call.
|
|
Replace only safe usages, i.e. those that fallback on initialization
values that evaluate to false anyway. Or when the API is explicit about
the variable being undefined.
|
|
Replace only safe usages, i.e. those that fallback on initialization
values that evaluate to false anyway. Or when the API is explicit about
the variable being undefined.
|
|
|
|
|
|
Remove now unused internerr() function, replaced by croak which does a
way better job.
Addresses ErrorHandling::RequireCarping.
Warned-by: perlcritic
|
|
This will make it safe to remove parenthesis around builtins.
|
|
Replace all direct accesses to $compression_re_file_ext with calls to
the new function, and mark the variable as deprecated to be removed on
VERSION 2.00.
Addresses Variables::ProhibitPackageVars.
Warned-by: perlcritic
|
|
|
|
Use the lightweight parent instead of the bloated base.
|
|
Using double-quotes imposes a small performance penalty as the perl
parser needs to check if any interpolation is needed. Use double-quotes
only when the string contains single-quotes. Ideally we'd use
double-quotes too for escaped meta-characters that might otherwise be
confusing to immediately see if they need interpolation or not, but the
policy does not (currently) allow to ignore these.
Fixes ValuesAndExpressions::ProhibitInterpolationOfLiterals.
Warned-by: perlcritic
|
|
Addresses ValuesAndExpressions::ProhibitInterpolationOfLiterals.
Warned-by: perlcritic
|
|
|
|
Do not forward the integer parameter passed to the EOF method since
perl 5.12, as the IO::Handle::eof function rejects it.
This problem has been latent because for example Dpkg::Source::Patch
was importing the whole POSIX module, including the EOF constant, which
shadowed the EOF method.
|
|
This makes sure the functions always return the appropriate value
independent of the context.
Fixes Subroutines::ProhibitExplicitReturnUndef.
Warned-by: perlcritic
|
|
Also fix many spelling errors spotted by lintian.
|
|
This will allow storing arguments alongside the command names
themselves.
|
|
Modules whose API should be stable have a version 1.00.
The modules with version 0.01 are expected to have further API
changes in the (near) future or are deemed to be useful mostly
for dpkg-dev's internal usage.
|
|
The syscall-like interface should not error out when the file has not been
opened, it must simply return failure codes.
|
|
|
|
|
|
Dpkg::Compression::CompressedFile -> Dpkg::Compression::FileHandle
Dpkg::Compression::Compressor -> Dpkg::Compression::Process
The new names are more expressive and avoid repeating "Compress".
Update all scripts and modules to use the new name.
|
|
Dpkg::Compression now provides new functions to get/set the default
compression method and the default compression level. There was no
good reason to have it in Dpkg::Compression::Compressor in the first
place.
Factorize some code to verify validity of what should be a compression
level in new function compression_is_valid_level($level).
dpkg-source has been updated to cope with the changes.
|
|
This API change requires lots of adjustements through the source code.
|
|
Change the Dpkg::Compression::CompressedFile API to make it behave like
a normal filehandle.
Update all users of the object to use the new API.
|
|
|
|
|