Age | Commit message (Collapse) | Author | Files | Lines |
|
We might use a vendor specific series file, so we should print the one
being used to notify if this fact.
|
|
To be able to build a source tree, a user needs write permisions on it,
but not necessarily ownership of those files. We check the existing file
permissions and avoid changing them if not necessary, which helps in the
case where the user does not have ownership of those files, and they
were already present.
Closes: #898010
Naming-by: Julian Andres Klode <jak@debian.org>
|
|
Our current minimal Perl version contains a new enough List::Util module
implementing none and any, and several other functions.
|
|
|
|
This will print source format specific options depending on the
--format version specified.
|
|
When we check if the first quilt patch in a series can be applied, we
use «patch --dry-run» with other options, but that cannot work if the
same diff patches a file multiple times, as patch does not record the
previous state in memory.
We are alredy detecting this condition, but only emitting a warning,
instead make it possible to turn it into a fatal error.
Closes: #810720
Reported-by: Apollon Oikonomopoulos <apoikos@debian.org>
|
|
That is "" or '', and not the unbalanced `' pair.
|
|
Place 'use' strict and warnings first, then Exporter 'our' declarations,
then Test module imports, then system module imports, then Dpkg module
imports, then 'use' parent and overload pragmas, separated by a blank
line for each block.
Split each exported symbol declaration into its own line to ease
modifications.
|
|
|
|
|
|
The old function name was inconsistent with the other gettext family
of short aliases which has already caused some code typos, and functions
starting with underscore are considered by convention private in Perl.
|
|
Addresses Subroutines::RequireArgUnpacking.
Warned-by: perlcritic
|
|
Addresses RegularExpressions::ProhibitFixedStringMatches.
Warned-by: perlcritic
|
|
|
|
Refactor the code out from Dpkg::Source::Package::V3::Quilt into two new
methods that take care of registering and unregistering a patch from the
series and applied_patches in-core and on-disk lists.
|
|
Do not mangle the series files when the last line is missing a newline,
by loading and saving the file with the added patch. This is quite ugly
in general, but fixes the immediate problem. The code will be getting a
general overhaul in due time.
Closes: #584233
|
|
|
|
This is the normal counterpart to load actions.
|
|
Closes: #719348, #733746
|
|
|
|
Fixes InputOutput::RequireBracedFileHandleWithPrint.
Warned-by: perlcritic
|
|
This will make it safe to remove parenthesis around builtins.
|
|
All changed instances are documentation or private code interfaces.
The only remaining variable instance with a regexp name is a publicly
exposed variable, which will eventually disappear once it has gone
through the deprecation process.
|
|
This avoids using the grep builtin on scalar context, which is
suboptimal as it does not short-circuit on first match, and it's
intended to produce an output array.
Ideally we'd directly use the functions from List::MoreUtils, because
they might be more performant, but not being a core module is a show
stopper.
Addresses BuiltinFunctions::ProhibitBooleanGrep.
|
|
|
|
Ensure that a 3.0 (quilt) package has a non-native version and that
a 3.0 (native) package has a native version. To get the information,
extend Dpkg::Version with a is_native method to check whether a
version has a revision or not.
[guillem@debian.org:
- Add is_native to history of changes.
- Do not return an error string when returning a true result. ]
Closes: #700177
Signed-off-by: Guillem Jover <guillem@debian.org>
|
|
Use the lightweight parent instead of the bloated base.
|
|
Lowercase module names are reserved by convention for pragmas, and
there's really no need to diverge here from the general dpkg project
naming convention. Also make sure source package format variant names
are always in lowercase, to not allow names that would not work with
previous dpkg-source versions.
Fixes NamingConventions::Capitalization.
|