summaryrefslogtreecommitdiff
path: root/scripts/Dpkg/Source/Package/V3/Quilt.pm
AgeCommit message (Collapse)AuthorFilesLines
2018-08-30Dpkg::Source::Package::V3::Quilt: Print series file used when applying patchesGuillem Jover1-0/+2
We might use a vendor specific series file, so we should print the one being used to notify if this fact.
2018-08-01Dpkg::Source: Do not change patch permissions if not necessaryGuillem Jover1-2/+2
To be able to build a source tree, a user needs write permisions on it, but not necessarily ownership of those files. We check the existing file permissions and avoid changing them if not necessary, which helps in the case where the user does not have ownership of those files, and they were already present. Closes: #898010 Naming-by: Julian Andres Klode <jak@debian.org>
2017-05-20Dpkg::Util: Remove and replace with core module List::UtilGuillem Jover1-1/+1
Our current minimal Perl version contains a new enough List::Util module implementing none and any, and several other functions.
2016-10-30Dpkg::Source::Package: Prefix private functions with _Guillem Jover1-8/+8
2016-02-15dpkg-source: Add backend-specific --help options supportGuillem Jover1-0/+20
This will print source format specific options depending on the --format version specified.
2016-01-26Dpkg::Source: Make patching a file multiple times fatal for first quilt patchGuillem Jover1-1/+1
When we check if the first quilt patch in a series can be applied, we use «patch --dry-run» with other options, but that cannot work if the same diff patches a file multiple times, as patch does not record the previous state in memory. We are alredy detecting this condition, but only emitting a warning, instead make it possible to turn it into a fatal error. Closes: #810720 Reported-by: Apollon Oikonomopoulos <apoikos@debian.org>
2015-04-10Consistently use proper quotation marks all over the placeGuillem Jover1-1/+1
That is "" or '', and not the unbalanced `' pair.
2015-03-30perl: Rework use and exporter declarationsGuillem Jover1-4/+4
Place 'use' strict and warnings first, then Exporter 'our' declarations, then Test module imports, then system module imports, then Dpkg module imports, then 'use' parent and overload pragmas, separated by a blank line for each block. Split each exported symbol declaration into its own line to ease modifications.
2015-01-28scripts: Remove unused «use Dpkg»Guillem Jover1-1/+0
2015-01-28Dpkg: Use shift instead of @_ on single argument unpackingGuillem Jover1-2/+2
2015-01-28scripts: Rename and deprecate _g function with g_Guillem Jover1-8/+8
The old function name was inconsistent with the other gettext family of short aliases which has already caused some code typos, and functions starting with underscore are considered by convention private in Perl.
2014-10-06scripts: Unpack arguments instead of accessing @_ directlyGuillem Jover1-3/+5
Addresses Subroutines::RequireArgUnpacking. Warned-by: perlcritic
2014-10-06Dpkg::Source::Package: Use a simple string match instead of a regexGuillem Jover1-2/+2
Addresses RegularExpressions::ProhibitFixedStringMatches. Warned-by: perlcritic
2014-08-09scripts: Use //= instead of explicit defined or exists checksGuillem Jover1-4/+2
2014-05-17Dpkg::Source::Quilt: Refactor register() and unregister() methodsGuillem Jover1-58/+2
Refactor the code out from Dpkg::Source::Package::V3::Quilt into two new methods that take care of registering and unregistering a patch from the series and applied_patches in-core and on-disk lists.
2014-05-17Dpkg::Source::Package::V3::Quilt: Handle series files with no final newlineGuillem Jover1-2/+7
Do not mangle the series files when the last line is missing a newline, by loading and saving the file with the added patch. This is quite ugly in general, but fixes the immediate problem. The code will be getting a general overhaul in due time. Closes: #584233
2014-05-17Dpkg::Source::Package::V3::Quilt: Refactor _load_file()Guillem Jover1-4/+12
2014-05-17Dpkg::Source::Quilt: Rename write_db() to save_db()Guillem Jover1-1/+1
This is the normal counterpart to load actions.
2014-01-15Dpkg::Source::Package::V3::Quilt: Clarify missing revision errorGuillem Jover1-1/+2
Closes: #719348, #733746
2013-12-07Use https:// URLs instead of http:// when possibleGuillem Jover1-1/+1
2013-12-04perl: Surround FileHandles with braces in print callsGuillem Jover1-2/+2
Fixes InputOutput::RequireBracedFileHandleWithPrint. Warned-by: perlcritic
2013-12-04perl: Switch to use low precedence boolean operators for error checksGuillem Jover1-12/+12
This will make it safe to remove parenthesis around builtins.
2013-11-24Consistently use regex instead of regexp when possibleGuillem Jover1-1/+1
All changed instances are documentation or private code interfaces. The only remaining variable instance with a regexp name is a publicly exposed variable, which will eventually disappear once it has gone through the deprecation process.
2013-07-18scripts: Use Dpkg::Util list functions instead of grepGuillem Jover1-1/+2
This avoids using the grep builtin on scalar context, which is suboptimal as it does not short-circuit on first match, and it's intended to produce an output array. Ideally we'd directly use the functions from List::MoreUtils, because they might be more performant, but not being a core module is a show stopper. Addresses BuiltinFunctions::ProhibitBooleanGrep.
2013-07-08Dpkg::Source::Package: Do not return an error message if we can buildGuillem Jover1-1/+1
2013-07-08Dpkg: Catch mismatches between version strings and format versionsBernhard R. Link1-0/+5
Ensure that a 3.0 (quilt) package has a non-native version and that a 3.0 (native) package has a native version. To get the information, extend Dpkg::Version with a is_native method to check whether a version has a revision or not. [guillem@debian.org: - Add is_native to history of changes. - Do not return an error string when returning a true result. ] Closes: #700177 Signed-off-by: Guillem Jover <guillem@debian.org>
2013-06-22scripts: Inherit from parent instead of baseGuillem Jover1-1/+1
Use the lightweight parent instead of the bloated base.
2013-06-22Dpkg::Source::Package: Capitalize variant module namesGuillem Jover1-0/+285
Lowercase module names are reserved by convention for pragmas, and there's really no need to diverge here from the general dpkg project naming convention. Also make sure source package format variant names are always in lowercase, to not allow names that would not work with previous dpkg-source versions. Fixes NamingConventions::Capitalization.