summaryrefslogtreecommitdiff
path: root/scripts/dpkg-mergechangelogs.pl
AgeCommit message (Collapse)AuthorFilesLines
2019-10-30scripts: Match ~deb also as a backport marker in versionsGuillem Jover1-2/+2
Closes: #934980
2019-10-30scripts: Remove support for ~vola versioningGuillem Jover1-4/+4
This was part of the volatile.debian.org archive, which was decommissioned some time ago. Ref: https://lists.debian.org/debian-volatile-announce/2012/msg00000.html
2019-10-12scripts: Switch Getopt::Long from bundling to bundling_valuesGuillem Jover1-1/+1
This got introduced after a request so that we could switch our tools to a safe subset of the bundling logic, so let's enable it now that it is available in the minimum supported perl version. Bundling is in general unsafe, and not future-proof, as new options might gain arguments which would then get misinterpreted, we should not really be using it. But bundling the value into the option is a common pattern and should be allowed.
2018-06-22scripts: Do not use stringy eval to define different sub implementationsGuillem Jover1-6/+4
We can just assign an anonymous sub to the typeglob.
2017-08-26perl: Use -> operator for function variablesGuillem Jover1-3/+3
2016-10-30perl: Remove default «.» from @INC before loading modulesGuillem Jover1-1/+4
When loading eval'ed modules we should remove «.» from @INC, or we might end up loading code under the caller's control. Fixes: CVE-2016-1238
2015-03-30perl: Rework use and exporter declarationsGuillem Jover1-3/+3
Place 'use' strict and warnings first, then Exporter 'our' declarations, then Test module imports, then system module imports, then Dpkg module imports, then 'use' parent and overload pragmas, separated by a blank line for each block. Split each exported symbol declaration into its own line to ease modifications.
2015-01-28scripts: Rename and deprecate _g function with g_Guillem Jover1-8/+8
The old function name was inconsistent with the other gettext family of short aliases which has already caused some code typos, and functions starting with underscore are considered by convention private in Perl.
2014-10-06scripts: Unpack arguments instead of accessing @_ directlyGuillem Jover1-2/+4
Addresses Subroutines::RequireArgUnpacking. Warned-by: perlcritic
2013-12-07Use https:// URLs instead of http:// when possibleGuillem Jover1-1/+1
2013-12-04perl: Surround FileHandles with braces in print callsGuillem Jover1-1/+1
Fixes InputOutput::RequireBracedFileHandleWithPrint. Warned-by: perlcritic
2013-12-04perl: Switch to use low precedence boolean operators for error checksGuillem Jover1-2/+3
This will make it safe to remove parenthesis around builtins.
2013-11-23perl: Do not allow hard tabs anywhere other than leading positionGuillem Jover1-7/+7
Fixes CodeLayout::ProhibitHardTabs. Warned-by: perlcritic
2013-07-26scripts: Use () instead of qw() for empty importsGuillem Jover1-1/+1
2013-07-08Switch usage errors to not print entire --help outputGuillem Jover1-4/+6
Just print a reference to use --help for further details. Which stops annoying experienced users, or users that made a typo on the command-line, by not overwhelming them with screenfuls of help output. Closes: #681371
2013-07-08scripts: Trap $SIG{__WARN__} to call usageerr() on option parse errorsGuillem Jover1-3/+4
This gives a nicer error message, and makes sure we always exit on option parse errors.
2013-07-04scripts: Move Getopt::Long option specifications to array variablesGuillem Jover1-3/+8
2013-06-22Dpkg: Deprecate lowercase exported by default variablesGuillem Jover1-3/+3
Rename, uppercase and do not export new variables by default, to avoid cluttering the caller namespace, and to give them consistent names. We'll keep the old variables for a while, to not break uses from external modules. Addresses Variables::ProhibitPackageVars.
2013-05-08perl: Remove unused variablesGuillem Jover1-1/+1
Fixes Variables::ProhibitUnusedVariables. Warned-by: perlcritic
2013-05-04Do not use double-quotes on strings that do not need interpolationGuillem Jover1-20/+20
Using double-quotes imposes a small performance penalty as the perl parser needs to check if any interpolation is needed. Use double-quotes only when the string contains single-quotes. Ideally we'd use double-quotes too for escaped meta-characters that might otherwise be confusing to immediately see if they need interpolation or not, but the policy does not (currently) allow to ignore these. Fixes ValuesAndExpressions::ProhibitInterpolationOfLiterals. Warned-by: perlcritic
2013-04-29scripts: Use // operator instead of an explicit defined checkGuillem Jover1-1/+1
2013-04-28Use proper variables instead of barewords for filehandlesGuillem Jover1-3/+3
Fixes InputOutput::ProhibitBarewordFileHandles. Warned-by: perlcritic
2012-06-30dpkg-mergechangelogs: Unify --help output with other commandsGuillem Jover1-1/+1
Print short options before long ones.
2012-06-30Align --version with --help on help outputGuillem Jover1-1/+1
2012-06-30Change all programs to accept -? instead of -h for help outputGuillem Jover1-1/+2
This switch frees the -h option to be used in the distant future for other purposes, it also uses a character that does not have any other obvious meaning for help output, and which is pretty safe to be used blindly by the user in the same way as --help.
2012-06-08scripts: Unify “<option>...” --help outputGuillem Jover1-1/+1
2012-05-23scripts: Handle argument parsing consistently when using Getopt::LongGuillem Jover1-1/+1
2012-02-01Move copyright information from --version output to file comment headersGuillem Jover1-2/+0
Having to keep this information twice is error-prone as it easily gets out of sync. Having to translate it is bothersome. It's not consistent across dpkg tools, some do print it some don't. It's currently not accurate, as the output would need to include the holders for all files that end up being part of the binary. And listing it in the --versions output is visually annoying and the wrong place. Just keep this where it belongs, at the file comment headers, above the license information.
2011-12-21dpkg-mergechangelogs: do not error out on invalid versionsRaphaël Hertzog1-1/+3
The usage of version_compare() has the side effect of erroring out as soon as you encounter an invalid version. Replacing this call with a comparison operator invoked on Dpkg::Version objects fixes the issue. Closes: #651993 Reported-by: Martin Packman <martin.packman@canonical.com>
2011-07-29dpkg-mergechangelogs: use 7 characters for conflict markersRaphaël Hertzog1-1/+1
Reported-by: Andrew Bennetts <andrew.bennetts@canonical.com>
2011-07-11dpkg-mergechangelogs: fail if it cannot close the output fileNiels Thykier1-1/+1
Made dpkg-mergechangelogs check the return value of close and fail if it was not successful. Previously dpkg-mergechangelogs would silently fail to write a file if (e.g.) the device was full. Signed-off-by: Raphaël Hertzog <hertzog@debian.org>
2010-11-19Cleanup white spacesGuillem Jover1-1/+0
Remove trailing spaces. Remove blank lines not separating different code blocks. Remove blank lines at the end of the file.
2010-04-22dpkg-mergechangelogs: add missing call to textdomain()Raphaël Hertzog1-0/+2
2010-04-22dpkg-mergechangelogs: avoid using UTF-8 on translatable stringsRaphaël Hertzog1-1/+1
2010-04-19dpkg-mergechangelogs: new script doing 3-way merge of Debian changelogsRaphaël Hertzog1-0/+289