Age | Commit message (Collapse) | Author | Files | Lines |
|
Closes: #934980
|
|
This was part of the volatile.debian.org archive, which was
decommissioned some time ago.
Ref: https://lists.debian.org/debian-volatile-announce/2012/msg00000.html
|
|
This got introduced after a request so that we could switch our tools
to a safe subset of the bundling logic, so let's enable it now that it
is available in the minimum supported perl version.
Bundling is in general unsafe, and not future-proof, as new options
might gain arguments which would then get misinterpreted, we should
not really be using it. But bundling the value into the option is a
common pattern and should be allowed.
|
|
We can just assign an anonymous sub to the typeglob.
|
|
|
|
When loading eval'ed modules we should remove «.» from @INC, or we
might end up loading code under the caller's control.
Fixes: CVE-2016-1238
|
|
Place 'use' strict and warnings first, then Exporter 'our' declarations,
then Test module imports, then system module imports, then Dpkg module
imports, then 'use' parent and overload pragmas, separated by a blank
line for each block.
Split each exported symbol declaration into its own line to ease
modifications.
|
|
The old function name was inconsistent with the other gettext family
of short aliases which has already caused some code typos, and functions
starting with underscore are considered by convention private in Perl.
|
|
Addresses Subroutines::RequireArgUnpacking.
Warned-by: perlcritic
|
|
|
|
Fixes InputOutput::RequireBracedFileHandleWithPrint.
Warned-by: perlcritic
|
|
This will make it safe to remove parenthesis around builtins.
|
|
Fixes CodeLayout::ProhibitHardTabs.
Warned-by: perlcritic
|
|
|
|
Just print a reference to use --help for further details. Which stops
annoying experienced users, or users that made a typo on the
command-line, by not overwhelming them with screenfuls of help output.
Closes: #681371
|
|
This gives a nicer error message, and makes sure we always exit on
option parse errors.
|
|
|
|
Rename, uppercase and do not export new variables by default, to avoid
cluttering the caller namespace, and to give them consistent names. We'll
keep the old variables for a while, to not break uses from external
modules.
Addresses Variables::ProhibitPackageVars.
|
|
Fixes Variables::ProhibitUnusedVariables.
Warned-by: perlcritic
|
|
Using double-quotes imposes a small performance penalty as the perl
parser needs to check if any interpolation is needed. Use double-quotes
only when the string contains single-quotes. Ideally we'd use
double-quotes too for escaped meta-characters that might otherwise be
confusing to immediately see if they need interpolation or not, but the
policy does not (currently) allow to ignore these.
Fixes ValuesAndExpressions::ProhibitInterpolationOfLiterals.
Warned-by: perlcritic
|
|
|
|
Fixes InputOutput::ProhibitBarewordFileHandles.
Warned-by: perlcritic
|
|
Print short options before long ones.
|
|
|
|
This switch frees the -h option to be used in the distant future for
other purposes, it also uses a character that does not have any other
obvious meaning for help output, and which is pretty safe to be used
blindly by the user in the same way as --help.
|
|
|
|
|
|
Having to keep this information twice is error-prone as it easily gets
out of sync. Having to translate it is bothersome. It's not consistent
across dpkg tools, some do print it some don't. It's currently not
accurate, as the output would need to include the holders for all files
that end up being part of the binary. And listing it in the --versions
output is visually annoying and the wrong place.
Just keep this where it belongs, at the file comment headers, above the
license information.
|
|
The usage of version_compare() has the side effect of erroring out as
soon as you encounter an invalid version. Replacing this call
with a comparison operator invoked on Dpkg::Version objects fixes
the issue.
Closes: #651993
Reported-by: Martin Packman <martin.packman@canonical.com>
|
|
Reported-by: Andrew Bennetts <andrew.bennetts@canonical.com>
|
|
Made dpkg-mergechangelogs check the return value of close and fail
if it was not successful. Previously dpkg-mergechangelogs would
silently fail to write a file if (e.g.) the device was full.
Signed-off-by: Raphaël Hertzog <hertzog@debian.org>
|
|
Remove trailing spaces. Remove blank lines not separating different code
blocks. Remove blank lines at the end of the file.
|
|
|
|
|
|
|