summaryrefslogtreecommitdiff
path: root/debugfs/htree.c
diff options
context:
space:
mode:
authorJim Meyering <jim@meyering.net>2009-02-23 18:07:50 +0100
committerTheodore Ts'o <tytso@mit.edu>2009-03-08 20:37:12 -0400
commit45e338f5332a54295893dba2e32cc093d1316f60 (patch)
treef20a569662c01e9330b33ea9fd8baa83c7601473 /debugfs/htree.c
parenta6d4aa147415acf875300176c5ca98ca72594bec (diff)
downloade2fsprogs-45e338f5332a54295893dba2e32cc093d1316f60.tar.gz
remove useless if-before-free tests
In case you're wondering about whether this change is safe from a portability standpoint, fear not. This has been beaten to death in other forums. Here are a few threads: http://thread.gmane.org/gmane.comp.version-control.git/74187 http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/12712 http://thread.gmane.org/gmane.emacs.devel/98144 http://thread.gmane.org/gmane.comp.lib.glibc.alpha/13092 There has been debate about whether it's a good idea from a performance standpoint, too, but imho you'll have a hard time finding an instance where this sort of change induces a measurable performance penalty. If you do, please let me know. Signed-off-by: Jim Meyering <meyering@redhat.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'debugfs/htree.c')
-rw-r--r--debugfs/htree.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/debugfs/htree.c b/debugfs/htree.c
index 4b8d7e9d..62dba4ad 100644
--- a/debugfs/htree.c
+++ b/debugfs/htree.c
@@ -275,8 +275,7 @@ void do_htree_dump(int argc, char *argv[])
rootnode->indirect_levels);
errout:
- if (buf)
- free(buf);
+ free(buf);
close_pager(pager);
}