diff options
| author | Lukas Czerner <lczerner@redhat.com> | 2011-09-13 22:24:11 -0400 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2011-09-13 22:42:19 -0400 |
| commit | faa2dcdad0f5af3945a70bdecc8713b3a74cdf9c (patch) | |
| tree | 77ce58f1c9bc81f2540ab7dd8f81e840a086118f /tests/m_uninit | |
| parent | 906a1cf9b60b336ccf44706c7f1906056282fbf0 (diff) | |
| download | e2fsprogs-faa2dcdad0f5af3945a70bdecc8713b3a74cdf9c.tar.gz | |
mke2fs: Use ext2fs_flush() only once
We are doing ext2fs_flush() twice right now at the end of the mke2fs.
First by directly calling ext2fs_flush() which is intended to write
superblock and fs accounting information. And then it is invoked again
when we are calling ext2fs_close(), only this time, because the fs is
not dirty, we are writing out only superblock.
I think it is bad to call it twice because even when writing only super
block it takes some time on bigger file systems and moreover
ext2fs_close() can fail without any reasonable explanation for the user.
Also ext2fs_flush() is printing out progress and it is confusing for the
users.
Fix all this by removing the ext2fs_flush() and leaving it all to
ext2fs_close(). However we need to introduce new variables to store
check interval and max mount count, because fs structure is freed on
ext2fs_close() and we really want to print those information as the last
info for the user.
[ Fixed type mismatch in a printf format statement -tytso]
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'tests/m_uninit')
| -rw-r--r-- | tests/m_uninit/expect.1 | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/m_uninit/expect.1 b/tests/m_uninit/expect.1 index 173c0729..a3c059db 100644 --- a/tests/m_uninit/expect.1 +++ b/tests/m_uninit/expect.1 @@ -17,7 +17,7 @@ Allocating group tables: 0/16 1/16 2/16 3/16 4/16 5/16 Writing inode tables: 0/16 1/16 2/16 3/16 4/16 5/16 6/16 7/16 8/16 9/1610/1611/1612/1613/1614/1615/16 done Writing superblocks and filesystem accounting information: 0/16 1/16 2/16 3/16 4/16 5/16 6/16 7/16 8/16 9/1610/1611/1612/1613/1614/1615/16 done - 0/16 1/16 2/16 3/16 4/16 5/16 6/16 7/16 8/16 9/1610/1611/1612/1613/1614/1615/16 Filesystem features: ext_attr resize_inode dir_index filetype sparse_super uninit_bg +Filesystem features: ext_attr resize_inode dir_index filetype sparse_super uninit_bg Pass 1: Checking inodes, blocks, and sizes Pass 2: Checking directory structure |