diff options
| author | Jim Meyering <jim@meyering.net> | 2009-02-23 18:07:50 +0100 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2009-03-08 20:37:12 -0400 |
| commit | 45e338f5332a54295893dba2e32cc093d1316f60 (patch) | |
| tree | f20a569662c01e9330b33ea9fd8baa83c7601473 /util | |
| parent | a6d4aa147415acf875300176c5ca98ca72594bec (diff) | |
| download | e2fsprogs-45e338f5332a54295893dba2e32cc093d1316f60.tar.gz | |
remove useless if-before-free tests
In case you're wondering about whether this change is safe from a
portability standpoint, fear not. This has been beaten to death
in other forums. Here are a few threads:
http://thread.gmane.org/gmane.comp.version-control.git/74187
http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/12712
http://thread.gmane.org/gmane.emacs.devel/98144
http://thread.gmane.org/gmane.comp.lib.glibc.alpha/13092
There has been debate about whether it's a good idea from a
performance standpoint, too, but imho you'll have a hard time
finding an instance where this sort of change induces a
measurable performance penalty. If you do, please let me know.
Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'util')
| -rw-r--r-- | util/subst.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/util/subst.c b/util/subst.c index 0015a9c4..b55f54bc 100644 --- a/util/subst.c +++ b/util/subst.c @@ -54,10 +54,8 @@ static int add_subst(char *name, char *value) return 0; fail: if (ent) { - if (ent->name) - free(ent->name); - if (ent->value) - free(ent->value); + free(ent->name); + free(ent->value); free(ent); } return retval; |