summaryrefslogtreecommitdiff
path: root/lib/ss
AgeCommit message (Collapse)AuthorFilesLines
2011-09-18Shorten compile commands run by the build systemTheodore Ts'o15-23/+43
The DEFS line in MCONFIG had gotten so long that it exceeded 4k, and this was starting to cause some tools heartburn. It also made "make V=1" almost useless, since trying to following the individual commands run by make was lost in the noise of all of the defines. So fix this by putting the configure-generated defines in lib/config.h and the directory pathnames to lib/dirpaths.h. In addition, clean up some vestigal defines in configure.in and in the Makefiles to further shorten the cc command lines. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2010-05-15libcom_err: Only output ^M when tty is in raw modeTheodore Ts'o1-2/+2
This fixes a long-standing botch in the com_err library, and solves a regression test problem for libss that gets tickled by source code management systems (like Perforce) that don't preserve CRLF line endings with fidelity. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2010-02-05libss: add newer libreadline to dlopen pathEric Sandeen1-1/+1
Rawhide now has libreadline.so.6 ... add it to the ever-expanding list of libs to look for. Unfortunately without commit 06ef971be505678ee462ae1844204ed24f14aedc this fails in a rather cryptic way. Signed-off-by: Eric Sandeen <sandeen@redhat.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2009-11-12libss: initialize function pointer for readline_shutdown()Theodore Ts'o1-0/+1
Clear the function pointer for readline_shutdown() so that if libss is linking against a readline library which doesn't supply a readline_shutdown() function, ss_delete_invocation() won't seg fault. Thanks to Solar Designer <solar@openwall.com> for reporting this problem to me. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2009-07-02Add support for configure --enable-verbose-makecmdsTheodore Ts'o1-38/+38
Some people don't want to see the concise "kernel-style" make output. This configure option allows build engines that want to see the full set of commands executed by the makefile to get what they want. Most people will find this more distracting than useful, unless they need to debug the Makefiles. (It is not necessary to rerun configure to enable this verbose make output temprarily; if a developer wants to do a quick debug of a directory's makefile, he or she can simply edit the definition of the $(E) and $(Q) variables in the Makefile; instructions can be found in the MCONFIG file which is included in at the beginning of every Makefile.) Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2009-07-01Fix Makefile dependencies for libcom_errTheodore Ts'o1-1/+1
The e2fsprogs makefiles were using the same Makefile variable LIBCOM_ERR for the link-line arguments as well as the dependencies. Since LIBCOM_ERR can now include non-file arguments such as "-lpthread", we need to use a separate DEPLIBCOM_ERR variable that only has build file dependencies. Do the same thing for STATIC_LIBCOM_ERR and PROFILED_LIBCOM_ERR. Addresses-Sourceforge-Patches: #2813809 Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2009-04-22libss: Fix warn_unused_result warnings from gccTheodore Ts'o1-1/+20
Fixed a potential bug where by partial returns from the write system call could the fallback pager to drop characters. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2009-04-22libss: ss_execute_line: reflect any error codes from system() to the callerTheodore Ts'o1-2/+6
This is primarily to silence a gcc warning, but it's better to reflect the error from system() up to the caller. In this case we don't actually use it for anything, but that's OK. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2009-03-08libss: Avoid leak upon failed realloc in ss_add_request_table()Jim Meyering1-3/+4
Signed-off-by: Jim Meyering <meyering@redhat.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2009-03-08remove useless if-before-free testsJim Meyering1-2/+1
In case you're wondering about whether this change is safe from a portability standpoint, fear not. This has been beaten to death in other forums. Here are a few threads: http://thread.gmane.org/gmane.comp.version-control.git/74187 http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/12712 http://thread.gmane.org/gmane.emacs.devel/98144 http://thread.gmane.org/gmane.comp.lib.glibc.alpha/13092 There has been debate about whether it's a good idea from a performance standpoint, too, but imho you'll have a hard time finding an instance where this sort of change induces a measurable performance penalty. If you do, please let me know. Signed-off-by: Jim Meyering <meyering@redhat.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2009-01-20Use format strings directly to prevent -Werror=format-security failuresTheodore Ts'o1-2/+2
Gcc is too stupid to realize that: const char *usage="String which has no percent signs"; com_err(progname, 0, usage); is OK. I refuse to bow to stupidity with: com_err(progname, 0, "%s", usage); but I will use the string directly for the sake of people who like to build with -Werror=format-security. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-09-02Fix pkg-config files: use Requires.private and fix the include directoryTheodore Ts'o1-2/+2
Addresses-Sourceforge-Bug: #2089537 Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-27Remove trailing whitespace for the entire source treeTheodore Ts'o6-24/+24
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-07-14Don't assume that /bin/true is always in /binTheodore Ts'o1-1/+1
... because it isn't on MacOS X Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-07-13Flush stdio buffers before calling setbuf()Theodore Ts'o1-0/+2
On Solaris setbuf() will discard any pending output to the stream, so make we call fflush() before calling setbuf(). Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-07-13Fix Solaris shell script portability issuesTheodore Ts'o1-3/+3
Solaris ships with a pathetically ancient shell in /bin/sh, so fix various shell scripts to accomodate. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-06-07Fix LIBSS dependency problem for tests/test_icount and lib/ss/test_ssTheodore Ts'o1-1/+1
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-04-17Merge branch 'maint'Theodore Ts'o1-1/+1
2008-04-09Fix non-POSIX ">&" in the Makefile for lib/ss's "make check" ruleTheodore Ts'o1-1/+1
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-01-01Merge branch 'maint' into nextTheodore Ts'o1-1/+1
Conflicts: configure debian/rules e2fsck/swapfs.c lib/ext2fs/ext2_fs.h
2008-01-01libss: Remove unnecessary Makefile dependency for test_ssTheodore Ts'o1-1/+1
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2007-12-17Merge branch 'maint' into nextTheodore Ts'o1-1/+1
Conflicts: lib/ext2fs/closefs.c
2007-12-15libss: Fix "make check" test case to work portablyTheodore Ts'o1-1/+1
The "make check" test in lib/ss would fail if '.' is not in the user's PATH, and if the libss shared library had not yet been installed yet. Addresses-Sourceforge-Bug: #1848974 Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2007-12-09Merge branch 'maint' into nextTheodore Ts'o5-103/+170
Conflicts: lib/ext2fs/closefs.c
2007-12-02libss: Fix parallel build failureTheodore Ts'o1-0/+2
A missing dependency on ss_err.h meant that std_rqs.o could fail when e2fsprogs was being built using make -j. Thanks to Robert Kerr for reporting this bug. Addresses-Sourceforge-Bug: #1842331 Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2007-12-02Fix errors in test_ss.c so it can be an example application and test caseTheodore Ts'o5-103/+168
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2007-11-01blkid.pc, ss.pc: Move private libs from "Libs:" to "Libs.private:"Dmitry V. Levin1-1/+2
According to pkg-config(1) manual page, private libraries should be defined by "Libs.private:" line. Private libraries are libraries which are not exposed through our library, but are needed in the case of static linking. Signed-off-by: Dmitry V. Levin <ldv@altlinux.org> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2007-07-08Remove Changelog files since they're not used after the git migrationTheodore Ts'o1-490/+0
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2007-06-30Make it clear in an error message that it is mk_cmds that is complainingTheodore Ts'o1-1/+1
Obviates gentoo patch: e2fsprogs-1.32-mk_cmds-cosmetic.patch Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2007-06-24Update Release Notes, Changelogs, version.h, etc. for 1.40 releaseTheodore Ts'o1-0/+4
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2007-03-21[COVERITY] Fix memory leak in libss (ss_execute_line)Brian Behlendorf2-1/+11
Fix a memory leak by freeing the argv[] array if ss_parse_line returns 0 for argc 0 (which will happen if the user his return and sends an empty line to the application). Potentially need to free argv before early return since it was allocated memory. Need to be careful since it may be possible for ss_parse() to have freed the memory allocated to it if it detects an unbalanced set of quotes passed to it. Coverity ID: 21: Resource Leak Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
2007-03-19[COVERITY] Fix bad error checking for NULL parameter in ss libraryBrian Behlendorf2-1/+6
Looks like flawed reasoning. Here if info_dir is NULL then you are guaranteed to blow up since you will dereference it. It seems like the correct thing to do here (what the code author meant to do) was to set *code_ptr = SS_ET_NO_INFO_DIR if info_dir was NULL or if *info_dir was an empty string (aka *info_dir == '\0'). Coverity ID: 8: Forward Null Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
2006-11-17Add libreadline.so.5 to the list of readline libraries used by libssTheodore Ts'o2-1/+6
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2006-11-12Set local environment variables to C so mk_cmds and compile_et always workTheodore Ts'o2-0/+18
Addresses SourceForge Bug: #1532177 Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2006-10-22Add datarootdir definition for compatibility with autoconf 2.60Theodore Ts'o2-0/+6
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2006-08-05Create the generated files read-only to remind developers not to edit them.Andreas Dilger2-1/+7
Signed-off-by: Andreas Dilger <adilger@clusterfs.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2005-12-10Address parallel build problem in the library MakefilesTheodore Ts'o2-0/+8
Add a dependency to make sure that the subdirectories are created before creating all of the object files. Addresses Sourceforge Bug: #1261553 Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2005-07-25Fix false positives from valgrind: prctl(PR_GET_DUMPABLE)Theodore Ts'o2-2/+8
Pass in zero to the unusued arguments of prctl(PR_GET_DUMPABLE) to avoid false positives from valgrind. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2005-06-30Update for e2fsprogs 1.38 release.Theodore Ts'o1-0/+4
2005-05-08Fix bug in the secure getenv function so that the ss library will correntlyTheodore Ts'o2-2/+7
honor the PAGER and SS_READLINE_PATH environtment variables, and the test_io io_manager in the ext2fs library honors the TEST_IO_LOGFILE, TEST_IO_FLAGS, TEST_IO_BLOCK, and TEST_IO_READ_ABORT environment variables.
2005-04-16Fix typo so that we actually ignore environment variables when gid != egid.Theodore Ts'o1-1/+1
2005-04-06Add paranoia checks into the blkid, ext2fs, and ss libraries to ignoreTheodore Ts'o4-2/+39
environment variables if the libraries are called from setuid or setguid programs, or if kernel believes that the process is not eligible to create a core dump. In addition, if the libc has __secure_getenv(), use it so that the libc can also do any additional limitations regarding when libraries can trust environment variables (i.e., to integrate with systems like SELinux and Posix capabilities).
2005-03-21Update for the e2fsprogs 1.37 release.Theodore Ts'o1-0/+4
2005-02-05Update for release of e2fsprogs 1.36.Theodore Ts'o1-0/+4
2005-02-05Remove *.pc files on a "make distclean"Theodore Ts'o2-2/+7
Remove emacs backup files in tests/Makefile on a "make clean"
2005-01-26Add pkg-config files to e2fsprogs's libraries.Theodore Ts'o3-5/+28
2005-01-19Makefile.in: Fix the kernel compile-time echo commands to beTheodore Ts'o2-1/+6
consistent and portable
2004-12-15Add install-strip and install-shlibs-strip targetsTheodore Ts'o2-11/+20
Use Linux-kernel-style makefile output for "make install" Update intl/Makefile.in to version from gettext 0.14.1
2004-12-14Use MKINSTALLDIRS macro so that the Makefiles can find the scriptTheodore Ts'o2-2/+8
correctly. Update Makefile dependencies. Update "make depend" production so that it filters out comments inserted by newer gcc compilers. Remove sync from e2fsck's "make all" target.
2004-11-30Use Linux-kernel-style makefile output to make it easier to Theodore Ts'o2-9/+18
see errors/warnings.
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-21 17:59:24 +0000