Age | Commit message (Collapse) | Author | Files | Lines |
|
Pull in the m4 macros from the xfce4-dev-tools so
we have ways to simplify and shorten the configure.ac
file.
|
|
For: https://github.com/ConsoleKit2/ConsoleKit2/issues/74
|
|
|
|
|
|
This way console logins also get the env variable
|
|
XDG_VTNR is another way to obtain the X11 display device. As SDDM sets
this environment variable, it is now much simpler to use it with pam_ck_connector.
Signed-off-by: Eric Koegel <eric.koegel@gmail.com>
|
|
And document the --enable-debug option better. The enable-tests
option defaults to off so that normal release builds don't have
to waste time compiling tests that won't be installed or used.
|
|
Some Linux distros use OpenPAM.
|
|
1) sysconf returns a long so make bufsize one.
2) sysconf call can fail and return -1, handle that condition.
3) if sysconf does fail a negative value would be sent to calloc
which expects a positive value.
|
|
Otherwise GCC nags us with warnings.
|
|
|
|
Fix the unconditional PATH_MAX usage in pam-ck-connector/pam-ck-connector.c by
using a variable-length malloc'ed buffer.
Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=552393
https://bugs.freedesktop.org/show_bug.cgi?id=24738
|
|
Solaris now builds with flags to give getpwnam_r
more standard semantics.
bug 22361
|
|
This patch is a little different with Brian's. Let's me explain the whole patch
one by one.
1. pam-ck-connector/Makefile.am (same with Brian's)
Solaris does not have libpam_misc, so only build test_pam under linux
2. +#include <limits.h>
This is to get macro PATH_MAX from system. I think it is better than
+#ifndef PATH_MAX
+#define PATH_MAX 4096
+#endif
On ubuntu, PATH_MAX=4096, on Solaris, PATH_MAX=1024
3. +#include <security/pam_appl.h>
This is to include declaration of pam_handle_t, to resolve error like:
"/usr/include/security/pam_modules.h", line 38: syntax error before or at: *
"/usr/include/security/pam_modules.h", line 45: syntax error before or at: *
4.-#include <security/_pam_macros.h>
Solaris does not have this file, I remove it, no more error, seems no use
here.
5. +#ifndef PAM_EXTERN ... part
Solaris PAM_EXTERN marco in pam_modules.h, while Ubuntu has, I just copy the
logic from Ubuntu.
6. getpwnam_r part (same with Brian's)
getpwnam_r() have difference behavior between Solaris and Ubuntu.
https://bugs.freedesktop.org/show_bug.cgi?id=18173
|
|
Ignores PAM sessions where PAM_TTY is an X11 display. This allows adding
pam_ck_connector to PAM's "common-session" without interfering
with the already existing ConsoleKit operations in gdm, the
Xsession script, etc.
https://bugs.freedesktop.org/show_bug.cgi?id=16746
|
|
PAM module
|
|
|
|
|
|
|
|
In order to set the x11-display-device parameter on the new
session.
|
|
|
|
|
|
The attached patch does the following:
- Use a separate $pam-module-dir variable for the pam module
- Instead of defining a custom $slibdir variable, just use the
standard $libdir variable specified by autoconf
- Use the standard autoconf $docdir variable (Add AC_PREREQ(2.59) for that).
- Drop AS_AC_EXPAND macro and remove AC_DEFINE_UNQUOTED for dir variables.
+ Build the init script at make time using sed
+ Use defines in src/Makefile.am to pass the variables to gcc at make time
- Consistently use AC_HELP_STRING everywhere
- Remove/Replace deprecated macros:
+ AM_INIT_AUTOMAKE takes the package name and version number from AC_INIT
+ AM_CONFIG_HEADER -> AC_CONFIG_HEADERS
+ AC_OUTPUT -> AC_CONFIG_FILES
Patch is tested and make distcheck works.
|
|
Basically the path for the pam module is hardcoded to /lib/security
which isn't right. Attached is a patch that uses the value of slibdir
for /lib/.
|
|
Also make the configure checks simpler.
|
|
Only include what is available. Use a alternative to pam_syslog
if it isn't available.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Basically this is a mini login. It authenticates, opens a session,
sleeps 20 seconds, and then closes the session.
|
|
|
|
I modified the API of the new connector a bit.
* include errors
* make names a bit more consistent with what they do
* have symmetry between open and close
* use refcounting
* do parameter checking on inputs
I also made some changes to whitespace and style. And converted
descriptions to gtkdoc style comments.
|
|
Here are some patches to add one library and one PAM module so other
programs (apart from gdm) can easily interact with ConsoleKit. It's
mainly going to be used, I think, by login(1) and xinit(1). I'm not
super happy about doing a PAM module but the Fedora util-linux package
maintainer seems to be insist on this instead of just patching login(1).
The PAM module isn't built by default. Both pieces of code are licensed
under the MIT license as god knows what might want to use them. Sounds
good to you?
|