diff options
| author | Toomas Soome <tsoome@me.com> | 2021-12-27 13:55:56 +0200 |
|---|---|---|
| committer | Toomas Soome <tsoome@me.com> | 2022-01-10 10:42:53 +0200 |
| commit | 5608cf052f6eabe370f15f49b6fa5d0d8be732af (patch) | |
| tree | d2a67e06a9bb0a8f4031b653ab6072759d63499c | |
| parent | 966c588f828c4693b5a80ec27b24ff16afa11ec9 (diff) | |
| download | illumos-gate-5608cf052f6eabe370f15f49b6fa5d0d8be732af.tar.gz | |
14335 nscd: this 'if' clause does not guard...
Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
Reviewed by: C Fraire <cfraire@me.com>
Approved by: Dan McDonald <danmcd@joyent.com>
| -rw-r--r-- | usr/src/cmd/nscd/nscd_config.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/usr/src/cmd/nscd/nscd_config.c b/usr/src/cmd/nscd/nscd_config.c index ae1066dde8..cba6c6b3aa 100644 --- a/usr/src/cmd/nscd/nscd_config.c +++ b/usr/src/cmd/nscd/nscd_config.c @@ -2351,14 +2351,13 @@ _nscd_cfg_str_to_data( else if (strcasecmp(str, "no") == 0) *(nscd_bool_t *)data = nscd_false; else { + (void) snprintf(msg, sizeof (msg), + gettext("data (%s) must be 'yes' or 'no' for %s"), + str, desc->id.name); - (void) snprintf(msg, sizeof (msg), - gettext("data (%s) must be 'yes' or 'no' for %s"), - str, desc->id.name); - - if (errorp != NULL) - *errorp = _nscd_cfg_make_error(NSCD_INVALID_ARGUMENT, - msg); + if (errorp != NULL) + *errorp = _nscd_cfg_make_error( + NSCD_INVALID_ARGUMENT, msg); _NSCD_LOG(NSCD_LOG_CONFIG, NSCD_LOG_LEVEL_ERROR) (me, "ERROR: %s\n", msg); |