diff options
| author | John Levon <john.levon@joyent.com> | 2018-12-19 18:27:22 +0000 |
|---|---|---|
| committer | Robert Mustacchi <rm@joyent.com> | 2019-01-23 21:59:20 +0000 |
| commit | 588340b578485109e57c57bc12e5ea214d5c627b (patch) | |
| tree | b0c9e3af668acf639fe57aa0157ad5aa693e702c | |
| parent | 2ce06f328fa620f2eb375c4f57cd330c86275c4b (diff) | |
| download | illumos-gate-588340b578485109e57c57bc12e5ea214d5c627b.tar.gz | |
10127 coreadm is mis-using strcpy()
Reviewed by: Sanjay Nadkarni <sanjay.nadkarni@nexenta.com>
Reviewed by: Alexander Pyhalov <apyhalov@gmail.com>
Reviewed by: Gergő Doma <domag02@gmail.com>
Approved by: Robert Mustacchi <rm@joyent.com>
| -rw-r--r-- | usr/src/cmd/coreadm/coreadm.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/usr/src/cmd/coreadm/coreadm.c b/usr/src/cmd/coreadm/coreadm.c index 9ce0f27651..ca7edc179e 100644 --- a/usr/src/cmd/coreadm/coreadm.c +++ b/usr/src/cmd/coreadm/coreadm.c @@ -21,6 +21,7 @@ /* * Copyright 2008 Sun Microsystems, Inc. All rights reserved. * Use is subject to license terms. + * Copyright (c) 2018, Joyent, Inc. */ #include <stdio.h> @@ -547,7 +548,8 @@ read_legacy(void) if (n == 1) value[0] = '\0'; if (strcmp(name, "COREADM_GLOB_PATTERN") == 0) { - (void) strcpy(gpattern, value); + (void) strlcpy(gpattern, value, + sizeof (gpattern)); continue; } if (strcmp(name, "COREADM_GLOB_CONTENT") == 0) { @@ -555,7 +557,8 @@ read_legacy(void) continue; } if (strcmp(name, "COREADM_INIT_PATTERN") == 0) { - (void) strcpy(ipattern, value); + (void) strlcpy(ipattern, value, + sizeof (ipattern)); continue; } if (strcmp(name, "COREADM_INIT_CONTENT") == 0) { |