summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorToomas Soome <tsoome@me.com>2020-03-05 00:31:55 +0200
committerToomas Soome <tsoome@me.com>2020-04-29 19:15:05 +0300
commitde172e901a45d2c11bb3be066bc4af11c104d52e (patch)
tree217ad3e509298d461f569ed881cb4860bf053342
parente4a991eb9ba3d449515f2fe5f9f2a9e1c33ca0fd (diff)
downloadillumos-gate-de172e901a45d2c11bb3be066bc4af11c104d52e.tar.gz
12362 audio: buffer overflow
Reviewed by: Gergő Doma <domag02@gmail.com> Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: Garrett D'Amore <garrett@damore.org> Approved by: Garrett D'Amore <garrett@damore.org>
-rw-r--r--usr/src/uts/common/io/audio/impl/audio_grc3.h2
-rw-r--r--usr/src/uts/intel/audio/Makefile11
-rw-r--r--usr/src/uts/sparc/audio/Makefile8
3 files changed, 1 insertions, 20 deletions
diff --git a/usr/src/uts/common/io/audio/impl/audio_grc3.h b/usr/src/uts/common/io/audio/impl/audio_grc3.h
index 0003dc1574..4472307edf 100644
--- a/usr/src/uts/common/io/audio/impl/audio_grc3.h
+++ b/usr/src/uts/common/io/audio/impl/audio_grc3.h
@@ -53,7 +53,7 @@ typedef struct grc3state {
int32_t *historyptr;
int32_t dummy_pad1;
- int32_t history[GRC3_MAXHISTORY * 2];
+ int32_t history[GRC3_MAXHISTORY * 2 + 1];
uint32_t outsz;
} grc3state_t;
diff --git a/usr/src/uts/intel/audio/Makefile b/usr/src/uts/intel/audio/Makefile
index 3a7a1d6c21..04b193ee64 100644
--- a/usr/src/uts/intel/audio/Makefile
+++ b/usr/src/uts/intel/audio/Makefile
@@ -36,7 +36,6 @@ UTSBASE = ../..
#
MODULE = audio
OBJECTS = $(AUDIO_OBJS:%=$(OBJS_DIR)/%)
-LINTS = $(AUDIO_OBJS:%.o=$(LINTS_DIR)/%.ln)
ROOTMODULE = $(ROOT_DRV_DIR)/$(MODULE)
CONF_SRCDIR = $(UTSBASE)/common/io/audio/impl
@@ -47,14 +46,10 @@ include $(UTSBASE)/intel/Makefile.intel
CERRWARN += $(CNOWARN_UNINIT)
-# needs work
-$(OBJS_DIR)/audio_grc3.o := SMOFF += index_overflow
-
#
# Define targets
#
ALL_TARGET = $(BINARY) $(SRC_CONFFILE)
-LINT_TARGET = $(MODULE).lint
INSTALL_TARGET = $(BINARY) $(ROOTMODULE) $(ROOT_CONFFILE)
#
@@ -70,12 +65,6 @@ clean: $(CLEAN_DEPS)
clobber: $(CLOBBER_DEPS)
-lint: $(LINT_DEPS)
-
-modlintlib: $(MODLINTLIB_DEPS)
-
-clean.lint: $(CLEAN_LINT_DEPS)
-
install: $(INSTALL_DEPS)
#
diff --git a/usr/src/uts/sparc/audio/Makefile b/usr/src/uts/sparc/audio/Makefile
index a77b4bd8c1..8721dc9800 100644
--- a/usr/src/uts/sparc/audio/Makefile
+++ b/usr/src/uts/sparc/audio/Makefile
@@ -37,7 +37,6 @@ UTSBASE = ../..
#
MODULE = audio
OBJECTS = $(AUDIO_OBJS:%=$(OBJS_DIR)/%)
-LINTS = $(AUDIO_OBJS:%.o=$(LINTS_DIR)/%.ln)
ROOTMODULE = $(ROOT_DRV_DIR)/$(MODULE)
CONF_SRCDIR = $(UTSBASE)/common/io/audio/impl
@@ -52,7 +51,6 @@ CERRWARN += $(CNOWARN_UNINIT)
# Define targets
#
ALL_TARGET = $(BINARY) $(SRC_CONFFILE)
-LINT_TARGET = $(MODULE).lint
INSTALL_TARGET = $(BINARY) $(ROOTMODULE) $(ROOT_CONFFILE)
#
@@ -68,12 +66,6 @@ clean: $(CLEAN_DEPS)
clobber: $(CLOBBER_DEPS)
-lint: $(LINT_DEPS)
-
-modlintlib: $(MODLINTLIB_DEPS)
-
-clean.lint: $(CLEAN_LINT_DEPS)
-
install: $(INSTALL_DEPS)
#