diff options
| author | Toomas Soome <tsoome@me.com> | 2018-11-27 12:10:45 +0200 |
|---|---|---|
| committer | Toomas Soome <tsoome@me.com> | 2020-07-19 19:24:23 +0300 |
| commit | 790596015610f2e87846342a497f6ee558379163 (patch) | |
| tree | ef73284d927f333e80178c46af63474817d969d8 /usr/src/lib | |
| parent | 93f1cac532b220b8db1e7715dbb2ae7ec5fe8fe7 (diff) | |
| download | illumos-gate-790596015610f2e87846342a497f6ee558379163.tar.gz | |
12105 libsmbns: passing argument 1 to restrict-qualified parameter aliases with argument 4
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: C Fraire <cfraire@me.com>
Reviewed by: Matthias Scheler <mscheler@tintri.com>
Approved by: Robert Mustacchi <rm@fingolfin.org>
Diffstat (limited to 'usr/src/lib')
| -rw-r--r-- | usr/src/lib/smbsrv/libsmbns/common/smbns_ads.c | 4 | ||||
| -rw-r--r-- | usr/src/lib/smbsrv/libsmbns/common/smbns_dyndns.c | 18 |
2 files changed, 12 insertions, 10 deletions
diff --git a/usr/src/lib/smbsrv/libsmbns/common/smbns_ads.c b/usr/src/lib/smbsrv/libsmbns/common/smbns_ads.c index ba0d70aaae..5f797a38aa 100644 --- a/usr/src/lib/smbsrv/libsmbns/common/smbns_ads.c +++ b/usr/src/lib/smbsrv/libsmbns/common/smbns_ads.c @@ -1286,8 +1286,8 @@ smb_ads_getfqhostname(smb_ads_handle_t *ah, char *fqhost, int len) if (smb_gethostname(fqhost, len, SMB_CASE_LOWER) != 0) return (-1); - (void) snprintf(fqhost, len, "%s.%s", fqhost, - ah->domain); + (void) strlcat(fqhost, ".", len); + (void) strlcat(fqhost, ah->domain, len); return (0); } diff --git a/usr/src/lib/smbsrv/libsmbns/common/smbns_dyndns.c b/usr/src/lib/smbsrv/libsmbns/common/smbns_dyndns.c index 2959840a05..ad813ca7f6 100644 --- a/usr/src/lib/smbsrv/libsmbns/common/smbns_dyndns.c +++ b/usr/src/lib/smbsrv/libsmbns/common/smbns_dyndns.c @@ -2026,14 +2026,15 @@ dyndns_update_core(char *fqdn) if (!smb_config_getbool(SMB_CI_DYNDNS_ENABLE)) return (0); - if (smb_gethostname(fqhn, MAXHOSTNAMELEN, SMB_CASE_LOWER) != 0) - return (-1); - /* * To comply with RFC 4120 section 6.2.1, the fully-qualified hostname * must be set to lower case. */ - (void) snprintf(fqhn, MAXHOSTNAMELEN, "%s.%s", fqhn, fqdn); + if (smb_gethostname(fqhn, MAXHOSTNAMELEN, SMB_CASE_LOWER) != 0) + return (-1); + + (void) strlcat(fqhn, ".", MAXHOSTNAMELEN); + (void) strlcat(fqhn, fqdn, MAXHOSTNAMELEN); error = 0; forw_update_ok = 0; @@ -2107,14 +2108,15 @@ dyndns_clear_rev_zone(char *fqdn) if (!smb_config_getbool(SMB_CI_DYNDNS_ENABLE)) return (0); - if (smb_gethostname(fqhn, MAXHOSTNAMELEN, SMB_CASE_LOWER) != 0) - return (-1); - /* * To comply with RFC 4120 section 6.2.1, the fully-qualified hostname * must be set to lower case. */ - (void) snprintf(fqhn, MAXHOSTNAMELEN, "%s.%s", fqhn, fqdn); + if (smb_gethostname(fqhn, MAXHOSTNAMELEN, SMB_CASE_LOWER) != 0) + return (-1); + + (void) strlcat(fqhn, ".", MAXHOSTNAMELEN); + (void) strlcat(fqhn, fqdn, MAXHOSTNAMELEN); error = 0; |