summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason King <jason.king@joyent.com>2018-05-08 21:44:21 -0500
committerJason King <jason.king@joyent.com>2018-05-08 21:44:21 -0500
commit5bd5ccf4151a158688d20f70ade29a55ada85d45 (patch)
tree953a4e6609bbd6c78f3878cf785fc17adb81e8e2
parent28cd1d4864940265e40eecac8df838b0dd72ca5c (diff)
downloadillumos-joyent-OS-6924.tar.gz
OS-6924 Double-free in crypto tests on failureOS-6924
-rw-r--r--usr/src/test/crypto-tests/tests/common/cryptotest_kcf.c3
-rw-r--r--usr/src/test/crypto-tests/tests/common/cryptotest_pkcs.c2
2 files changed, 1 insertions, 4 deletions
diff --git a/usr/src/test/crypto-tests/tests/common/cryptotest_kcf.c b/usr/src/test/crypto-tests/tests/common/cryptotest_kcf.c
index 260821dcac..f19aa0b7c2 100644
--- a/usr/src/test/crypto-tests/tests/common/cryptotest_kcf.c
+++ b/usr/src/test/crypto-tests/tests/common/cryptotest_kcf.c
@@ -11,6 +11,7 @@
/*
* Copyright 2015 Nexenta Systems, Inc. All rights reserved.
+ * Copyright 2018, Joyent, Inc.
*/
#include <fcntl.h>
@@ -134,7 +135,6 @@ get_mech_info(crypto_op_t *op)
(uint_t *)&get_number, "get_mech_info") != CRYPTO_SUCCESS) {
(void) fprintf(stderr, "failed to resolve mechanism name %s\n",
op->mechname);
- (void) cryptotest_close(op);
return (CTEST_NAME_RESOLVE_FAILED);
}
op->mech = get_number.pn_internal_number;
@@ -158,7 +158,6 @@ get_hsession_by_mech(crypto_op_t *op)
(void) fprintf(stderr,
"could not find provider for mechanism %llu\n",
mech.mech_type);
- (void) cryptotest_close(op);
return (CTEST_MECH_NO_PROVIDER);
}
diff --git a/usr/src/test/crypto-tests/tests/common/cryptotest_pkcs.c b/usr/src/test/crypto-tests/tests/common/cryptotest_pkcs.c
index db15968b49..0506110e3c 100644
--- a/usr/src/test/crypto-tests/tests/common/cryptotest_pkcs.c
+++ b/usr/src/test/crypto-tests/tests/common/cryptotest_pkcs.c
@@ -104,7 +104,6 @@ get_mech_info(crypto_op_t *op)
cryptotest_error("get_mech_info", rv);
(void) fprintf(stderr, "failed to resolve mechanism name %s\n",
op->mechname);
- (void) cryptotest_close(op);
return (CTEST_NAME_RESOLVE_FAILED);
}
return (rv);
@@ -121,7 +120,6 @@ get_hsession_by_mech(crypto_op_t *op)
(void) fprintf(stderr,
"could not find provider for mechanism %lu\n",
op->mech);
- (void) cryptotest_close(op);
return (CTEST_MECH_NO_PROVIDER);
}
return (rv);