diff options
| author | Cody Peter Mello <cody.mello@joyent.com> | 2016-04-19 21:51:24 +0000 |
|---|---|---|
| committer | Cody Peter Mello <cody.mello@joyent.com> | 2016-05-11 23:17:35 +0000 |
| commit | d06693d3651f2464cd88044e2ffc938688be346a (patch) | |
| tree | 2339bb3b8cf9596e5f9d4bd4ced9abbb85949ea5 | |
| parent | 2d42a19d23357922f9595426bc53645b6569dad5 (diff) | |
| download | illumos-joyent-release-20160512.tar.gz | |
OS-5348 mdb -e doesn't properly report exit status for failed writesrelease-20160512
Reviewed by: Joshua M. Clulow <jmc@joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
| -rw-r--r-- | usr/src/cmd/mdb/common/mdb/mdb_cmds.c | 5 | ||||
| -rw-r--r-- | usr/src/cmd/mdb/test/exit-e/err.nowrite.ksh | 1 | ||||
| -rw-r--r-- | usr/src/cmd/mdb/test/exit-e/err.unmapped.ksh | 1 |
3 files changed, 4 insertions, 3 deletions
diff --git a/usr/src/cmd/mdb/common/mdb/mdb_cmds.c b/usr/src/cmd/mdb/common/mdb/mdb_cmds.c index 95b216cfbe..add162a839 100644 --- a/usr/src/cmd/mdb/common/mdb/mdb_cmds.c +++ b/usr/src/cmd/mdb/common/mdb/mdb_cmds.c @@ -252,7 +252,7 @@ write_arglist(mdb_tgt_as_t as, mdb_tgt_addr_t addr, mdb_warn("failed to write %llr at address 0x%llx", value, addr); mdb.m_incr = 0; - break; + return (DCMD_ERR); } mdb.m_incr = naddr - addr; @@ -520,8 +520,7 @@ cmd_print_phys(uintptr_t x, uint_t flags, int argc, const mdb_arg_t *argv) /*ARGSUSED*/ static int -cmd_print_value(uintptr_t addr, uint_t flags, - int argc, const mdb_arg_t *argv) +cmd_print_value(uintptr_t addr, uint_t flags, int argc, const mdb_arg_t *argv) { uintmax_t ndot, dot = mdb_get_dot(); const char *tgt_argv[1]; diff --git a/usr/src/cmd/mdb/test/exit-e/err.nowrite.ksh b/usr/src/cmd/mdb/test/exit-e/err.nowrite.ksh new file mode 100644 index 0000000000..8f0fda2253 --- /dev/null +++ b/usr/src/cmd/mdb/test/exit-e/err.nowrite.ksh @@ -0,0 +1 @@ +$MDB -e '0xbaddcafe/v 0x02' diff --git a/usr/src/cmd/mdb/test/exit-e/err.unmapped.ksh b/usr/src/cmd/mdb/test/exit-e/err.unmapped.ksh new file mode 100644 index 0000000000..874283f186 --- /dev/null +++ b/usr/src/cmd/mdb/test/exit-e/err.unmapped.ksh @@ -0,0 +1 @@ +$MDB -e '0x0/v 0x02' /bin/ls |