6885 CTF Everywhere Part 1

6886 Want ctfdiff
6887 ctfdump should be written in terms of libctf
6888 ctfmerge should be implemented in terms of libctf
6889 ctfconvert should be implemented in terms of libctf
6890 Want general workq
6891 Want general mergeq
6892 ctf_add_encoded assigns() incorrect byte size to types
6893 ctf_add_{struct,union,enum} can reuse forwards
6894 ctf_add_{struct,union,enum} occasionally forget to dirty the ctf_file_t
6895 ctf_add_member could better handle bitfields
6896 ctf_type_size() reports wrong size for forwards
6897 Want libctf ctf_kind_name() function
6898 Want libctf function to set struct/union size
Portions contributed by: John Levon <john.levon@joyent.com>
Portions contributed by: Richard Lowe <richlowe@richlowe.net>
Reviewed by: John Levon <john.levon@joyent.com>
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Reviewed by: Gergő Doma <domag02@gmail.com>
Approved by: Dan McDonald <danmcd@joyent.com>

6 files changed, 545 insertions, 1 deletions

diff --git a/usr/src/test/util-tests/runfiles/default.run b/usr/src/test/util-tests/runfiles/default.run
index 046888427f..f22bdd5094 100644
--- a/usr/src/test/util-tests/runfiles/default.run
+++ b/usr/src/test/util-tests/runfiles/default.run
@@ -31,6 +31,9 @@ outputdir = /var/tmp/test_results
 
 [/opt/util-tests/tests/xargs_test]
 
+[/opt/util-tests/tests/mergeq/mqt]
+[/opt/util-tests/tests/mergeq/wqt]
+
 [/opt/util-tests/tests/libnvpair_json]
 tests = ['json_00_blank', 'json_01_boolean', 'json_02_numbers',
     'json_03_empty_arrays', 'json_04_number_arrays', 'json_05_strings',
diff --git a/usr/src/test/util-tests/tests/Makefile b/usr/src/test/util-tests/tests/Makefile
index a32af36d11..35751b8e30 100644
--- a/usr/src/test/util-tests/tests/Makefile
+++ b/usr/src/test/util-tests/tests/Makefile
@@ -17,6 +17,6 @@
 #
 
 SUBDIRS = date dis dladm iconv libnvpair_json libsff printf xargs grep_xpg4
-SUBDIRS += demangle
+SUBDIRS += demangle mergeq workq
 
 include $(SRC)/test/Makefile.com
diff --git a/usr/src/test/util-tests/tests/mergeq/Makefile b/usr/src/test/util-tests/tests/mergeq/Makefile
new file mode 100644
index 0000000000..ef6c6abb99
--- /dev/null
+++ b/usr/src/test/util-tests/tests/mergeq/Makefile
@@ -0,0 +1,64 @@
+#
+# This file and its contents are supplied under the terms of the
+# Common Development and Distribution License ("CDDL"), version 1.0.
+# You may only use this file in accordance with the terms of version
+# 1.0 of the CDDL.
+#
+# A full copy of the text of the CDDL should have accompanied this
+# source.  A copy of the CDDL is also available via the Internet at
+# http://www.illumos.org/license/CDDL.
+#
+
+#
+# Copyright 2015 Joyent, Inc.
+#
+
+include $(SRC)/Makefile.master
+
+ROOTOPTPKG = $(ROOT)/opt/util-tests
+TESTDIR = $(ROOTOPTPKG)/tests/mergeq
+
+PROG = mqt
+OBJS = mqt.o mergeq.o
+
+include $(SRC)/cmd/Makefile.cmd
+include $(SRC)/cmd/Makefile.ctf
+include $(SRC)/test/Makefile.com
+
+CMDS = $(PROG:%=$(TESTDIR)/%)
+$(CMDS) := FILEMODE = 0555
+
+CPPFLAGS += -I$(SRC)/lib/mergeq -D_REENTRANT
+LDLIBS += -lumem
+
+all: $(PROG)
+
+install: all $(CMDS)
+
+lint: lint_SRCS
+
+clobber: clean
+	-$(RM) $(PROG)
+
+clean:
+	-$(RM) $(OBJS)
+
+%.o: %.c
+	$(COMPILE.c) -o $@ -c $<
+	$(POST_PROCESS_O)
+
+%.o: $(SRC)/lib/mergeq/%.c
+	$(COMPILE.c) -o $@ -c $<
+	$(POST_PROCESS_O)
+
+$(PROG): $(OBJS)
+	$(LINK.c) $(OBJS) -o $@ $(LDLIBS)
+	$(POST_PROCESS)
+
+$(CMDS): $(TESTDIR) $(PROG)
+
+$(TESTDIR):
+	$(INS.dir)
+
+$(TESTDIR)/%: %
+	$(INS.file)
diff --git a/usr/src/test/util-tests/tests/mergeq/mqt.c b/usr/src/test/util-tests/tests/mergeq/mqt.c
new file mode 100644
index 0000000000..e61e9173d2
--- /dev/null
+++ b/usr/src/test/util-tests/tests/mergeq/mqt.c
@@ -0,0 +1,217 @@
+/*
+ * This file and its contents are supplied under the terms of the
+ * Common Development and Distribution License ("CDDL"), version 1.0.
+ * You may only use this file in accordance with the terms of version
+ * 1.0 of the CDDL.
+ *
+ * A full copy of the text of the CDDL should have accompanied this
+ * source.  A copy of the CDDL is also available via the Internet at
+ * http://www.illumos.org/license/CDDL.
+ */
+
+/*
+ * Copyright 2015 Joyent, Inc.
+ */
+
+/*
+ * mergeq testing routines
+ */
+
+#include <mergeq.h>
+#include <stdio.h>
+#include <errno.h>
+#include <string.h>
+#include <stdlib.h>
+
+const char *
+_umem_debug_init()
+{
+	return ("default,verbose");
+}
+
+const char *
+_umem_logging_init(void)
+{
+	return ("fail,contents");
+}
+
+void *
+mergeq_alloc(size_t size)
+{
+	return (malloc(size));
+}
+
+/*ARGSUSED*/
+void
+mergeq_free(void *buf, size_t size)
+{
+	free(buf);
+}
+
+static int
+mqt_int(void *first, void *second, void **outp, void *arg)
+{
+	uintptr_t a, b, c;
+	a = (uintptr_t)first;
+	b = (uintptr_t)second;
+	c = a + b;
+	*outp = (void *)c;
+
+	return (0);
+}
+
+static int
+mqt_append(void *first, void *second, void **outp, void *arg)
+{
+	char *out;
+
+	/* Yes, this leaks, don't worry about it for the test */
+	if (asprintf(&out, "%s%s", first, second) != -1) {
+		*outp = out;
+		return (0);
+	}
+	return (-1);
+}
+
+static int
+mqt_fatal(void *first, void *second, void **outp, void *arg)
+{
+	return (-1);
+}
+
+/*
+ * Test structures and cases. We really want mq_args to be a flexible array
+ * member, but then we cant initialize it. Thus we set a fixed size number of
+ * entries.
+ */
+typedef struct mq_test {
+	const char	*mq_desc;	/* test description/name */
+	mergeq_proc_f	*mq_proc;	/* processing function */
+	int		mq_rval;	/* mergeq_merge return value */
+	int		mq_uerr;	/* user error, if any */
+	boolean_t	mq_strcmp;	/* use strcmp rather than == */
+	void		*mq_result;	/* expected result */
+	void		**mq_args;	/* argument array */
+} mq_test_t;
+
+static void *mqt_empty_args[] = { NULL };
+static void *mqt_single_args[] = { (void *)42, NULL };
+static void *mqt_double_args[] = { (void *)42, (void *)27, NULL };
+static void *mqt_wrap_args[] = {
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, NULL
+};
+static void *mqt_grow_args[] = {
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, NULL
+};
+static void *mqt_order_args[] = { "l", "e", "g", "e", "n", "d", " ", "o", "f",
+	" ", "z", "e", "l", "d", "a", NULL };
+
+
+static mq_test_t mq_tests[] = {
+	{ "empty", mqt_int, 0, 0, B_FALSE, NULL, mqt_empty_args },
+	{ "single", mqt_int, 0, 0, B_FALSE, (void *)42, mqt_single_args },
+	{ "double", mqt_int, 0, 0, B_FALSE, (void *)69, mqt_double_args },
+	{ "wrap", mqt_int, 0, 0, B_FALSE, (void *)64, mqt_wrap_args },
+	{ "grow", mqt_int, 0, 0, B_FALSE, (void *)92, mqt_grow_args },
+	{ "fatal", mqt_fatal, MERGEQ_UERROR, -1, B_FALSE, NULL,
+	    mqt_double_args },
+	{ "order", mqt_append, 0, 0, B_TRUE, "alegend of zeld", mqt_order_args }
+};
+
+#define	NMQ_TESTS (sizeof (mq_tests) / sizeof (mq_test_t))
+
+static void
+mq_test_run(mergeq_t *mqp, mq_test_t *mqt)
+{
+	int ret, err;
+	void **itemp = mqt->mq_args;
+	void *out;
+
+	while (*itemp != NULL) {
+		if ((ret = mergeq_add(mqp, *itemp)) != 0) {
+			(void) fprintf(stderr,
+			    "test %s: failed to add item: %s\n",
+			    mqt->mq_desc, strerror(errno));
+			exit(1);
+		}
+		itemp++;
+	}
+
+	ret = mergeq_merge(mqp, mqt->mq_proc, NULL, &out, &err);
+	if (ret != mqt->mq_rval) {
+		(void) fprintf(stderr, "test %s: got incorrect rval. "
+		    "Expected %d, got %d\n", mqt->mq_desc, mqt->mq_rval, ret);
+		exit(1);
+	}
+
+	if (ret == MERGEQ_UERROR && err != mqt->mq_uerr) {
+		(void) fprintf(stderr, "test %s: got incorrect user error. "
+		    "Expected %d, got %d\n", mqt->mq_desc, mqt->mq_uerr, err);
+		exit(1);
+	}
+
+	if (ret == 0) {
+		if (mqt->mq_strcmp == B_TRUE &&
+		    strcmp(out, mqt->mq_result) != 0) {
+			(void) fprintf(stderr, "test %s: got unexpected "
+			    "result: %s, expected %s\n", mqt->mq_desc, out,
+			    mqt->mq_result);
+			exit(1);
+		} else if (mqt->mq_strcmp == B_FALSE && out != mqt->mq_result) {
+			(void) fprintf(stderr, "test %s: got unexpected "
+			    "result: %p, expected %p\n", mqt->mq_desc, out,
+			    mqt->mq_result);
+			exit(1);
+		}
+	}
+}
+
+int
+main(void)
+{
+	int ret, i, t;
+	mergeq_t *mqp;
+	int nthreads[] = { 1, 2, 4, 8, 16, 32, 64, 128, 256, -1 };
+
+	for (t = 0; nthreads[t] != -1; t++) {
+		printf("Beginning tests with %d threads\n", nthreads[t]);
+		if ((ret = mergeq_init(&mqp, nthreads[t])) != 0) {
+			fprintf(stderr, "failed to init mergeq: %s\n",
+			    strerror(errno));
+			return (1);
+		}
+
+		for (i = 0; i < NMQ_TESTS; i++) {
+			mq_test_run(mqp, &mq_tests[i]);
+		}
+
+		mergeq_fini(mqp);
+	}
+
+	return (0);
+}
diff --git a/usr/src/test/util-tests/tests/workq/Makefile b/usr/src/test/util-tests/tests/workq/Makefile
new file mode 100644
index 0000000000..ab5455fd86
--- /dev/null
+++ b/usr/src/test/util-tests/tests/workq/Makefile
@@ -0,0 +1,64 @@
+#
+# This file and its contents are supplied under the terms of the
+# Common Development and Distribution License ("CDDL"), version 1.0.
+# You may only use this file in accordance with the terms of version
+# 1.0 of the CDDL.
+#
+# A full copy of the text of the CDDL should have accompanied this
+# source.  A copy of the CDDL is also available via the Internet at
+# http://www.illumos.org/license/CDDL.
+#
+
+#
+# Copyright 2015 Joyent, Inc.
+#
+
+include $(SRC)/Makefile.master
+
+ROOTOPTPKG = $(ROOT)/opt/util-tests
+TESTDIR = $(ROOTOPTPKG)/tests/mergeq
+
+PROG = wqt
+OBJS = wqt.o workq.o
+
+include $(SRC)/cmd/Makefile.cmd
+include $(SRC)/cmd/Makefile.ctf
+include $(SRC)/test/Makefile.com
+
+CMDS = $(PROG:%=$(TESTDIR)/%)
+$(CMDS) := FILEMODE = 0555
+
+CPPFLAGS += -I$(SRC)/lib/mergeq -D_REENTRANT
+LDLIBS += -lumem
+
+all: $(PROG)
+
+install: all $(CMDS)
+
+lint: lint_SRCS
+
+clobber: clean
+	-$(RM) $(PROG)
+
+clean:
+	-$(RM) $(OBJS)
+
+%.o: %.c
+	$(COMPILE.c) -o $@ -c $<
+	$(POST_PROCESS_O)
+
+%.o: $(SRC)/lib/mergeq/%.c
+	$(COMPILE.c) -o $@ -c $<
+	$(POST_PROCESS_O)
+
+$(PROG): $(OBJS)
+	$(LINK.c) $(OBJS) -o $@ $(LDLIBS)
+	$(POST_PROCESS)
+
+$(CMDS): $(TESTDIR) $(PROG)
+
+$(TESTDIR):
+	$(INS.dir)
+
+$(TESTDIR)/%: %
+	$(INS.file)
diff --git a/usr/src/test/util-tests/tests/workq/wqt.c b/usr/src/test/util-tests/tests/workq/wqt.c
new file mode 100644
index 0000000000..bda0b4a9e5
--- /dev/null
+++ b/usr/src/test/util-tests/tests/workq/wqt.c
@@ -0,0 +1,196 @@
+/*
+ * This file and its contents are supplied under the terms of the
+ * Common Development and Distribution License ("CDDL"), version 1.0.
+ * You may only use this file in accordance with the terms of version
+ * 1.0 of the CDDL.
+ *
+ * A full copy of the text of the CDDL should have accompanied this
+ * source.  A copy of the CDDL is also available via the Internet at
+ * http://www.illumos.org/license/CDDL.
+ */
+
+/*
+ * Copyright 2015 Joyent, Inc.
+ */
+
+/*
+ * workq testing routines
+ *
+ * What we want to guarantee is that every function is executed exactly once. To
+ * that end we have the callback function basically increment a global in the
+ * test around a mutex.
+ */
+
+#include <workq.h>
+#include <stdio.h>
+#include <errno.h>
+#include <string.h>
+#include <stdlib.h>
+#include <thread.h>
+#include <synch.h>
+
+mutex_t wqt_lock = ERRORCHECKMUTEX;
+uintptr_t wqt_count;
+
+const char *
+_umem_debug_init()
+{
+	return ("default,verbose");
+}
+
+const char *
+_umem_logging_init(void)
+{
+	return ("fail,contents");
+}
+
+void *
+workq_alloc(size_t size)
+{
+	return (malloc(size));
+}
+
+/*ARGSUSED*/
+void
+workq_free(void *buf, size_t size)
+{
+	free(buf);
+}
+
+/*ARGSUSED*/
+int
+wqt_fatal(void *item, void *arg)
+{
+	return (-1);
+}
+
+int
+wqt_add(void *item, void *arg)
+{
+	uintptr_t a = (uintptr_t)item;
+
+	mutex_enter(&wqt_lock);
+	wqt_count += a;
+	mutex_exit(&wqt_lock);
+
+	return (0);
+}
+
+typedef struct wq_test {
+	const char	*wq_desc;	/* test description/name */
+	workq_proc_f	*wq_proc;	/* processing function */
+	int		wq_rval;	/* workq_work return value */
+	int		wq_uerr;	/* user error, if any */
+	uintptr_t	wq_sum;		/* expected sum */
+	void		**wq_args;	/* argument array */
+} wq_test_t;
+
+static void *wqt_empty_args[] = { NULL };
+static void *wqt_single_args[] = { (void *)42, NULL };
+static void *wqt_double_args[] = { (void *)42, (void *)27, NULL };
+static void *wqt_wrap_args[] = {
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, NULL
+};
+static void *wqt_grow_args[] = {
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, (void *)1, (void *)1, (void *)1, (void *)1,
+	(void *)1, (void *)1, NULL
+};
+
+static wq_test_t wq_tests[] = {
+	{ "empty", wqt_add, 0, 0, NULL, wqt_empty_args },
+	{ "single", wqt_add, 0, 0, 42, wqt_single_args },
+	{ "double", wqt_add, 0, 0, 69, wqt_double_args },
+	{ "wrap", wqt_add, 0, 0, 64, wqt_wrap_args },
+	{ "grow", wqt_add, 0, 0, 92, wqt_grow_args },
+	{ "fatal", wqt_fatal, WORKQ_UERROR, -1, -1, wqt_double_args }
+};
+
+#define	NWQ_TESTS (sizeof (wq_tests) / sizeof (wq_test_t))
+
+static void
+wq_test_run(workq_t *wqp, wq_test_t *wqt)
+{
+	int ret, err;
+	void **itemp = wqt->wq_args;
+
+	while (*itemp != NULL) {
+		if ((ret = workq_add(wqp, *itemp)) != 0) {
+			(void) fprintf(stderr, "test %s: failed to add item: "
+			    "%s\n", wqt->wq_desc, strerror(errno));
+			exit(1);
+		}
+		itemp++;
+	}
+
+	wqt_count = 0;
+	ret = workq_work(wqp, wqt->wq_proc, NULL, &err);
+	if (ret != wqt->wq_rval) {
+		(void) fprintf(stderr, "test %s: got incorrect rval. "
+		    "Expected %d, got %d (%d)\n", wqt->wq_desc, wqt->wq_rval,
+		    ret, errno);
+		exit(1);
+	}
+
+	if (ret == WORKQ_UERROR && err != wqt->wq_uerr) {
+		(void) fprintf(stderr, "test %s: got incorrect user error. "
+		    "Expected %d, got %d\n", wqt->wq_desc, wqt->wq_uerr, err);
+		exit(1);
+	}
+
+	if (ret == 0 && wqt_count != wqt->wq_sum) {
+		(void) fprintf(stderr, "test %s: got unexpected "
+		    "result: %d, expected %d\n", wqt->wq_desc, wqt_count,
+		    wqt->wq_sum);
+		exit(1);
+	}
+}
+
+int
+main(void)
+{
+	int ret, i, t;
+	workq_t *wqp;
+	int nthreads[] = { 1, 2, 4, 8, 16, 32, 64, 128, 256, -1 };
+
+	for (t = 0; nthreads[t] != -1; t++) {
+		printf("Beginning tests with %d threads\n", nthreads[t]);
+		if ((ret = workq_init(&wqp, nthreads[t])) != 0) {
+			fprintf(stderr, "failed to init workq: %s\n",
+			    strerror(errno));
+			return (1);
+		}
+
+		for (i = 0; i < NWQ_TESTS; i++) {
+			wq_test_run(wqp, &wq_tests[i]);
+		}
+
+		workq_fini(wqp);
+	}
+
+
+	return (0);
+}