diff options
| author | Marcel Telka <marcel@telka.sk> | 2016-12-08 17:04:19 +0100 |
|---|---|---|
| committer | Dan McDonald <danmcd@omniti.com> | 2016-12-09 10:30:26 -0500 |
| commit | b7f0713395ae116c0f57e4a7088abbc989470b04 (patch) | |
| tree | 05cd93e186a2749904a673b11ed34d023d77f4a4 /usr/src/uts/common/rpc | |
| parent | 0570e35bbcf3793c3e5aef6ae971d1b6a32bacff (diff) | |
| download | illumos-joyent-b7f0713395ae116c0f57e4a7088abbc989470b04.tar.gz | |
7655 XIDHASH macro simplification
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
Reviewed by: Igor Kozhukhov <igor@dilos.org>
Reviewed by: Eric Sproul <eric.sproul@circonus.com>
Approved by: Dan McDonald <danmcd@omniti.com>
Diffstat (limited to 'usr/src/uts/common/rpc')
| -rw-r--r-- | usr/src/uts/common/rpc/svc_clts.c | 7 | ||||
| -rw-r--r-- | usr/src/uts/common/rpc/svc_cots.c | 7 | ||||
| -rw-r--r-- | usr/src/uts/common/rpc/svc_rdma.c | 7 |
3 files changed, 6 insertions, 15 deletions
diff --git a/usr/src/uts/common/rpc/svc_clts.c b/usr/src/uts/common/rpc/svc_clts.c index 4c891510bc..cc161c1457 100644 --- a/usr/src/uts/common/rpc/svc_clts.c +++ b/usr/src/uts/common/rpc/svc_clts.c @@ -751,15 +751,12 @@ svc_clts_kfreeres(SVCXPRT *clone_xprt) #define MAXDUPREQS 8192 /* - * This should be appropriately scaled to MAXDUPREQS. + * This should be appropriately scaled to MAXDUPREQS. To produce as less as + * possible collisions it is suggested to set this to a prime. */ #define DRHASHSZ 2053 -#if ((DRHASHSZ & (DRHASHSZ - 1)) == 0) -#define XIDHASH(xid) ((xid) & (DRHASHSZ - 1)) -#else #define XIDHASH(xid) ((xid) % DRHASHSZ) -#endif #define DRHASH(dr) XIDHASH((dr)->dr_xid) #define REQTOXID(req) ((req)->rq_xprt->xp_xid) diff --git a/usr/src/uts/common/rpc/svc_cots.c b/usr/src/uts/common/rpc/svc_cots.c index fde51407d2..d4e93b0002 100644 --- a/usr/src/uts/common/rpc/svc_cots.c +++ b/usr/src/uts/common/rpc/svc_cots.c @@ -717,15 +717,12 @@ svc_cots_kfreeres(SVCXPRT *clone_xprt) #define MAXDUPREQS 8192 /* - * This should be appropriately scaled to MAXDUPREQS. + * This should be appropriately scaled to MAXDUPREQS. To produce as less as + * possible collisions it is suggested to set this to a prime. */ #define DRHASHSZ 2053 -#if ((DRHASHSZ & (DRHASHSZ - 1)) == 0) -#define XIDHASH(xid) ((xid) & (DRHASHSZ - 1)) -#else #define XIDHASH(xid) ((xid) % DRHASHSZ) -#endif #define DRHASH(dr) XIDHASH((dr)->dr_xid) #define REQTOXID(req) ((req)->rq_xprt->xp_xid) diff --git a/usr/src/uts/common/rpc/svc_rdma.c b/usr/src/uts/common/rpc/svc_rdma.c index dda854a369..f4d6efde94 100644 --- a/usr/src/uts/common/rpc/svc_rdma.c +++ b/usr/src/uts/common/rpc/svc_rdma.c @@ -1143,15 +1143,12 @@ svc_rdma_kfreeres(SVCXPRT *clone_xprt) #define MAXDUPREQS 8192 /* - * This should be appropriately scaled to MAXDUPREQS. + * This should be appropriately scaled to MAXDUPREQS. To produce as less as + * possible collisions it is suggested to set this to a prime. */ #define DRHASHSZ 2053 -#if ((DRHASHSZ & (DRHASHSZ - 1)) == 0) -#define XIDHASH(xid) ((xid) & (DRHASHSZ - 1)) -#else #define XIDHASH(xid) ((xid) % DRHASHSZ) -#endif #define DRHASH(dr) XIDHASH((dr)->dr_xid) #define REQTOXID(req) ((req)->rq_xprt->xp_xid) |