8699 Want NIC transceiver visibility (fix lint)

Reviewed by: Robert Mustacchi <rm@joyent.com>
Approved by: Robert Mustacchi <rm@joyent.com>

5 files changed, 31 insertions, 19 deletions

diff --git a/usr/src/test/util-tests/tests/libsff/Makefile b/usr/src/test/util-tests/tests/libsff/Makefile
index 99a3053259..4f40e7ef4d 100644
--- a/usr/src/test/util-tests/tests/libsff/Makefile
+++ b/usr/src/test/util-tests/tests/libsff/Makefile
@@ -41,6 +41,8 @@ PROGS = $(DIFF_PROGS) \
 	$(ERR_PROGS) \
 	libsff_strings
 
+LINTS = $(PROGS:%=%.ln)
+
 SCRIPTS = libsff
 
 include $(SRC)/cmd/Makefile.cmd
@@ -60,15 +62,21 @@ CPPFLAGS += -I$(SRC)/lib/libsff/common
 $(ERR_PROGS)	:= LDLIBS += -lsff
 $(DIFF_PROGS)	:= LDLIBS += -lsff -lnvpair
 libsff_strings	:= LDLIBS += -lsff -lnvpair
+$(ERR_PROGS).ln	:= LDLIBS += -lsff
+$(DIFF_PROGS).ln	:= LDLIBS += -lsff -lnvpair
+libsff_strings.ln	:= LDLIBS += -lsff -lnvpair
 
 all: $(PROGS)
 
 install: all $(CMDS) $(OUTFILES)
 
-lint: lint_SRCS
+lint: $(LINTS)
+
+%.ln: %.c
+	$(LINT.c) -erroff=E_NAME_USED_NOT_DEF2 $< $(LDLIBS)
 
 clobber: clean
-	-$(RM) $(PROGS)
+	-$(RM) $(PROGS) $(LINTS)
 
 clean:
 
diff --git a/usr/src/test/util-tests/tests/libsff/libsff_8636_tech.c b/usr/src/test/util-tests/tests/libsff/libsff_8636_tech.c
index 21f02cab8c..736e6101c4 100644
--- a/usr/src/test/util-tests/tests/libsff/libsff_8636_tech.c
+++ b/usr/src/test/util-tests/tests/libsff/libsff_8636_tech.c
@@ -68,7 +68,7 @@ main(void)
 
 		if ((ret = libsff_parse(buf, sizeof (buf), 0xa0, &nvl)) != 0) {
 			errx(1, "TEST FAILED: failed to parse QSFP device tech "
-			    "%d: %s\n", i, strerror(errno));
+			    "%d: %s\n", i, strerror(ret));
 		}
 
 		lst_print_array(nvl, LIBSFF_KEY_TRAN_TECH);
diff --git a/usr/src/test/util-tests/tests/libsff/libsff_8636_temp.c b/usr/src/test/util-tests/tests/libsff/libsff_8636_temp.c
index 5e3ba70cd4..beeddc5e15 100644
--- a/usr/src/test/util-tests/tests/libsff/libsff_8636_temp.c
+++ b/usr/src/test/util-tests/tests/libsff/libsff_8636_temp.c
@@ -44,13 +44,13 @@ main(void)
 		buf[SFF_8636_MAX_CASE_TEMP] = i;
 		if ((ret = libsff_parse(buf, sizeof (buf), 0xa0, &nvl)) != 0) {
 			errx(1, "TEST FAILED: failed to parse QSFP connector "
-			    "%d: %s\n", i, strerror(errno));
+			    "%d: %s\n", i, strerror(ret));
 		}
 
 		if ((ret = nvlist_lookup_string(nvl, LIBSFF_KEY_MAX_CASE_TEMP,
 		    &val)) != 0) {
 			errx(1, "TEST FAILED: failed to find connector when "
-			    "parsing key %d: %s\n", i, strerror(errno));
+			    "parsing key %d: %s\n", i, strerror(ret));
 		}
 
 		(void) puts(val);
diff --git a/usr/src/test/util-tests/tests/libsff/libsff_efault.c b/usr/src/test/util-tests/tests/libsff/libsff_efault.c
index 7f57529d81..e482e8ef5d 100644
--- a/usr/src/test/util-tests/tests/libsff/libsff_efault.c
+++ b/usr/src/test/util-tests/tests/libsff/libsff_efault.c
@@ -28,10 +28,10 @@
 int
 main(void)
 {
-	int ret;
 	void *addr;
 	nvlist_t *nvl;
 	size_t len = getpagesize();
+	int ret;
 
 	/*
 	 * Get an unreadable page
@@ -46,8 +46,8 @@ main(void)
 	}
 
 	if ((ret = libsff_parse(addr, 128, 0xa0, &nvl)) != EFAULT) {
-		errx(1, "TEST FAILED: failed to return EFAULT on bad"
-		    "data buffer\n");
+		errx(1, "TEST FAILED: failed to return EFAULT on bad "
+		    "data buffer (%s instead)\n", strerror(ret));
 	}
 
 	return (0);
diff --git a/usr/src/test/util-tests/tests/libsff/libsff_einval.c b/usr/src/test/util-tests/tests/libsff/libsff_einval.c
index ac835f95e7..9e87e2b4f7 100644
--- a/usr/src/test/util-tests/tests/libsff/libsff_einval.c
+++ b/usr/src/test/util-tests/tests/libsff/libsff_einval.c
@@ -28,9 +28,9 @@
 int
 main(void)
 {
-	int ret;
 	uint8_t buf[256];
 	nvlist_t *nvl;
+	int ret;
 
 	bzero(buf, sizeof (buf));
 	if ((ret = libsff_parse(NULL, sizeof (buf), 0xa0, &nvl)) != EINVAL) {
@@ -38,50 +38,54 @@ main(void)
 	}
 
 	if ((ret = libsff_parse(buf, sizeof (buf), 0xa0, NULL)) != EINVAL) {
-		errx(1, "TEST FAILED: failed to return EINVAL on NULL nvl");
+		errx(1, "TEST FAILED: failed to return EINVAL on NULL nvl "
+		    "(%s instead)", strerror(ret));
 	}
 
 	if ((ret = libsff_parse(buf, sizeof (buf), 0xa1, &nvl)) != EINVAL) {
-		errx(1, "TEST FAILED: failed to return EINVAL on bad page");
+		errx(1, "TEST FAILED: failed to return EINVAL on bad page "
+		    "(%s instead)", strerror(ret));
 	}
 
 	if ((ret = libsff_parse(buf, sizeof (buf), 0, &nvl)) != EINVAL) {
-		errx(1, "TEST FAILED: failed to return EINVAL on bad page");
+		errx(1, "TEST FAILED: failed to return EINVAL on bad page "
+		    "(%s instead)", strerror(ret));
 	}
 
 	if ((ret = libsff_parse(buf, sizeof (buf), 0xff, &nvl)) != EINVAL) {
-		errx(1, "TEST FAILED: failed to return EINVAL on bad page");
+		errx(1, "TEST FAILED: failed to return EINVAL on bad page "
+		    "(%s instead)", strerror(ret));
 	}
 
 	if ((ret = libsff_parse(buf, 0, 0xa0, &nvl)) != EINVAL) {
 		errx(1, "TEST FAILED: failed to return EINVAL on bad 8476 "
-		    "size");
+		    "size (%s instead)", strerror(ret));
 	}
 
 	if ((ret = libsff_parse(buf, 50, 0xa0, &nvl)) != EINVAL) {
 		errx(1, "TEST FAILED: failed to return EINVAL on bad 8476 "
-		    "size");
+		    "size (%s instead)", strerror(ret));
 	}
 
 	buf[SFF_8472_IDENTIFIER] = SFF_8024_ID_QSFP;
 	if ((ret = libsff_parse(buf, 0, 0xa0, &nvl)) != EINVAL) {
 		errx(1, "TEST FAILED: failed to return EINVAL on bad 8476 "
-		    "size");
+		    "size (%s instead)", strerror(ret));
 	}
 
 	if ((ret = libsff_parse(buf, 50, 0xa0, &nvl)) != EINVAL) {
 		errx(1, "TEST FAILED: failed to return EINVAL on bad 8476 "
-		    "size");
+		    "size (%s instead)", strerror(ret));
 	}
 
 	if ((ret = libsff_parse(buf, 96, 0xa0, &nvl)) != EINVAL) {
 		errx(1, "TEST FAILED: failed to return EINVAL on bad 8635 "
-		    "size");
+		    "size (%s instead)", strerror(ret));
 	}
 
 	if ((ret = libsff_parse(buf, 128, 0xa0, &nvl)) != EINVAL) {
 		errx(1, "TEST FAILED: failed to return EINVAL on bad 8635 "
-		    "size");
+		    "size (%s instead)", strerror(ret));
 	}
 
 	return (0);