6351554 Kernel build should be more pedantic

8 files changed, 27 insertions, 26 deletions

diff --git a/usr/src/common/bignum/bignumimpl.c b/usr/src/common/bignum/bignumimpl.c
index cf42c030ee..359fc989f8 100644
--- a/usr/src/common/bignum/bignumimpl.c
+++ b/usr/src/common/bignum/bignumimpl.c
@@ -2439,7 +2439,7 @@ big_nextprime_pos(BIGNUM *result, BIGNUM *n)
 	if ((err = big_copy(result, n)) != BIG_OK)
 		return (err);
 	result->value[0] |= 1;
-	/* LINTED */
+	/* CONSTCOND */
 	while (1) {
 		for (i = 0; i < SIEVESIZE; i++) sieve[i] = 0;
 		for (i = 0;
@@ -2471,7 +2471,7 @@ big_nextprime_pos(BIGNUM *result, BIGNUM *n)
 				return (err);
 		}
 	}
-	return (BIG_OK);
+	/* NOTREACHED */
 }
 
 
diff --git a/usr/src/common/ipf/ip_rpcb_pxy.c b/usr/src/common/ipf/ip_rpcb_pxy.c
index 7f2be86ae9..fa1a230721 100644
--- a/usr/src/common/ipf/ip_rpcb_pxy.c
+++ b/usr/src/common/ipf/ip_rpcb_pxy.c
@@ -240,8 +240,6 @@ ippr_rpcb_in(fin, aps, nat)
 	{
 	case -1:
 		return(APR_ERR(1));
-		/*NOTREACHED*/
-		break;
 	case 0:
 		break;
 	case 1:
@@ -317,8 +315,6 @@ ippr_rpcb_out(fin, aps, nat)
                         MUTEX_EXIT(&rs->rs_rxlock);
                 }
 		return(APR_ERR(1));
-		/*NOTREACHED*/
-		break;
 	case  0: /* Negative reply / request rejected */
 		break;
 	case  1: /* Positive reply */
@@ -957,8 +953,6 @@ ippr_rpcb_decoderep(fin, nat, rs, rm, rxp)
 		{
 		case 0:
 			return(0);
-			/*NOTREACHED*/
-			break;
 		case 1:
 			break;
 		default:
diff --git a/usr/src/uts/Makefile.uts b/usr/src/uts/Makefile.uts
index 93c60af24c..f8a9613ce6 100644
--- a/usr/src/uts/Makefile.uts
+++ b/usr/src/uts/Makefile.uts
@@ -241,6 +241,9 @@ $(__GNUC)i386_C99MODE	= $(C99_ENABLE)
 sparc_C99MODE		= $(C99_DISABLE)
 C99MODE			= $($(MACH)_C99MODE)
 
+# Override the default, the kernel is squeaky clean
+CERRWARN = -errtags=yes -errwarn=%all
+
 CFLAGS_uts		=
 CFLAGS_uts		+= $(STAND_FLAGS_$(CLASS))
 CFLAGS_uts		+= $(CCVERBOSE)
diff --git a/usr/src/uts/common/fs/nfs/nfs4_vnops.c b/usr/src/uts/common/fs/nfs/nfs4_vnops.c
index 9ae1d0a56c..3e0051a6b5 100644
--- a/usr/src/uts/common/fs/nfs/nfs4_vnops.c
+++ b/usr/src/uts/common/fs/nfs/nfs4_vnops.c
@@ -509,8 +509,6 @@ nfs4args_verify(nfs_argop4 *argop, vattr_t *vap, enum nfs_opnum4 op,
 		break;
 	default:
 		return (EINVAL);
-		/*NOTREACHED*/
-		break;
 	}
 	if (!error)
 		error = vattr_to_fattr4(vap, NULL, attr, 0, op, supp);
diff --git a/usr/src/uts/common/io/lvm/md/md_names.c b/usr/src/uts/common/io/lvm/md/md_names.c
index 9f063c4324..8a447a4197 100644
--- a/usr/src/uts/common/io/lvm/md/md_names.c
+++ b/usr/src/uts/common/io/lvm/md/md_names.c
@@ -497,7 +497,8 @@ alloc_entry(
 		if (create_record(recid, nh, shared, 0L) < 0)
 			return ((caddr_t)0);
 	} /* go check the new record */
-	return ((caddr_t)0); /* if we come here..we have an error */
+	/* can't get here, but lint seems to think so */
+	/* NOTREACHED */
 }
 
 static void *
diff --git a/usr/src/uts/common/os/chip.c b/usr/src/uts/common/os/chip.c
index df0eeca4f8..c564933a72 100644
--- a/usr/src/uts/common/os/chip.c
+++ b/usr/src/uts/common/os/chip.c
@@ -124,6 +124,7 @@ chip_find(chipid_t chipid)
 	return (NULL);
 }
 
+#ifndef sun4v
 /*
  * Setup the kstats for this chip, if needed
  */
@@ -134,17 +135,6 @@ chip_kstat_create(chip_t *chp)
 	kstat_t		*chip_kstat;
 
 	ASSERT(MUTEX_HELD(&cpu_lock));
-	/*
-	 * Note: On sun4v systems, chip kstats don't currently
-	 * exist, since "chip" structures and policies are being
-	 * leveraged to implement core level balancing, and exporting
-	 * chip kstats in light of this would be both misleading
-	 * and confusing.
-	 */
-#ifdef	sun4v
-	return;
-	/*NOTREACHED*/
-#endif
 
 	if (chp->chip_kstat != NULL)
 		return;		/* already initialized */
@@ -166,6 +156,20 @@ chip_kstat_create(chip_t *chp)
 		kstat_install(chip_kstat);
 	}
 }
+#else
+/*
+ * Note: On sun4v systems, chip kstats don't currently
+ * exist, since "chip" structures and policies are being
+ * leveraged to implement core level balancing, and exporting
+ * chip kstats in light of this would be both misleading
+ * and confusing.
+ */
+/* ARGSUSED */
+void
+chip_kstat_create(chip_t *chp)
+{
+}
+#endif	/* !sun4v */
 
 static int
 chip_kstat_extract(kstat_t *ksp, int rw)
diff --git a/usr/src/uts/common/os/sunpm.c b/usr/src/uts/common/os/sunpm.c
index d209375e29..af6f38f78e 100644
--- a/usr/src/uts/common/os/sunpm.c
+++ b/usr/src/uts/common/os/sunpm.c
@@ -714,8 +714,6 @@ pm_decode_direction(int direction)
 	default:
 		return ("INVALID DIRECTION");
 	}
-	_NOTE(NOTREACHED);
-	ASSERT(0);
 }
 
 char *
@@ -737,8 +735,6 @@ pm_decode_op(pm_bus_power_op_t op)
 	default:
 		return ("UNKNOWN OP");
 	}
-	_NOTE(NOTREACHED);
-	ASSERT(0);
 }
 
 /*
diff --git a/usr/src/uts/i86pc/acpica/Makefile b/usr/src/uts/i86pc/acpica/Makefile
index 0faad23e5e..c63b729874 100644
--- a/usr/src/uts/i86pc/acpica/Makefile
+++ b/usr/src/uts/i86pc/acpica/Makefile
@@ -47,6 +47,11 @@ DEBUG_DEFS	+= $(DEBUG_FLGS)
 #
 CFLAGS += $(CCVERBOSE) -DPWRDMN -DACPI_USE_LOCAL_CACHE
 
+#
+# 3rd party code is not lint clean
+#
+CERRWARN += -erroff=E_STATEMENT_NOT_REACHED
+
 LINTFLAGS += -errchk=%none
 LINTFLAGS += -errhdr=%none
 LINTFLAGS += -erroff=%all