mk: make BROKEN a list of lines, like PKG_FAIL_REASON

Packages defined the variable BROKEN inconsistently. Some added quotes,
like they are required in PKG_FAIL_REASON, some omitted them.

Now all packages behave the same, and pkglint will flag future mistakes.

15 files changed, 34 insertions, 33 deletions

diff --git a/devel/p5-Devel-BeginLift/Makefile b/devel/p5-Devel-BeginLift/Makefile
index a1e990b5199..ecb4e60b785 100644
--- a/devel/p5-Devel-BeginLift/Makefile
+++ b/devel/p5-Devel-BeginLift/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.15 2019/08/11 13:19:14 wiz Exp $
+# $NetBSD: Makefile,v 1.16 2019/11/04 17:47:29 rillig Exp $
 
 DISTNAME=	Devel-BeginLift-0.001003
 PKGNAME=	p5-${DISTNAME}
@@ -19,8 +19,8 @@ PERL5_MODULE_TYPE=	Module::Install::Bundled
 
 MAKE_ENV+=	PERL_USE_UNSAFE_INC=1
 
-BROKEN=		Not compatible with the current version of Perl.
-BROKEN+=	See: https://rt.cpan.org/Public/Bug/Display.html?id=115272
+BROKEN=		"Not compatible with the current version of Perl."
+BROKEN+=	"See: https://rt.cpan.org/Public/Bug/Display.html?id=115272"
 
 BUILDLINK_DEPMETHOD.p5-B-Hooks-OP-Check=	full
 BUILDLINK_API_DEPENDS.p5-B-Hooks-OP-Check+=	p5-B-Hooks-OP-Check>=0.19
diff --git a/devel/php-pthreads/Makefile b/devel/php-pthreads/Makefile
index 5dcfacad796..4f9af305145 100644
--- a/devel/php-pthreads/Makefile
+++ b/devel/php-pthreads/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.7 2017/09/16 19:26:47 wiz Exp $
+# $NetBSD: Makefile,v 1.8 2019/11/04 17:47:30 rillig Exp $
 
 MODNAME=	pthreads
 PECL_VERSION=	2.0.10
@@ -22,7 +22,7 @@ USE_LIBTOOL=	yes
 .include "../../lang/php/phpversion.mk"
 
 .if empty(PKG_BUILD_OPTIONS.${PHP_PKG_PREFIX}:Mmaintainer-zts)
-BROKEN=		Requires the maintainer-zts option enabled in PHP.
+BROKEN=		"Requires the maintainer-zts option enabled in PHP."
 .endif
 
 .include "../../mk/pthread.buildlink3.mk"
diff --git a/games/xbat/Makefile b/games/xbat/Makefile
index 2669600ef71..d3472ee3d6d 100644
--- a/games/xbat/Makefile
+++ b/games/xbat/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.18 2018/01/14 17:34:02 rillig Exp $
+# $NetBSD: Makefile,v 1.19 2019/11/04 17:47:30 rillig Exp $
 
 DISTNAME=	xev111
 PKGNAME=	xbat-1.11
@@ -47,7 +47,7 @@ MAKE_FLAGS+=	UNION=0
 .elif ${MACHINE_ENDIAN} == "little"
 MAKE_FLAGS+=	UNION=1
 .else
-BROKEN=		Unknown endianness
+BROKEN=		"Unknown endianness"
 .endif
 
 post-install:
diff --git a/graphics/AfterShotPro/Makefile b/graphics/AfterShotPro/Makefile
index 82a710d6845..6ddb8f01709 100644
--- a/graphics/AfterShotPro/Makefile
+++ b/graphics/AfterShotPro/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.6 2019/11/02 22:37:52 rillig Exp $
+# $NetBSD: Makefile,v 1.7 2019/11/04 17:47:30 rillig Exp $
 
 CATEGORIES=	graphics
 MASTER_SITES=	http://www.corel.com/akdlm/6763/downloads/AfterShotPro/1/PF/
@@ -45,7 +45,7 @@ PKGNAME=	${DISTNAME:S/_i386/-1.1.0.30/}
 #DISTNAME=	AfterShotPro_amd64
 #PKGNAME=	${DISTNAME:S/_amd64/-1.1.0.30/}
 .else
-BROKEN=		Not supported for this emulation
+BROKEN=		"Not supported for this emulation"
 .endif
 
 do-extract: ${WRKDIR}
diff --git a/lang/perl5/options.mk b/lang/perl5/options.mk
index bb30f063b57..e799a1875a9 100644
--- a/lang/perl5/options.mk
+++ b/lang/perl5/options.mk
@@ -1,4 +1,4 @@
-# $NetBSD: options.mk,v 1.13 2019/11/03 19:04:05 rillig Exp $
+# $NetBSD: options.mk,v 1.14 2019/11/04 17:47:30 rillig Exp $
 
 PKG_OPTIONS_VAR=		PKG_OPTIONS.perl
 PKG_OPTIONS_REQUIRED_GROUPS=	perlbits
@@ -89,7 +89,7 @@ CONFIGURE_ARGS+=	-Duse64bitall
 CONFIGURE_ARGS+=	-Uuse64bitall -Uusemorebits -Uuse64bitint
 .else
 .  if ${OBJECT_FMT} == "XCOFF"
-BROKEN=			XCOFF targets need the path specified where libperl.a resides.\
-			Please choose on of 64bitint 64bitmore 64bitall or 64bitnone to allow this.
+BROKEN=			"XCOFF targets need the path specified where libperl.a resides."
+BROKEN+=		"Please choose on of 64bitint 64bitmore 64bitall or 64bitnone to allow this."
 .  endif
 .endif
diff --git a/math/py-scipy/Makefile b/math/py-scipy/Makefile
index faceba1d596..00d78e4cb37 100644
--- a/math/py-scipy/Makefile
+++ b/math/py-scipy/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.39 2019/11/02 16:16:22 rillig Exp $
+# $NetBSD: Makefile,v 1.40 2019/11/04 17:47:30 rillig Exp $
 
 DISTNAME=	scipy-1.3.0
 PKGNAME=	${PYPKGPREFIX}-${DISTNAME}
@@ -22,7 +22,7 @@ PYSETUPBUILDARGS+=	--fcompiler=g95
 PYSETUPBUILDARGS+=	--fcompiler=gnu95
 LDFLAGS.Darwin+=	-undefined dynamic_lookup
 .else
-BROKEN=			Requires fortran 95
+BROKEN=			"Requires fortran 95"
 .endif
 
 CPPFLAGS+=	-D__STDC_FORMAT_MACROS
diff --git a/math/py-scipy12/Makefile b/math/py-scipy12/Makefile
index 6be176f484c..5dfc89a6ebd 100644
--- a/math/py-scipy12/Makefile
+++ b/math/py-scipy12/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.2 2019/11/02 16:16:22 rillig Exp $
+# $NetBSD: Makefile,v 1.3 2019/11/04 17:47:30 rillig Exp $
 
 DISTNAME=	scipy-1.2.2
 PKGNAME=	${PYPKGPREFIX}-${DISTNAME}
@@ -22,7 +22,7 @@ PYSETUPBUILDARGS+=	--fcompiler=g95
 PYSETUPBUILDARGS+=	--fcompiler=gnu95
 LDFLAGS.Darwin+=	-undefined dynamic_lookup
 .else
-BROKEN=			Requires fortran 95
+BROKEN=			"Requires fortran 95"
 .endif
 
 CPPFLAGS+=	-D__STDC_FORMAT_MACROS
diff --git a/mk/bsd.pkg.mk b/mk/bsd.pkg.mk
index 83ae993cf1f..01e07818fab 100644
--- a/mk/bsd.pkg.mk
+++ b/mk/bsd.pkg.mk
@@ -1,4 +1,4 @@
-#	$NetBSD: bsd.pkg.mk,v 1.2032 2019/08/18 21:58:51 rillig Exp $
+#	$NetBSD: bsd.pkg.mk,v 1.2033 2019/11/04 17:47:30 rillig Exp $
 #
 # This file is in the public domain.
 #
@@ -480,8 +480,9 @@ PKG_SKIP_REASON+= "${PKGNAME} is restricted:" \
 .  if defined(USE_X11) && (${X11_TYPE} == "native") && !exists(${X11BASE})
 PKG_FAIL_REASON+= "${PKGNAME} uses X11, but ${X11BASE} not found"
 .  endif
-.  if defined(BROKEN)
-PKG_FAIL_REASON+= "${PKGNAME} is marked as broken:" ${BROKEN:Q}
+.  if ${BROKEN:U:M*}
+PKG_FAIL_REASON+=	"${PKGNAME} is marked as broken:"
+PKG_FAIL_REASON+=	${BROKEN}
 .  endif
 
 .include "license.mk"
diff --git a/security/openvas-libraries/Makefile b/security/openvas-libraries/Makefile
index 890d350f4a6..429aeda903c 100644
--- a/security/openvas-libraries/Makefile
+++ b/security/openvas-libraries/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.21 2019/07/20 22:46:49 wiz Exp $
+# $NetBSD: Makefile,v 1.22 2019/11/04 17:47:30 rillig Exp $
 
 DISTNAME=	openvas-libraries-2.0.0
 PKGREVISION=	13
@@ -21,7 +21,7 @@ CONFIGURE_ARGS+=	--localstatedir=${VARBASE}
 # DragonFly-2.8.2 has dn_expand(3) in libc, and not have libresolv.
 BUILDLINK_TRANSFORM.DragonFly+=	rm:-lresolv
 
-BROKEN=		Does not build with gnutls-3.5 -- newer versions available.
+BROKEN=		"Does not build with gnutls-3.5 -- newer versions available."
 
 .include "../../security/libgcrypt/buildlink3.mk"
 .include "../../security/gnutls/buildlink3.mk"
diff --git a/sysutils/facette/Makefile b/sysutils/facette/Makefile
index 955387e8169..2098770aa72 100644
--- a/sysutils/facette/Makefile
+++ b/sysutils/facette/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.20 2018/11/14 22:22:23 kleink Exp $
+# $NetBSD: Makefile,v 1.21 2019/11/04 17:47:31 rillig Exp $
 
 DISTNAME=	facette-0.4.0dev
 PKGREVISION=	18
@@ -15,7 +15,7 @@ GITHUB_TAG=	d77e77680d52d232305d0f12af6e3e1c857903cb
 
 EXTRACT_USING=	bsdtar
 
-BROKEN=		Tries to install uglify-js during build.
+BROKEN=		"Tries to install uglify-js during build."
 
 .include "../../lang/go/version.mk"
 
diff --git a/sysutils/memtestplus/Makefile b/sysutils/memtestplus/Makefile
index 0d61701ca5e..510c28f2a3a 100644
--- a/sysutils/memtestplus/Makefile
+++ b/sysutils/memtestplus/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.27 2019/02/09 09:13:24 maya Exp $
+# $NetBSD: Makefile,v 1.28 2019/11/04 17:47:31 rillig Exp $
 #
 
 # Note -- version number also in the do-install rule
@@ -35,7 +35,7 @@ SUBST_SED.delcr=	-e 's/.$$//g'
 .include "../../mk/compiler.mk"
 
 .if !empty(PKGSRC_COMPILER:Mclang)
-BROKEN+=	${PKGNAME} does not produce a working binary with clang
+BROKEN+=	"Does not produce a working binary with clang."
 .endif
 
 pre-configure:
diff --git a/textproc/aspell-csb/Makefile b/textproc/aspell-csb/Makefile
index f86b87a4cbe..ec08cb379bc 100644
--- a/textproc/aspell-csb/Makefile
+++ b/textproc/aspell-csb/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.4 2019/07/06 19:12:47 nia Exp $
+# $NetBSD: Makefile,v 1.5 2019/11/04 17:47:31 rillig Exp $
 #
 
 DISTNAME=	aspell6-csb-0.02-0
@@ -17,7 +17,7 @@ USE_LANGUAGES=	# none
 
 .include "../../mk/bsd.prefs.mk"
 .if ${PKG_FORMAT} == "pkg" && ${OPSYS} == "Linux"
-BROKEN=	Non-ASCII PLIST and thus problem with libarchive on glibc systems.
+BROKEN=	"Non-ASCII PLIST and thus problem with libarchive on glibc systems."
 .endif
 
 .include "../../textproc/aspell/buildlink3.mk"
diff --git a/textproc/aspell-fo/Makefile b/textproc/aspell-fo/Makefile
index fecc8025b35..7335e7b9d5e 100644
--- a/textproc/aspell-fo/Makefile
+++ b/textproc/aspell-fo/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.10 2019/08/11 13:23:22 wiz Exp $
+# $NetBSD: Makefile,v 1.11 2019/11/04 17:47:31 rillig Exp $
 
 DISTNAME=	aspell-fo-0.4.2
 PKGREVISION=	6
@@ -18,7 +18,7 @@ INSTALLATION_DIRS+=	lib/aspell share/aspell
 
 .include "../../mk/bsd.prefs.mk"
 .if ${PKG_FORMAT} == "pkg" && ${OPSYS} == "Linux"
-BROKEN=	Can not be packaged on Linux
+BROKEN=	"Non-ASCII PLIST and thus problem with libarchive on glibc systems."
 .endif
 
 .include "../../textproc/aspell/buildlink3.mk"
diff --git a/textproc/aspell-is/Makefile b/textproc/aspell-is/Makefile
index 94b89c83ba8..d427f956b3e 100644
--- a/textproc/aspell-is/Makefile
+++ b/textproc/aspell-is/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.4 2017/09/16 19:27:12 wiz Exp $
+# $NetBSD: Makefile,v 1.5 2019/11/04 17:47:31 rillig Exp $
 #
 
 DISTNAME=	aspell-is-0.51.1-0
@@ -17,7 +17,7 @@ USE_LANGUAGES=	# none
 
 .include "../../mk/bsd.prefs.mk"
 .if ${PKG_FORMAT} == "pkg" && ${OPSYS} == "Linux"
-BROKEN=	Non-ASCII PLIST and thus problem with libarchive on glibc systems.
+BROKEN=	"Non-ASCII PLIST and thus problem with libarchive on glibc systems."
 .endif
 
 .include "../../textproc/aspell/buildlink3.mk"
diff --git a/textproc/aspell-nb/Makefile b/textproc/aspell-nb/Makefile
index f5c48314630..019f1fd11b0 100644
--- a/textproc/aspell-nb/Makefile
+++ b/textproc/aspell-nb/Makefile
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.2 2013/04/24 11:15:43 rodent Exp $
+# $NetBSD: Makefile,v 1.3 2019/11/04 17:47:31 rillig Exp $
 #
 
 DISTNAME=	aspell-nb-0.50.1-0
@@ -16,7 +16,7 @@ HAS_CONFIGURE=	yes
 
 .include "../../mk/bsd.prefs.mk"
 .if ${PKG_FORMAT} == "pkg" && ${OPSYS} == "Linux"
-BROKEN=	Can not be packaged on Linux
+BROKEN=	"Non-ASCII PLIST and thus problem with libarchive on glibc systems."
 .endif
 
 .include "../../textproc/aspell/buildlink3.mk"