diff options
| author | rillig <rillig@pkgsrc.org> | 2008-01-06 14:55:00 +0000 |
|---|---|---|
| committer | rillig <rillig@pkgsrc.org> | 2008-01-06 14:55:00 +0000 |
| commit | 567c07ece4eace0e335c452a007ca8bda5a38e5f (patch) | |
| tree | 369a9d97a770b90e854ed92863d80b2a3af711c9 | |
| parent | 853526ace589b7cd849912ac123b3a5772d7bd03 (diff) | |
| download | pkgsrc-567c07ece4eace0e335c452a007ca8bda5a38e5f.tar.gz | |
Deactivated the "NOTE: you can write "tool" instead of "${TOOL}", as
suggested by darcy@.
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index abf9f9b92e6..b76f7fe8538 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.754 2008/01/06 01:02:14 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.755 2008/01/06 14:55:00 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -4670,7 +4670,9 @@ sub checkline_mk_shelltext($$) { $line->log_warning("The \"${plain_tool}\" tool is used but not added to USE_TOOLS."); } - if (defined($mkctx_target) && $mkctx_target =~ qr"^(?:pre|do|post)-(?:extract|patch|wrapper|configure|build|install|package|clean)$") { + # Deactivated to allow package developers to write + # consistent code that uses ${TOOL} in all places. + if (false && defined($mkctx_target) && $mkctx_target =~ qr"^(?:pre|do|post)-(?:extract|patch|wrapper|configure|build|install|package|clean)$") { if (!exists(get_required_vartool_varnames()->{$vartool})) { $opt_warn_extra and $line->log_note("You can write \"${plain_tool}\" instead of \"${shellword}\"."); $opt_warn_extra and $line->explain_note( |