diff options
| author | rillig <rillig@pkgsrc.org> | 2005-05-23 06:47:11 +0000 |
|---|---|---|
| committer | rillig <rillig@pkgsrc.org> | 2005-05-23 06:47:11 +0000 |
| commit | fb5b667885edc88a497aefed9fc9c92d100c2ef6 (patch) | |
| tree | e6d42e285619540acf32314b73672a51a72a0515 | |
| parent | f3391b13889b223b69c8a822180bc92576fb99b2 (diff) | |
| download | pkgsrc-fb5b667885edc88a497aefed9fc9c92d100c2ef6.tar.gz | |
Only warn about use of $(VARIABLE) if it is not preceded by another $.
This avoids false positives in sed(1) expressions.
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index f6369cefa37..a84db776a04 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -11,7 +11,7 @@ # Freely redistributable. Absolutely no warranty. # # From Id: portlint.pl,v 1.64 1998/02/28 02:34:05 itojun Exp -# $NetBSD: pkglint.pl,v 1.169 2005/05/23 00:10:42 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.170 2005/05/23 06:47:11 rillig Exp $ # # This version contains lots of changes necessary for NetBSD packages # done by: @@ -1264,7 +1264,7 @@ sub checkfile_Makefile($) { # if ($opt_warn_paren) { log_info(NO_FILE, NO_LINE_NUMBER, "Checking for \$(VARIABLE)."); - if ($whole =~ /\$\([\w\d]+\)/) { + if ($whole =~ /[^\$]\$\([\w\d]+\)/) { log_warning(NO_FILE, NO_LINE_NUMBER, "Use \${VARIABLE} instead of \$(VARIABLE)."); } } |