diff options
| author | gdt <gdt@pkgsrc.org> | 2020-03-12 16:36:53 +0000 |
|---|---|---|
| committer | gdt <gdt@pkgsrc.org> | 2020-03-12 16:36:53 +0000 |
| commit | 05f2d0a620b74533184f6ff2f0f47a4789a3e0dd (patch) | |
| tree | 3b4934ce25a1c522a0ba8c7ebf819d002adaffe5 /databases | |
| parent | 2f62e46e5bb9a648225591deb5a41645855ff21f (diff) | |
| download | pkgsrc-05f2d0a620b74533184f6ff2f0f47a4789a3e0dd.tar.gz | |
databases/mongodb3: Update patch comment
Change text about the fdatasync issue based on information from Paul
Ripke.
Diffstat (limited to 'databases')
| -rw-r--r-- | databases/mongodb3/distinfo | 4 | ||||
| -rw-r--r-- | databases/mongodb3/patches/patch-src_third__party_wiredtiger_src_os__posix_os__fs.c | 19 |
2 files changed, 9 insertions, 14 deletions
diff --git a/databases/mongodb3/distinfo b/databases/mongodb3/distinfo index 9419ab714a9..ce7e7a119cb 100644 --- a/databases/mongodb3/distinfo +++ b/databases/mongodb3/distinfo @@ -1,4 +1,4 @@ -$NetBSD: distinfo,v 1.7 2020/03/06 14:22:46 gdt Exp $ +$NetBSD: distinfo,v 1.8 2020/03/12 16:36:53 gdt Exp $ SHA1 (mongodb-src-r3.4.24.tar.gz) = 86909b211998f0cbc8104df774aecb3d00a01763 RMD160 (mongodb-src-r3.4.24.tar.gz) = f7e4bfe1e2bd046f1a6c0f2695762076ffee5ae5 @@ -27,4 +27,4 @@ SHA1 (patch-src_third__party_mozjs-38_platform_x86__64_netbsd_build_js-confdefs. SHA1 (patch-src_third__party_mozjs-38_platform_x86__64_netbsd_include_js-config.h) = 7ddbb4e3bf4126a1be2195acc82ff859e8130a01 SHA1 (patch-src_third__party_s2_base_port.h) = 892ce91b5aaa432f34e1e7c169b7fd6eea2a3e94 SHA1 (patch-src_third__party_wiredtiger_SConscript) = 71fd2326a4e95fec674326225bce5ccf5793aa5a -SHA1 (patch-src_third__party_wiredtiger_src_os__posix_os__fs.c) = a9a8655421e99f9f189b299643b55ad44c5469d7 +SHA1 (patch-src_third__party_wiredtiger_src_os__posix_os__fs.c) = c1f227a2e026c0c90f438384b71873fecf27cde5 diff --git a/databases/mongodb3/patches/patch-src_third__party_wiredtiger_src_os__posix_os__fs.c b/databases/mongodb3/patches/patch-src_third__party_wiredtiger_src_os__posix_os__fs.c index 36866bcfda0..f0b418d3e3b 100644 --- a/databases/mongodb3/patches/patch-src_third__party_wiredtiger_src_os__posix_os__fs.c +++ b/databases/mongodb3/patches/patch-src_third__party_wiredtiger_src_os__posix_os__fs.c @@ -1,18 +1,13 @@ -$NetBSD: patch-src_third__party_wiredtiger_src_os__posix_os__fs.c,v 1.3 2020/03/06 14:22:46 gdt Exp $ +$NetBSD: patch-src_third__party_wiredtiger_src_os__posix_os__fs.c,v 1.4 2020/03/12 16:36:53 gdt Exp $ -Without this patch, the WT_PANIC_RET message happens, with errno EBADF. -The fdatasync() function is specified to fail if fd is not a valid file -descriptor that is open for writing. We believe that it is being called -on a directory, which is therefore invalid. On Linux, one can use -fdatasync() on non-writable file descriptors, but the Linux man page -acknowledges that this is non-standard behavior. +The fdatasync call is specified by POSIX, and the definition has changed: + https://pubs.opengroup.org/onlinepubs/009695399/functions/fdatasync.html + https://pubs.opengroup.org/onlinepubs/9699919799/functions/fdatasync.html -To work around this upstream bug, silently ignore fdatasync errno values -of EBADF. A better fix is likely to use fsync on directories instead. +NetBSD's fdatasync follows the earlier specification. For now, simply avoid +crashing on EBADF, at the possible expense of sync safety. -\todo Explore the fsync instead approach. - -\todo File upstream and add upstream bugtracker URL. +\todo Change NetBSD to follow the current standard. --- src/third_party/wiredtiger/src/os_posix/os_fs.c.orig 2020-01-08 16:30:41.000000000 +0000 +++ src/third_party/wiredtiger/src/os_posix/os_fs.c |