bugzilla: update to 5.0.6, fix default configuration

- No skin was installed
- Some configuration seemed to be relevant for Apache 2.2

5.0.6:
This release contains a schema change to the flagtypes table, allowing for many more flagtypes.

The flagtypes table should have been using a mediumint for several releases, but due to a bug in the schema migration code this never happened.

5.0.5:
This release reformats the code according to the same conventions as the popular Mojolicious product and includes a .perltidyrc to do the same. You may use whatever coding style you want, but all files commited to the repo must be reformatted according to those rules.

Additionally, we no longer follow the same release process as before. Releases will be more frequent.

As it is now 2019, the bugs_fulltext table is now InnoDB instead of MyISAM. This may cause upgrade headaches.

5.0.4:
This release fixes one security issue. CVE-2018-5123

This release also contains the following [% terms.bug %] fixes:

    checksetup.pl would fail to update Chart storage during pre-3.6 to 5.0 upgrade. ([% terms.Bug %] 1273846)
    editflagtypes.cgi would crash when classifications are enabled and the user did not have global editcomponents privileges. ([% terms.Bug %] 1310728)
    The File::Slurp would trigger warnings on perl 5.24. ([% terms.Bug %] 1301887)
    All the time entries in the 'when' column had the correct date but the time was fixed to 00:00 when using Sqlite. ([% terms.Bug %] 1303702)

6 files changed, 47 insertions, 34 deletions

diff --git a/devel/bugzilla/MESSAGE b/devel/bugzilla/MESSAGE
index 708ab93ddef..ec18dc43e60 100644
--- a/devel/bugzilla/MESSAGE
+++ b/devel/bugzilla/MESSAGE
@@ -1,5 +1,5 @@
 ===========================================================================
-$NetBSD: MESSAGE,v 1.5 2017/03/17 16:26:30 mef Exp $
+$NetBSD: MESSAGE,v 1.6 2021/01/16 08:15:01 maya Exp $
 
 To complete the setup you will need to read the Bugzilla-Guide.txt in order
 to setup Database counter-part properly.  In particular secion 2.2.2 of the
@@ -11,10 +11,13 @@ privilege,
 	./checksetup.pl
 
 You will need to make Bugzilla accessible through your HTTP server.
-If you are running Apache then you may add the following lines to httpd.conf:
+If you are running Apache then you will need to add the following lines to
+httpd.conf:
 
 	Include ${PKG_SYSCONFDIR}/bugzilla.conf
 
+And possibly enable mod_cgid or another CGI provider.
+
 to make Bugzilla accessible through:
 
 	http://localhost/bugzilla/index.cgi
diff --git a/devel/bugzilla/Makefile b/devel/bugzilla/Makefile
index 1eff0515a8a..2c524167f52 100644
--- a/devel/bugzilla/Makefile
+++ b/devel/bugzilla/Makefile
@@ -1,7 +1,6 @@
-# $NetBSD: Makefile,v 1.58 2020/09/04 11:09:01 wiz Exp $
+# $NetBSD: Makefile,v 1.59 2021/01/16 08:15:01 maya Exp $
 
-DISTNAME=	bugzilla-5.0.3
-PKGREVISION=	7
+DISTNAME=	bugzilla-5.0.6
 CATEGORIES=	www devel
 MASTER_SITES=	${MASTER_SITE_MOZILLA_ALL:=webtools/}
 
@@ -108,11 +107,11 @@ SUBST_SED.diff=		-e "s|\$$diffpath = .*|\$$diffpath = \'${DIFF:C,/[^/]+$,,}\';|"
 SUBST_NOOP_OK.diff=	yes
 
 INSTALLATION_DIRS+=	${DOCDIR} ${DOCDIR}/en ${EGDIR} ${BZDIR} ${BZDIR}/Bugzilla
-INSTALLATION_DIRS+=	${BZDIR}/js ${BZDIR}/lib ${BZDIR}/template ${BZDIR}/skins
+INSTALLATION_DIRS+=	${BZDIR}/js ${BZDIR}/lib ${BZDIR}/template ${BZDIR}/skins/standard
 INSTALLATION_DIRS+=	${BZDIR}/docs ${BZDIR}/docs/en ${BZDIR}/docs/en/html
 INSTALLATION_DIRS+=	${BZDIR}/images ${BZDIR}/docs/en/html/api
 INSTALLATION_DIRS+=	${BZDIR}/docs/en/html/api/Bugzilla
-.for i in data contrib t xt template lib graphs skins
+.for i in data contrib t xt template lib graphs
 INSTALLATION_DIRS+=	${BZDIR}/${i}
 .endfor
 
@@ -132,7 +131,7 @@ do-install:
 	${INSTALL_DATA_DIR} ${DESTDIR}${i}
 .endfor
 	(cd ${WRKSRC}					    ;\
-	pax -rw -pmp docs		${DESTDIR}${BZDIR} ;\
+	pax -rw -pmp docs		${DESTDIR}${BZDIR}  ;\
 	${INSTALL_SCRIPT} *.cgi *.pl	${DESTDIR}${BZDIR}  ;\
 	${INSTALL_SCRIPT} robots.txt	${DESTDIR}${BZDIR}  ;\
 	${INSTALL_DATA} Bugzilla.pm	${DESTDIR}${BZDIR}  ;\
@@ -141,11 +140,11 @@ do-install:
 	${INSTALL_DATA} bugzilla.conf	${DESTDIR}${EGDIR}  ;\
 	${INSTALL_DATA} images/*.png	${DESTDIR}${BZDIR}/images  ;\
 	${INSTALL_DATA} images/favicon.ico	${DESTDIR}${BZDIR} ;\
+	pax -rw -pmp skins		${DESTDIR}${BZDIR}  ;\
 	pax -rw -pmp Bugzilla		${DESTDIR}${BZDIR}  ;\
 	pax -rw -pmp js			${DESTDIR}${BZDIR}  ;\
-	pax -rw -pmp template		${DESTDIR}${BZDIR} ;\
+	pax -rw -pmp template		${DESTDIR}${BZDIR}  ;\
 	)
-	${RM} ${DESTDIR}${BZDIR}/Bugzilla/Install/Filesystem.pm.orig
 
 .include "../../mk/apache.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git a/devel/bugzilla/PLIST b/devel/bugzilla/PLIST
index b3c8411e215..e1a8c3257e5 100644
--- a/devel/bugzilla/PLIST
+++ b/devel/bugzilla/PLIST
@@ -1,4 +1,4 @@
-@comment $NetBSD: PLIST,v 1.18 2017/03/17 16:26:30 mef Exp $
+@comment $NetBSD: PLIST,v 1.19 2021/01/16 08:15:01 maya Exp $
 share/bugzilla/Bugzilla.pm
 share/bugzilla/Bugzilla/Attachment.pm
 share/bugzilla/Bugzilla/Attachment/PatchReader.pm
@@ -449,6 +449,24 @@ share/bugzilla/show_activity.cgi
 share/bugzilla/show_bug.cgi
 share/bugzilla/showdependencygraph.cgi
 share/bugzilla/showdependencytree.cgi
+share/bugzilla/skins/README
+share/bugzilla/skins/contrib/Dusk/buglist.css
+share/bugzilla/skins/contrib/Dusk/global.css
+share/bugzilla/skins/standard/admin.css
+share/bugzilla/skins/standard/bug.css
+share/bugzilla/skins/standard/buglist.css
+share/bugzilla/skins/standard/dependency-tree/bug-item.png
+share/bugzilla/skins/standard/dependency-tree/tree-closed.png
+share/bugzilla/skins/standard/dependency-tree/tree-open.png
+share/bugzilla/skins/standard/dependency-tree/tree.png
+share/bugzilla/skins/standard/global.css
+share/bugzilla/skins/standard/global/body-back.gif
+share/bugzilla/skins/standard/global/calendar.png
+share/bugzilla/skins/standard/global/header.png
+share/bugzilla/skins/standard/index/file-a-bug.png
+share/bugzilla/skins/standard/index/help.png
+share/bugzilla/skins/standard/index/new-account.png
+share/bugzilla/skins/standard/index/search.png
 share/bugzilla/summarize_time.cgi
 share/bugzilla/template/en/default/account/auth/login-small.html.tmpl
 share/bugzilla/template/en/default/account/auth/login.html.tmpl
@@ -748,3 +766,11 @@ share/bugzilla/xmlrpc.cgi
 share/doc/bugzilla/README
 share/examples/bugzilla/bugzilla.conf
 share/examples/bugzilla/localconfig
+@pkgdir share/doc/bugzilla/en
+@pkgdir share/bugzilla/xt
+@pkgdir share/bugzilla/t
+@pkgdir share/bugzilla/lib
+@pkgdir share/bugzilla/graphs
+@pkgdir share/bugzilla/docs/en/html/api/Bugzilla
+@pkgdir share/bugzilla/data
+@pkgdir share/bugzilla/contrib
diff --git a/devel/bugzilla/distinfo b/devel/bugzilla/distinfo
index 58b9161c807..5a4bf9ff717 100644
--- a/devel/bugzilla/distinfo
+++ b/devel/bugzilla/distinfo
@@ -1,7 +1,6 @@
-$NetBSD: distinfo,v 1.22 2019/11/11 21:53:06 maya Exp $
+$NetBSD: distinfo,v 1.23 2021/01/16 08:15:01 maya Exp $
 
-SHA1 (bugzilla-5.0.3.tar.gz) = 49b4b2b1b3086cb9b75f65138e702da71dc29c93
-RMD160 (bugzilla-5.0.3.tar.gz) = f48c7e903a9984d9bf95b969dba3b8d0b4ba4cb2
-SHA512 (bugzilla-5.0.3.tar.gz) = 82334533bd75a4a5eee5213826da916175ecf39cbfd1c4d820519f015257b02998a3acd881f8f52c1650d1140158c8aa839e374574a1fa862a6a4a1351748c46
-Size (bugzilla-5.0.3.tar.gz) = 4069689 bytes
-SHA1 (patch-Bugzilla_Install_Filesystem_pm) = 9ec49194210270be0a4af872765d29ec0544b189
+SHA1 (bugzilla-5.0.6.tar.gz) = bef85c8e7e031ca21d7c59f3c2dc083f52b3d7b1
+RMD160 (bugzilla-5.0.6.tar.gz) = 053ef0b751b5a4719aebaceddf64676a125b4115
+SHA512 (bugzilla-5.0.6.tar.gz) = 8ca47ea1be2b433a6ce68e1a595d72f3d0f0fede44d1194dc6bc9a116dbde3ab7285212c71995e200d31544876e4c3c57b63da1f877a0cb22747ab87a5d598de
+Size (bugzilla-5.0.6.tar.gz) = 3970724 bytes
diff --git a/devel/bugzilla/files/bugzilla.conf b/devel/bugzilla/files/bugzilla.conf
index 3d2c71d43d6..3c152bce150 100644
--- a/devel/bugzilla/files/bugzilla.conf
+++ b/devel/bugzilla/files/bugzilla.conf
@@ -1,4 +1,4 @@
-# $NetBSD: bugzilla.conf,v 1.3 2017/03/17 16:26:31 mef Exp $
+# $NetBSD: bugzilla.conf,v 1.4 2021/01/16 08:15:01 maya Exp $
 #
 # Bugzilla configuration file fragment for Apache
 
@@ -9,8 +9,9 @@
 <Directory "@BZDIR@">
     AddHandler cgi-script .cgi
     Options +ExecCGI
-    AllowOverride Limit
+    AllowOverride Limit AuthConfig
     DirectoryIndex index.cgi index.html
     Order allow,deny
+    Require all granted
     Allow from all
 </Directory>
diff --git a/devel/bugzilla/patches/patch-Bugzilla_Install_Filesystem_pm b/devel/bugzilla/patches/patch-Bugzilla_Install_Filesystem_pm
deleted file mode 100644
index 131ad839507..00000000000
--- a/devel/bugzilla/patches/patch-Bugzilla_Install_Filesystem_pm
+++ /dev/null
@@ -1,15 +0,0 @@
-$NetBSD: patch-Bugzilla_Install_Filesystem_pm,v 1.1 2017/03/17 16:26:31 mef Exp $
-
-Make it verbose when giving error, which file is missing.
-
---- Bugzilla/Install/Filesystem.pm.orig	2016-05-17 04:02:18.000000000 +0900
-+++ Bugzilla/Install/Filesystem.pm	2017-03-11 22:47:12.306643791 +0900
-@@ -693,7 +693,7 @@ sub _create_files {
-             print "Creating $file...\n";
-             my $info = $files{$file};
-             my $fh = new IO::File($file, O_WRONLY | O_CREAT, $info->{perms})
--                || die $!;
-+                || die $file . ': '. $!;
-             print $fh $info->{contents} if $info->{contents};
-             $fh->close;
-         }