Changes 1.59:

Commandline/Settings changes:
 * New option to enable warnings but not style messages: --enable=warning
 * Cppcheck used to skip includes where the header filename is enclosed in <>. You can now include these headers also by using -I. It is still not required to include these headers so feel free to try it and then include the headers that give you the best results. The biggest problem with including many headers is that analysis gets slow.

New checks:
 * New POSIX checks: pipe() buffer size, redundant calls of set/get user id, too big value passed to usleep(), buffer overflow when using write()
 * Storing getc() return value in char variable and comparing to EOF.
 * Detect redundant bitand operations
 * Find suspicious equality comparisons like: if(a == 0) a == 1;
 * Warn about using malloc() for classes containing virtual methods, std::-objects or constructors
 * Portability check that warns when using NULL as argument to variadic function. It has undefined behaviour on some implementations.

Improvements:
 * Improved lookup for functions and types
 * Switched to TinyXml2 as XML library
 * Improved checking for uninitialized struct members, variable scopes that can be reduced and unused functions

GUI:
 * Remember last path in open file dialog
 * Added command line parameter to open a results file
 * Bug in statistic calculation fixed

Additionally, lots of false positives and bugs have been fixed and several existing checks have been improved.

5 files changed, 14 insertions, 15 deletions

diff --git a/devel/cppcheck/Makefile b/devel/cppcheck/Makefile
index f2491ffe068..e60748ee941 100644
--- a/devel/cppcheck/Makefile
+++ b/devel/cppcheck/Makefile
@@ -1,8 +1,6 @@
-# $NetBSD: Makefile,v 1.23 2013/02/16 11:20:42 wiz Exp $
-#
+# $NetBSD: Makefile,v 1.24 2013/04/05 15:14:03 adam Exp $
 
-DISTNAME=	cppcheck-1.57
-PKGREVISION=	3
+DISTNAME=	cppcheck-1.59
 CATEGORIES=	devel
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE:=cppcheck/}
 EXTRACT_SUFX=	.tar.bz2
@@ -18,11 +16,11 @@ BUILD_DEPENDS+=	docbook-xsl-[0-9]*:../../textproc/docbook-xsl
 FIND_PREFIX:=	DBXSLDIR=docbook-xsl
 .include "../../mk/find-prefix.mk"
 
-INSTALLATION_DIRS=	${PKGMANDIR}/man1
 USE_LANGUAGES=		c c++
 USE_TOOLS+=		gmake
 BUILD_TARGET=		all man
 BUILD_MAKE_FLAGS+=	DB2MAN=${DBXSLDIR}/share/xsl/docbook/manpages/docbook.xsl
+INSTALLATION_DIRS=	${PKGMANDIR}/man1
 
 .include "options.mk"
 
diff --git a/devel/cppcheck/PLIST b/devel/cppcheck/PLIST
index 60786e933a1..39db7233c6d 100644
--- a/devel/cppcheck/PLIST
+++ b/devel/cppcheck/PLIST
@@ -1,3 +1,4 @@
-@comment $NetBSD: PLIST,v 1.2 2010/02/03 09:46:42 wiz Exp $
+@comment $NetBSD: PLIST,v 1.3 2013/04/05 15:14:03 adam Exp $
 bin/cppcheck
+${PLIST.qt}bin/cppcheck-gui
 man/man1/cppcheck.1
diff --git a/devel/cppcheck/PLIST.qt b/devel/cppcheck/PLIST.qt
deleted file mode 100644
index 3ddef86a23a..00000000000
--- a/devel/cppcheck/PLIST.qt
+++ /dev/null
@@ -1,2 +0,0 @@
-@comment $NetBSD: PLIST.qt,v 1.2 2011/05/29 11:52:12 wiz Exp $
-bin/cppcheck-gui
diff --git a/devel/cppcheck/distinfo b/devel/cppcheck/distinfo
index 8884965613f..ef307f9c20d 100644
--- a/devel/cppcheck/distinfo
+++ b/devel/cppcheck/distinfo
@@ -1,5 +1,5 @@
-$NetBSD: distinfo,v 1.5 2012/11/29 13:52:51 ryoon Exp $
+$NetBSD: distinfo,v 1.6 2013/04/05 15:14:03 adam Exp $
 
-SHA1 (cppcheck-1.57.tar.bz2) = 4753472689fdcb4276fde55e6e984597c87921bd
-RMD160 (cppcheck-1.57.tar.bz2) = ab8d78d80b501334cfcf236693c241fbf303e5ce
-Size (cppcheck-1.57.tar.bz2) = 1180272 bytes
+SHA1 (cppcheck-1.59.tar.bz2) = 686effdfa6f2ca3369d7d52e54c6fd2db2d06d97
+RMD160 (cppcheck-1.59.tar.bz2) = 2bc386692caf734493c7db1d2fa7638c98e28ba1
+Size (cppcheck-1.59.tar.bz2) = 1243616 bytes
diff --git a/devel/cppcheck/options.mk b/devel/cppcheck/options.mk
index e345273c489..99f759fbacc 100644
--- a/devel/cppcheck/options.mk
+++ b/devel/cppcheck/options.mk
@@ -1,15 +1,17 @@
-# $NetBSD: options.mk,v 1.4 2012/11/29 13:52:51 ryoon Exp $
+# $NetBSD: options.mk,v 1.5 2013/04/05 15:14:03 adam Exp $
 
 PKG_OPTIONS_VAR=	PKG_OPTIONS.cppcheck
 PKG_SUPPORTED_OPTIONS=	qt
 
 .include "../../mk/bsd.options.mk"
 
+PLIST_VARS+=	qt
+
 .if !empty(PKG_OPTIONS:Mqt)
-PLIST_SRC+=		PLIST PLIST.qt
+PLIST.qt=	yes
 
 .include "../../x11/qt4-libs/buildlink3.mk"
-BUILDLINK_DEPMETHOD.qt4-tools?= full
+BUILDLINK_DEPMETHOD.qt4-tools+= full
 .include "../../x11/qt4-tools/buildlink3.mk"
 
 post-build: