gopls: update to 0.8.4.

New Features

New analyzer for //go:embed comments

Gopls now includes an analyzer for go:embed comment directives. At
the moment, this analyzer checks that the "embed" import is present,
but more analyses are planned for the future. See golang/go#50262
for more information.

Improved hover for imports

Hovering over an imported path now gives you the full package doc.

Final support for Go 1.13

Per our support window, gopls v0.8.4 will be the final gopls release
to support being built with Go 1.13. See golang/go#52982 for details.

Bugfixes and Performance improvements

    Faster symbol indexing. Gopls builds a symbol index the first
    time symbol search is invoked. That indexing should be 3-4x
    faster with this release.

    Improved metadata invalidation (AKA fewer restarts). v0.8.4
    fixes a couple of bugs that lead to gopls getting confused
    about packages and needing to be restarted. We're aware of more
    bugs of this nature, but are working on eliminating the need
    to ever restart gopls.

3 files changed, 31 insertions, 32 deletions

diff --git a/devel/gopls/Makefile b/devel/gopls/Makefile
index 9051a6b1c32..566b08ab297 100644
--- a/devel/gopls/Makefile
+++ b/devel/gopls/Makefile
@@ -1,10 +1,9 @@
-# $NetBSD: Makefile,v 1.51 2022/05/11 19:26:26 bsiegert Exp $
+# $NetBSD: Makefile,v 1.52 2022/05/28 09:12:02 wiz Exp $
 #
 # Release notes:
 # https://github.com/golang/tools/releases
 
-DISTNAME=	gopls-0.8.3
-PKGREVISION=	1
+DISTNAME=	gopls-0.8.4
 CATEGORIES=	devel
 MASTER_SITES=	${MASTER_SITE_GITHUB:=golang/}
 GITHUB_PROJECT=	tools
diff --git a/devel/gopls/distinfo b/devel/gopls/distinfo
index e998dfe3062..1c41f927a64 100644
--- a/devel/gopls/distinfo
+++ b/devel/gopls/distinfo
@@ -1,4 +1,4 @@
-$NetBSD: distinfo,v 1.29 2022/04/20 20:54:45 wiz Exp $
+$NetBSD: distinfo,v 1.30 2022/05/28 09:12:02 wiz Exp $
 
 BLAKE2s (github.com__burnt_sushi_toml_@v_v1.0.0.mod) = cd3c2cea509a40639fa5501d594ba981c1385767f14e35780d21b8bd313977a4
 SHA512 (github.com__burnt_sushi_toml_@v_v1.0.0.mod) = 0e8cdda81300811f629bce3a9307de05450036f750f8c3c0cd5b70854f8f95bd962ce99bfe1325c8d1bf562a5b7b94afb9e9fd2dbe4dcc45325fac6e27471102
@@ -99,12 +99,12 @@ Size (golang.org_x_exp_typeparams_@v_v0.0.0-20220218215828-6cf2b201936e.zip) = 1
 BLAKE2s (golang.org_x_mod_@v_v0.5.1.mod) = c26a003ec0f07fdf8184e8d9773ea70d0d1da870509d7d4879cc5c36ff8ac73d
 SHA512 (golang.org_x_mod_@v_v0.5.1.mod) = 8ad3d2d81f0192ba3215650546e1cc1eb2d58f2c9898929e565233388d95bb2d1a334d038e9807a44733fe6a218ac0b32de24d16fe9d208addcd67cdc2ae8f79
 Size (golang.org_x_mod_@v_v0.5.1.mod) = 214 bytes
-BLAKE2s (golang.org_x_mod_@v_v0.6.0-dev.0.20220106191415-9b9b3d81d5e3.mod) = dd937abe8e1e603b1bf57c96cdcca74fefc9f05c7da84b45ae958f5be2d3754a
-SHA512 (golang.org_x_mod_@v_v0.6.0-dev.0.20220106191415-9b9b3d81d5e3.mod) = 8ad9ed616127b7e63049d470e02d2ab91345b3feaea4848702a67d1d39069e2a50743d7684cf35341bc0acf5594409025f6dd67d1a61edfbaf68b5e51ff4e8db
-Size (golang.org_x_mod_@v_v0.6.0-dev.0.20220106191415-9b9b3d81d5e3.mod) = 214 bytes
-BLAKE2s (golang.org_x_mod_@v_v0.6.0-dev.0.20220106191415-9b9b3d81d5e3.zip) = 27423131e4122185bdce71aba6d0908dddb861b6b65e028602a62e1acb7177f0
-SHA512 (golang.org_x_mod_@v_v0.6.0-dev.0.20220106191415-9b9b3d81d5e3.zip) = 3aca63d656dc70e1ad3e4a74917cc43f97ca42ca0491cd526632f70a3ca65a5aedd279d4efc6e276b6678070d4d31bc47df371fa256e7167fae484418a611c12
-Size (golang.org_x_mod_@v_v0.6.0-dev.0.20220106191415-9b9b3d81d5e3.zip) = 169189 bytes
+BLAKE2s (golang.org_x_mod_@v_v0.6.0-dev.0.20220419223038-86c51ed26bb4.mod) = 3f0d0909d9e47064d3d0fe193f1a93eeeeac26d33ee67fd3c9bc8f17ae1e81f8
+SHA512 (golang.org_x_mod_@v_v0.6.0-dev.0.20220419223038-86c51ed26bb4.mod) = 480578e689b3d5f5026af3ab52e55b47098525512daf532f4656d50ea5d9043d1b3e69556a5e7d93c7ea6cfca956f733271f3b1f4f65da1a7dac9ea07f5d9fec
+Size (golang.org_x_mod_@v_v0.6.0-dev.0.20220419223038-86c51ed26bb4.mod) = 157 bytes
+BLAKE2s (golang.org_x_mod_@v_v0.6.0-dev.0.20220419223038-86c51ed26bb4.zip) = 0576939ace00f8dd570757b15fd45306915c04485386aa048cf6418a190912b9
+SHA512 (golang.org_x_mod_@v_v0.6.0-dev.0.20220419223038-86c51ed26bb4.zip) = e2c5105027dfe44585765f0ae968c8a8ca5ec5569299f7e2bb0dbe527dd63d2e81ce677075433b67f081d805aa1dc26652ce15485767e6f546c5a1a0d0ab792c
+Size (golang.org_x_mod_@v_v0.6.0-dev.0.20220419223038-86c51ed26bb4.zip) = 169387 bytes
 BLAKE2s (golang.org_x_net_@v_v0.0.0-20190404232315-eb5bcb51f2a3.mod) = bfa1d10354f85025b70e240f2ae7d4ead1684323fc2a0630b15749db3f85c7b8
 SHA512 (golang.org_x_net_@v_v0.0.0-20190404232315-eb5bcb51f2a3.mod) = 26b6c92eecd2208967336d4d23f8a71f77f9a73643ad1e5cd84dee36b2f626fffc806e4dd33acc284831a0961e2b363d898a747903235945fbfb665c5b4d5ef2
 Size (golang.org_x_net_@v_v0.0.0-20190404232315-eb5bcb51f2a3.mod) = 119 bytes
@@ -168,21 +168,21 @@ Size (golang.org_x_tools_@v_v0.0.0-20180917221912-90fa682c2a6e.mod) = 26 bytes
 BLAKE2s (golang.org_x_tools_@v_v0.0.0-20191119224855-298f0cb1881e.mod) = a212a1fb08f1d60f83d616e697ed00d123468c02db07b98b1fc05a6546c377b8
 SHA512 (golang.org_x_tools_@v_v0.0.0-20191119224855-298f0cb1881e.mod) = 6a0316ac3b01aba3f186b5db540a368ab780a821252f7f0975f9e44afea9170c4b3e7027dc5f79a54ebc6af290cbb59b876d3b53bbf26fd05fc3a80a06fae109
 Size (golang.org_x_tools_@v_v0.0.0-20191119224855-298f0cb1881e.mod) = 212 bytes
-BLAKE2s (golang.org_x_tools_@v_v0.1.11-0.20220407163324-91bcfb1bdf9c.mod) = c8ce1e10cfdc4ff377db4028facd7583bccbbd50216dfcbdc38ce8a518cc577e
-SHA512 (golang.org_x_tools_@v_v0.1.11-0.20220407163324-91bcfb1bdf9c.mod) = 0e213cce8249c4a0585b951b87d7b5cbd2f233bf814c963b575ce795802ebf8ceb7922f16d28b31018c7bdfc4f118625d9f331cc98a86e4e6073b13e9b704f91
-Size (golang.org_x_tools_@v_v0.1.11-0.20220407163324-91bcfb1bdf9c.mod) = 383 bytes
-BLAKE2s (golang.org_x_tools_@v_v0.1.11-0.20220407163324-91bcfb1bdf9c.zip) = 3def5ca7c38104be52085a278f3c716f734fcdd02d09c6d15c7d3350e9cac368
-SHA512 (golang.org_x_tools_@v_v0.1.11-0.20220407163324-91bcfb1bdf9c.zip) = c9fb599dca09d19e1692fcb05d91ce32dbc77b5c32a3c624d073805c983c759e79b804809ef30316ff4f36f47d46c77f8f9c1352db85fbcce797a43c547a1c1f
-Size (golang.org_x_tools_@v_v0.1.11-0.20220407163324-91bcfb1bdf9c.zip) = 3927419 bytes
+BLAKE2s (golang.org_x_tools_@v_v0.1.11-0.20220513164230-dfee1649af67.mod) = e91a33eeb22b0baf1a0c4de598c0618b41d3d0b8097b1c77a3600d2f3f90021c
+SHA512 (golang.org_x_tools_@v_v0.1.11-0.20220513164230-dfee1649af67.mod) = 6a43592a9de3660c383bd89345b02204b2f986923d7e6b0e4e312f37b2f2c2cae3f8faec4b86303e23bdf4d3a92e77adabc0e51160dfe2279985d63223ac5356
+Size (golang.org_x_tools_@v_v0.1.11-0.20220513164230-dfee1649af67.mod) = 326 bytes
+BLAKE2s (golang.org_x_tools_@v_v0.1.11-0.20220513164230-dfee1649af67.zip) = 91b26dc0c13e434bb004102c289e3a57f4bd28edef94a9a7d1bc90d9b756f642
+SHA512 (golang.org_x_tools_@v_v0.1.11-0.20220513164230-dfee1649af67.zip) = 3ebd14f8e5a9cf5e027469efbc0d4e9ce61c173a2d8cc0a878c9e61c16bfbad3ffc169c6884c11c98f69a6fba332b43f0e1bcc99f002597906bc283ce45d8462
+Size (golang.org_x_tools_@v_v0.1.11-0.20220513164230-dfee1649af67.zip) = 3968266 bytes
 BLAKE2s (golang.org_x_tools_@v_v0.1.9.mod) = c79a1292cac0f03edf3b85f35f06d7913ae6185e059c45a296a4d550b1f792cc
 SHA512 (golang.org_x_tools_@v_v0.1.9.mod) = ef0a6fb3d91f7619ebfde302204504101c85d3c63c4a4bcffc60e6e0821db9d2adcdf5498ee1a2b365aed217e3a8b277ae494135e3d013eb3f08ef35ef835b99
 Size (golang.org_x_tools_@v_v0.1.9.mod) = 349 bytes
-BLAKE2s (golang.org_x_vuln_@v_v0.0.0-20220324005316-18fd808f5c7f.mod) = aa9a06121e0ca01f9564683cb48ac957ac2f7f2570b4c10c8f71f32402874d88
-SHA512 (golang.org_x_vuln_@v_v0.0.0-20220324005316-18fd808f5c7f.mod) = bebf54e6742ab8ea9fd3c9e63873a481b22813171d0f7e6ed879c74ccee90d50c42fc2986aa3ee46d8be1db72ddcf3896d40b67387a72205025c4088f565bf0d
-Size (golang.org_x_vuln_@v_v0.0.0-20220324005316-18fd808f5c7f.mod) = 476 bytes
-BLAKE2s (golang.org_x_vuln_@v_v0.0.0-20220324005316-18fd808f5c7f.zip) = ab09b268464ca29349471a315e274f80b81662e458fbe24bddddf4a0790e18cb
-SHA512 (golang.org_x_vuln_@v_v0.0.0-20220324005316-18fd808f5c7f.zip) = 7d05df834b755b2584fc9e3fc0919b2fbcc4d13241382074ef6d6935d080c8fff2f5b771db434002b3566cbc560adff139cccc32e3f3e294252e8c562a6a2334
-Size (golang.org_x_vuln_@v_v0.0.0-20220324005316-18fd808f5c7f.zip) = 72138 bytes
+BLAKE2s (golang.org_x_vuln_@v_v0.0.0-20220503210553-a5481fb0c8be.mod) = ebbd556c6912c7ed3f75322c40a0b87e8a32e89f52b6a84f579907efa4642ac5
+SHA512 (golang.org_x_vuln_@v_v0.0.0-20220503210553-a5481fb0c8be.mod) = a3cbf65486ebb600bbed0fb37ded6c172dc905f681e725f4087d4b9325c18a1f6cf66539cac0ba868718ea290fbc6a2e60fc0de819514dc93f59dd9083fffd3b
+Size (golang.org_x_vuln_@v_v0.0.0-20220503210553-a5481fb0c8be.mod) = 614 bytes
+BLAKE2s (golang.org_x_vuln_@v_v0.0.0-20220503210553-a5481fb0c8be.zip) = efe7f049a74acfe1ac775dfa6595178e8a6f495b1b9889525f1a9ab4bebaf0d1
+SHA512 (golang.org_x_vuln_@v_v0.0.0-20220503210553-a5481fb0c8be.zip) = 6d01280923185a9c002852d2bbe343f24c3dc64a056531b466f4913b3a8777c05fd059159fd7c655df556f69e6e05b6c1df8e9135c082b68b59dfe1d8ff47d3a
+Size (golang.org_x_vuln_@v_v0.0.0-20220503210553-a5481fb0c8be.zip) = 240264 bytes
 BLAKE2s (golang.org_x_xerrors_@v_v0.0.0-20190717185122-a985d3407aa7.mod) = b9082cd5be0cf4d922cd04363acc12692e595a5560e43763d016b9dafa566584
 SHA512 (golang.org_x_xerrors_@v_v0.0.0-20190717185122-a985d3407aa7.mod) = 659d18a7a3a1be45ff6dc9e7475276b82ee7f11c47d39b0c237d7f872836a1dbdfff0902f21d6cd8093663997865da92e3e5a4acf1ad6129f972dc5e667b4f05
 Size (golang.org_x_xerrors_@v_v0.0.0-20190717185122-a985d3407aa7.mod) = 37 bytes
@@ -216,9 +216,9 @@ Size (gopkg.in_yaml.v2_@v_v2.2.2.mod) = 95 bytes
 BLAKE2s (gopkg.in_yaml.v2_@v_v2.2.4.mod) = 691acd4b5c50e04e1b7c87adca46561b84e6c3af636d689c92392dc056e48d28
 SHA512 (gopkg.in_yaml.v2_@v_v2.2.4.mod) = 916ff67ddb6c2ba39905db4277ce42596d9ca5a42f8aa7f47f16335e78d91a1b30419fd1b7b6967b37e248363397ec527b38d2f500b3546edda5d2bce1944379
 Size (gopkg.in_yaml.v2_@v_v2.2.4.mod) = 95 bytes
-BLAKE2s (gopls-0.8.3.tar.gz) = 69d8e991f6ffb236d745eb0c73c202d426ea7d3d07904c5ce61bf79b5b68828e
-SHA512 (gopls-0.8.3.tar.gz) = b5be84e3ce79f98f2109ca421cfa913a5031518a068d673b6eec8ec5f61a7bd204ae6e7e11af7f4bf94a6f60107d4268359ed3b2751b3df5a98e685de78147b8
-Size (gopls-0.8.3.tar.gz) = 3036967 bytes
+BLAKE2s (gopls-0.8.4.tar.gz) = b80ffa148a9731a7838fe519a50295766ea21c68ec0719b0cc08aa04b94c2b83
+SHA512 (gopls-0.8.4.tar.gz) = 32b54a3905e2e2721c52c567511375b602078c482747173a1fa5a89decc29ef5cb15dcb4593fc5d9c6e8fa5ce793328f8ed55ca558f3c8715de0e0ef86c4ff3c
+Size (gopls-0.8.4.tar.gz) = 3067199 bytes
 BLAKE2s (honnef.co_go_tools_@v_v0.3.0.mod) = 526b3ce5f9cd55deb717fbd564ee726760341f6f0ab91adc0aaf2331e7e6fdb4
 SHA512 (honnef.co_go_tools_@v_v0.3.0.mod) = 49755cba4eb1c1565d094f2dd26e67136287e8a76b0bde37ba17fc263aeac1d5e84e6728341654cdffe5509c17e6640d8c180e2273dc98c8962a1ceab1337e14
 Size (honnef.co_go_tools_@v_v0.3.0.mod) = 411 bytes
diff --git a/devel/gopls/go-modules.mk b/devel/gopls/go-modules.mk
index 5472c33ba6a..9422bd7284f 100644
--- a/devel/gopls/go-modules.mk
+++ b/devel/gopls/go-modules.mk
@@ -1,4 +1,4 @@
-# $NetBSD: go-modules.mk,v 1.24 2022/04/20 20:54:45 wiz Exp $
+# $NetBSD: go-modules.mk,v 1.25 2022/05/28 09:12:02 wiz Exp $
 
 GO_MODULE_FILES+=	github.com/!burnt!sushi/toml/@v/v1.0.0.mod
 GO_MODULE_FILES+=	github.com/!burnt!sushi/toml/@v/v1.0.0.zip
@@ -33,8 +33,8 @@ GO_MODULE_FILES+=	golang.org/x/crypto/@v/v0.0.0-20191011191535-87dc89f01550.mod
 GO_MODULE_FILES+=	golang.org/x/exp/typeparams/@v/v0.0.0-20220218215828-6cf2b201936e.mod
 GO_MODULE_FILES+=	golang.org/x/exp/typeparams/@v/v0.0.0-20220218215828-6cf2b201936e.zip
 GO_MODULE_FILES+=	golang.org/x/mod/@v/v0.5.1.mod
-GO_MODULE_FILES+=	golang.org/x/mod/@v/v0.6.0-dev.0.20220106191415-9b9b3d81d5e3.mod
-GO_MODULE_FILES+=	golang.org/x/mod/@v/v0.6.0-dev.0.20220106191415-9b9b3d81d5e3.zip
+GO_MODULE_FILES+=	golang.org/x/mod/@v/v0.6.0-dev.0.20220419223038-86c51ed26bb4.mod
+GO_MODULE_FILES+=	golang.org/x/mod/@v/v0.6.0-dev.0.20220419223038-86c51ed26bb4.zip
 GO_MODULE_FILES+=	golang.org/x/net/@v/v0.0.0-20190404232315-eb5bcb51f2a3.mod
 GO_MODULE_FILES+=	golang.org/x/net/@v/v0.0.0-20190620200207-3b0461eec859.mod
 GO_MODULE_FILES+=	golang.org/x/net/@v/v0.0.0-20211015210444-4f30a5c0130f.mod
@@ -56,11 +56,11 @@ GO_MODULE_FILES+=	golang.org/x/text/@v/v0.3.7.mod
 GO_MODULE_FILES+=	golang.org/x/text/@v/v0.3.7.zip
 GO_MODULE_FILES+=	golang.org/x/tools/@v/v0.0.0-20180917221912-90fa682c2a6e.mod
 GO_MODULE_FILES+=	golang.org/x/tools/@v/v0.0.0-20191119224855-298f0cb1881e.mod
-GO_MODULE_FILES+=	golang.org/x/tools/@v/v0.1.11-0.20220407163324-91bcfb1bdf9c.mod
-GO_MODULE_FILES+=	golang.org/x/tools/@v/v0.1.11-0.20220407163324-91bcfb1bdf9c.zip
+GO_MODULE_FILES+=	golang.org/x/tools/@v/v0.1.11-0.20220513164230-dfee1649af67.mod
+GO_MODULE_FILES+=	golang.org/x/tools/@v/v0.1.11-0.20220513164230-dfee1649af67.zip
 GO_MODULE_FILES+=	golang.org/x/tools/@v/v0.1.9.mod
-GO_MODULE_FILES+=	golang.org/x/vuln/@v/v0.0.0-20220324005316-18fd808f5c7f.mod
-GO_MODULE_FILES+=	golang.org/x/vuln/@v/v0.0.0-20220324005316-18fd808f5c7f.zip
+GO_MODULE_FILES+=	golang.org/x/vuln/@v/v0.0.0-20220503210553-a5481fb0c8be.mod
+GO_MODULE_FILES+=	golang.org/x/vuln/@v/v0.0.0-20220503210553-a5481fb0c8be.zip
 GO_MODULE_FILES+=	golang.org/x/xerrors/@v/v0.0.0-20190717185122-a985d3407aa7.mod
 GO_MODULE_FILES+=	golang.org/x/xerrors/@v/v0.0.0-20191011141410-1b5146add898.mod
 GO_MODULE_FILES+=	golang.org/x/xerrors/@v/v0.0.0-20191204190536-9bdfabe68543.mod