devel/libextractor: Update to 1.8 (by ng0 in wip)

pkgsrc changes:
* Update to version 1.8
* Change MASTER_SITE to use GNU_MIRROR
* Change HOMEPAGE to use new gnu.org homepage
* Add License (gpl3)
* Remove libltdl convenience bl3
* Use gtk3 bl3
* Regenerate distinfo and PLIST
* drop patches as they seem to be no longer necessary

upstream changes:
Sun Nov 18 11:19:28 CET 2018
	Releasing GNU libextractor 1.8. -CG

Sun Aug  5 22:37:28 CEST 2018
	Fix missing 0-terminator on corrupted ZIP files
	reported by AdLab of Venustech (#5405). -CG

Thu Jul 12 22:26:36 CEST 2018
	Fix potential infinite loop in mpeg extractor.
	Fix build issue with FFmpeg 4.0 (Debian #888373).
	Releasing GNU libextractor 1.7. -CG

Thu Jul 12 21:23:43 CEST 2018
	Fixing length calculation error in unzip logic reported
	by ADLab of Venustech. -CG

Wed Nov  1 09:06:07 CET 2017
	Fixing NULL pointer issues in GIF, IT, NSFE, S3M, SID and XM
	plugins, caused (except for GIF) by signed/unsigned confusion.
	Found by Leon Zhao. -CG

Tue Oct 17 08:49:31 CEST 2017
	Fix integer overflows in DVI extractor found by Leon Zhao, which
	could cause SEGVs (read-only). -CG

Sun Oct 15 19:36:41 CEST 2017
	Fix potential file descriptor leak (on error handling path).
	Fix potential assign-after-free (on IPC error handling path).
	Make sure to only pass "unsigned char" to functions like isspace().
	Avoid malloc(0) in DEB extractor under certain conditions.
	Properly initialize 'duration' in ffmpeg extractor.
	Fix potential buffer underflow read in DEB extractor.
	Avoid NPE in 'extract' if extracted value has 0 bytes.
	Fix various minor cosmetic issues.
	Releasing GNU libextractor 1.6. -CG

Fri Oct 13 12:30:37 CEST 2017
	Properly check read error in NSF plugin (from signedness confusion) found by Leon Zhao. -CG

Fri Oct 13 12:27:38 CEST 2017
	Protect against problematic integer offset in NSFE plugin found by Leon Zhao. -CG

Fri Oct 13 12:15:35 CEST 2017
	Protect against integer overflows in PNG plugin found by Leon Zhao. -CG

Wed Oct 11 20:14:12 CEST 2017
	Releasing GNU libextractor 1.5. -CG

Mon Oct  9 15:33:01 CEST 2017
	Fix NPE in FLAC plugin found by Leon Zhao. -CG

Mon Oct  9 15:30:01 CEST 2017
	Fix SIGFPE in WAV plugin found by Leon Zhao. -CG

Sat Jun 10 14:12:44 CEST 2017
	Make code compile against libexiv 0.26.
	Avoid use of deprecated libtidy header.
	Releasing GNU libextractor 1.4. -CG

Sun Apr 30 01:50:01 CEST 2017
	Updating French translation. -SA

Wed Oct 12 14:54:03 CEST 2016
	Moving from Subversion to Git. -CG

Sat Mar 26 16:23:56 CET 2016
	Adding PDF support using pdfinfo.
	Likely conflicts with Apparmor. -CG

Mon Aug 31 19:19:17 CEST 2015
	Adding apparmor support. -jmorvan/CG

Sun Dec 22 23:11:28 CET 2013
	Releasing GNU libextractor 1.3. -CG

Sun Dec 22 17:47:38 CET 2013
	Fixing issue where one plugin blocked indefinitely could prevent
	others from ever (successfully) seeking and thus extracting data. -CG

Sat Dec 21 00:26:34 CET 2013
	Fix check for Gtk3. -CG
	Added opus audio-preview plugin. -bratao

Sat Oct 19 16:30:37 CEST 2013
	Increase select() timeout, handle timeout case better.
	Releasing GNU libextractor 1.2. -CG

Mon Sep 23 14:42:58 CEST 2013
	Required external installation of libltdl.
	Check for presence of tidyNodeGetValue in libtidy. -CG

Wed Aug 21 18:42:04 CEST 2013
	Updated Dutch translation. -CG

Sun Aug 18 21:28:58 CEST 2013
	Fix build with libavcodec >= 54.25.0. -CG

Sat Jun 29 21:28:39 CEST 2013
	Releasing GNU libextractor 1.1. -CG

Tue Jun 25 14:24:00 CEST 2013
	Fixing bug where LE could hang due to failure to process all
	received data from the plugin. -CG

Sun Dec  2 08:31:17 CET 2012
	Added Polish translation. -CG

Thu Oct 11 15:51:06 CEST 2012

Thu Oct 11 15:51:06 CEST 2012
	Fixing test for ffmpeg to not accept ancient ffmpeg library. -CG

Thu Oct 11 09:19:42 CEST 2012
	Fixing archive-plugin crash on ".lnk" files (#2586). -bratao

Tue Oct  9 22:28:50 CEST 2012
	Fixing use-after-free in plugin IPC if plugin crashes
	while no seek is pending. -CG

Sat Oct  6 15:24:20 CEST 2012
	Fixing installation path discovery on Darwin (#2562).
	Releasing GNU libextractor 1.0.1. -CG

Tue Sep 25 16:25:05 CEST 2012
	Releasing GNU libextractor 1.0.0. -CG

Thu Sep  6 09:52:13 CEST 2012
	Updated Ukrainian translation. -CG

Tue Mar 27 15:04:00 CEST 2012
	Refactoring plugin API to allow seeks to arbitrary positions in the
	file (breaks existing plugins, so the current version will not
	work). -LRN

Sun Jan 29 17:27:08 CET 2012
	Documented recently discovered issues with pthreads and
	out-of-process plugin executions in the manual. -CG

Tue Nov 29 12:55:40 CET 2011
	Improved IPC code on W32 to use APIs correctly and make it work
	on NT 6.1. -LRN

Mon Nov 28 17:16:16 CET 2011
	Reduce false-positives in MP3 extractor file format detection. -LRN

Mon Nov 28 17:15:59 CET 2011
	Improved winsock2 detection. -LRN

Mon Nov 28 12:17:42 CET 2011
	Fixing compiler warnings, cleaning up ASF plugin.  Finishing
	Matroska plugin. -CG
	Releasing libextractor 0.6.3.

Fri Jul 22 21:46:32 CEST 2011
	Added Ukrainian translation. -CG

Sat Aug 14 23:01:59 CEST 2010
	Various minor bugfixes (largely resource leaks on error paths). -CG

Sun Jun 13 13:15:43 CEST 2010
	Releasing libextractor 0.6.2.

Sat Jun 12 22:32:32 CEST 2010
	Fixing various bugs, including some that can cause crashes given
	malformed inputs. -CG

Sat Jun 12 16:23:14 CEST 2010
	Only pass 'unsigned char's to 'isspace' and similar functions. -CG

Sun Mar 14 00:09:45 CET 2010
	Releasing libextractor 0.6.1.

Wed Jan 13 17:11:07 CET 2010
	Releasing libextractor 0.6.0.

Wed Jan 13 14:36:24 CET 2010
	Adding support for extracting data from the end of files. -CG

Sun Dec 13 16:53:35 CET 2009
	Starting with major API breakage with the goal to fix all of
	the not-so-nice things that have accumulated since version 0.0.0.
	Added support for out-of-process execution from plugins. -CG

Sat Dec  5 11:32:30 CET 2009
	Adding extraction of Iptc data using exiv2.

Sat Jul  4 23:05:22 CEST 2009
	Fixed code to work with RPM 4.7.
	Releasing libextractor 0.5.23.

Sat Apr 11 20:46:14 MDT 2009
	Removed code from libexiv2, linking against it instead.

Fri Feb 20 00:28:00 MST 2009
	Releasing libextractor 0.5.22.

Sun Feb 15 16:57:46 MST 2009
	Upgraded to libtool 2.x (and the libltdl from that release).

Sun Nov  2 20:19:02 MST 2008
	Releasing libextractor 0.5.21.

Tue Aug 12 04:40:49 EEST 2008
	Added an S3M (Scream Tracker 3 Module) plugin.

Tue Aug 12 03:55:01 EEST 2008
	Added an XM (eXtended Module) plugin.

Mon Aug 11 00:43:46 EEST 2008
	Added an IT (Impulse Tracker) plugin.

Tue Jul 22 02:51:33 MDT 2008
	Changed RPM extractor to use librpm.
	Fixed crash in OpenOffice extractor.
	Fixed crash in tiff extractor.

9 files changed, 28 insertions, 138 deletions

diff --git a/devel/libextractor/Makefile b/devel/libextractor/Makefile
index a4e1b026204..d242400a6f0 100644
--- a/devel/libextractor/Makefile
+++ b/devel/libextractor/Makefile
@@ -1,13 +1,13 @@
-# $NetBSD: Makefile,v 1.72 2018/11/14 22:21:16 kleink Exp $
+# $NetBSD: Makefile,v 1.73 2019/02/11 15:06:54 gdt Exp $
 
-DISTNAME=	libextractor-0.5.20c
-PKGREVISION=	31
+DISTNAME=	libextractor-1.8
 CATEGORIES=	devel
-MASTER_SITES=	http://gnunet.org/libextractor/download/
+MASTER_SITES=	${MASTER_SITE_GNU:=libextractor/}
 
 MAINTAINER=	pkgsrc-users@NetBSD.org
-HOMEPAGE=	http://gnunet.org/libextractor/
+HOMEPAGE=	http://gnu.org/s/libextractor/
 COMMENT=	Metadata extractor for various file data types
+LICENSE=	gnu-gpl-v3
 
 MAKE_JOBS_SAFE=		no
 
@@ -19,7 +19,7 @@ GNU_CONFIGURE=		yes
 INFO_FILES=		yes
 PTHREAD_OPTS+=		require
 
-CONFLICTS=		csound-{bath,dev}-*	# bin/extract
+CONFLICTS=		csound-{bath,dev}-[0-9]*	# bin/extract
 
 # This package requires dlopen, so save on space by skipping non-PIC libs
 SHLIBTOOL_OVERRIDE=	# empty
@@ -30,10 +30,10 @@ DEPENDS+= ImageMagick-[0-9]*:../../graphics/ImageMagick
 .include "../../converters/libiconv/buildlink3.mk"
 .include "../../devel/gettext-lib/buildlink3.mk"
 .include "../../devel/libgsf/buildlink3.mk"
-.include "../../devel/libltdl/convenience.mk"
+.include "../../devel/libltdl/buildlink3.mk"
 .include "../../devel/zlib/buildlink3.mk"
 .include "../../multimedia/libmpeg2/buildlink3.mk"
-.include "../../x11/gtk2/buildlink3.mk"
+.include "../../x11/gtk3/buildlink3.mk"
 .include "../../mk/dlopen.buildlink3.mk"
 .include "../../mk/pthread.buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git a/devel/libextractor/PLIST b/devel/libextractor/PLIST
index cc736e5fd7d..96b10970559 100644
--- a/devel/libextractor/PLIST
+++ b/devel/libextractor/PLIST
@@ -1,69 +1,44 @@
-@comment $NetBSD: PLIST,v 1.13 2009/06/14 17:48:52 joerg Exp $
+@comment $NetBSD: PLIST,v 1.14 2019/02/11 15:06:54 gdt Exp $
 bin/extract
 include/extractor.h
-info/extractor.info
+info/libextractor.info
 lib/libextractor.la
-lib/libextractor/libextractor_applefile.la
-lib/libextractor/libextractor_asf.la
+lib/libextractor/libextractor_archive.la
 lib/libextractor/libextractor_deb.la
 lib/libextractor/libextractor_dvi.la
-lib/libextractor/libextractor_elf.la
-lib/libextractor/libextractor_exiv2.la
-lib/libextractor/libextractor_filename.la
-lib/libextractor/libextractor_flv.la
-lib/libextractor/libextractor_gif.la
-lib/libextractor/libextractor_hash_md5.la
-lib/libextractor/libextractor_hash_rmd160.la
-lib/libextractor/libextractor_hash_sha1.la
-lib/libextractor/libextractor_html.la
-lib/libextractor/libextractor_id3v2.la
-lib/libextractor/libextractor_id3v23.la
-lib/libextractor/libextractor_id3v24.la
-lib/libextractor/libextractor_jpeg.la
-lib/libextractor/libextractor_lower.la
+lib/libextractor/libextractor_it.la
 lib/libextractor/libextractor_man.la
 lib/libextractor/libextractor_mime.la
-lib/libextractor/libextractor_mp3.la
 lib/libextractor/libextractor_mpeg.la
 lib/libextractor/libextractor_nsf.la
 lib/libextractor/libextractor_nsfe.la
+lib/libextractor/libextractor_odf.la
 lib/libextractor/libextractor_ogg.la
 lib/libextractor/libextractor_ole2.la
-lib/libextractor/libextractor_oo.la
 lib/libextractor/libextractor_pdf.la
 lib/libextractor/libextractor_png.la
-lib/libextractor/libextractor_printable_da.la
-lib/libextractor/libextractor_printable_de.la
-lib/libextractor/libextractor_printable_en.la
-lib/libextractor/libextractor_printable_es.la
-lib/libextractor/libextractor_printable_fi.la
-lib/libextractor/libextractor_printable_fr.la
-lib/libextractor/libextractor_printable_ga.la
-lib/libextractor/libextractor_printable_it.la
-lib/libextractor/libextractor_printable_no.la
-lib/libextractor/libextractor_printable_pt.la
-lib/libextractor/libextractor_printable_sv.la
 lib/libextractor/libextractor_ps.la
-lib/libextractor/libextractor_qt.la
-lib/libextractor/libextractor_real.la
 lib/libextractor/libextractor_riff.la
-lib/libextractor/libextractor_rpm.la
+lib/libextractor/libextractor_s3m.la
 lib/libextractor/libextractor_sid.la
-lib/libextractor/libextractor_split.la
-lib/libextractor/libextractor_tar.la
-lib/libextractor/libextractor_thumbnail.so
 lib/libextractor/libextractor_thumbnailgtk.la
-lib/libextractor/libextractor_tiff.la
-lib/libextractor/libextractor_translit.la
 lib/libextractor/libextractor_wav.la
+lib/libextractor/libextractor_xm.la
 lib/libextractor/libextractor_zip.la
+lib/libextractor_common.la
 lib/pkgconfig/libextractor.pc
 man/man1/extract.1
 man/man3/libextractor.3
 share/locale/de/LC_MESSAGES/libextractor.mo
+share/locale/es/LC_MESSAGES/libextractor.mo
+share/locale/fr/LC_MESSAGES/libextractor.mo
 share/locale/ga/LC_MESSAGES/libextractor.mo
+share/locale/it/LC_MESSAGES/libextractor.mo
 share/locale/nl/LC_MESSAGES/libextractor.mo
+share/locale/pl/LC_MESSAGES/libextractor.mo
 share/locale/ro/LC_MESSAGES/libextractor.mo
 share/locale/rw/LC_MESSAGES/libextractor.mo
+share/locale/sr/LC_MESSAGES/libextractor.mo
 share/locale/sv/LC_MESSAGES/libextractor.mo
+share/locale/uk/LC_MESSAGES/libextractor.mo
 share/locale/vi/LC_MESSAGES/libextractor.mo
diff --git a/devel/libextractor/buildlink3.mk b/devel/libextractor/buildlink3.mk
index aef54b4f8b2..8ecfb1b13d7 100644
--- a/devel/libextractor/buildlink3.mk
+++ b/devel/libextractor/buildlink3.mk
@@ -1,4 +1,4 @@
-# $NetBSD: buildlink3.mk,v 1.18 2016/08/03 10:22:10 adam Exp $
+# $NetBSD: buildlink3.mk,v 1.19 2019/02/11 15:06:54 gdt Exp $
 
 BUILDLINK_TREE+=	libextractor
 
diff --git a/devel/libextractor/distinfo b/devel/libextractor/distinfo
index acbfd73f6ac..b267ca14bb5 100644
--- a/devel/libextractor/distinfo
+++ b/devel/libextractor/distinfo
@@ -1,11 +1,6 @@
-$NetBSD: distinfo,v 1.24 2015/11/03 03:27:40 agc Exp $
+$NetBSD: distinfo,v 1.25 2019/02/11 15:06:54 gdt Exp $
 
-SHA1 (libextractor-0.5.20c.tar.gz) = 6b89c104a1c9e0bb4c8b949563b8ec8433c879d0
-RMD160 (libextractor-0.5.20c.tar.gz) = dfdd25f674d5304ab5a5906e6be0af8837dc6f92
-SHA512 (libextractor-0.5.20c.tar.gz) = 8c066a3fdc3199408644d63c4f90b432126c3553f5ff9c6fac1740023ae739029e3f5300e6c1bd73cf2c70b306e1c1571ccfc68e89066ba04157415c53284c4e
-Size (libextractor-0.5.20c.tar.gz) = 8181604 bytes
-SHA1 (patch-aa) = f0923e6cba8e6bb327a7959a3d7679bb78a530b2
-SHA1 (patch-ab) = e45d1a5cbca514d096c64979fed442494544fc95
-SHA1 (patch-ac) = b04266851b39581b0956fbfe94f2670c2e196c94
-SHA1 (patch-ad) = 35b00f0fb7d5b4c512d4a4b36f5cc0298ed42eae
-SHA1 (patch-ae) = e1c07a6005cc5638099c8a0ab3f0b62c7526ceb6
+SHA1 (libextractor-1.8.tar.gz) = 32877c1291bf7d15ad33d50e752d7f42a1e349d3
+RMD160 (libextractor-1.8.tar.gz) = d64462fe62702b2fe6935883ee55df9730967dc8
+SHA512 (libextractor-1.8.tar.gz) = 770a0f1711964657ffb570c0509996b0a109886bfa0652c3a9ca63aa645f495fe5919215cf17da68e8a81a09de54bc937b61c82ec03c9e3998149c780f93451a
+Size (libextractor-1.8.tar.gz) = 8315688 bytes
diff --git a/devel/libextractor/patches/patch-aa b/devel/libextractor/patches/patch-aa
deleted file mode 100644
index 6c96dcc5ca8..00000000000
--- a/devel/libextractor/patches/patch-aa
+++ /dev/null
@@ -1,15 +0,0 @@
-$NetBSD: patch-aa,v 1.3 2006/03/16 14:04:58 joerg Exp $
-
---- src/plugins/oo/ooextractor.c.orig	2006-03-16 15:02:36.000000000 +0100
-+++ src/plugins/oo/ooextractor.c
-@@ -23,6 +23,10 @@
- #include "extractor.h"
- #include "zlib.h"
- 
-+#ifndef OF
-+#define OF(x) x
-+#endif
-+
- #define CASESENSITIVITY (0)
- #define MAXFILENAME (256)
- 
diff --git a/devel/libextractor/patches/patch-ab b/devel/libextractor/patches/patch-ab
deleted file mode 100644
index 5c4bb4a16c9..00000000000
--- a/devel/libextractor/patches/patch-ab
+++ /dev/null
@@ -1,12 +0,0 @@
-$NetBSD: patch-ab,v 1.7 2007/03/18 12:34:31 adam Exp $
-
---- src/main/extractor.c.orig	2007-03-12 01:03:21.000000000 +0100
-+++ src/main/extractor.c
-@@ -234,7 +234,6 @@ libextractor_id3v24:\
- libextractor_mime:\
- libextractor_tar:\
- libextractor_dvi:\
--libextractor_deb:\
- libextractor_png:\
- libextractor_gif:\
- libextractor_wav:\
diff --git a/devel/libextractor/patches/patch-ac b/devel/libextractor/patches/patch-ac
deleted file mode 100644
index e736a56194f..00000000000
--- a/devel/libextractor/patches/patch-ac
+++ /dev/null
@@ -1,22 +0,0 @@
-$NetBSD: patch-ac,v 1.11 2009/02/28 13:14:45 drochner Exp $
-
---- src/main/Makefile.in.orig	2008-07-14 03:33:39.000000000 +0200
-+++ src/main/Makefile.in
-@@ -101,7 +101,7 @@ COMPILE = $(CC) $(DEFS) $(DEFAULT_INCLUD
- LTCOMPILE = $(LIBTOOL) --tag=CC $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) \
- 	--mode=compile $(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) \
- 	$(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS)
--CCLD = $(CC)
-+CCLD = $(CXX)
- LINK = $(LIBTOOL) --tag=CC $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) \
- 	--mode=link $(CCLD) $(AM_CFLAGS) $(CFLAGS) $(AM_LDFLAGS) \
- 	$(LDFLAGS) -o $@
-@@ -315,7 +315,7 @@ lib_LTLIBRARIES = \
- extract_LDADD = \
-   $(top_builddir)/src/main/libextractor.la 
- 
--@MINGW_FALSE@@SOMEBSD_FALSE@dlflag = -ldl
-+dlflag = ${DL_LDFLAGS} ${DL_LIBS}
- @HAVE_ZLIB_TRUE@zlib = -lz
- @HAVE_BZ2_TRUE@bz2lib = -lbz2
- @HAVE_GLIB_TRUE@@WITH_GSF_TRUE@GSF_LIBS_X = $(GSF_LIBS)
diff --git a/devel/libextractor/patches/patch-ad b/devel/libextractor/patches/patch-ad
deleted file mode 100644
index 3828670bedc..00000000000
--- a/devel/libextractor/patches/patch-ad
+++ /dev/null
@@ -1,18 +0,0 @@
-$NetBSD: patch-ad,v 1.12 2008/08/03 05:07:00 bjs Exp $
-
---- src/plugins/exiv2/Makefile.in.orig	2008-07-13 21:33:45.000000000 -0400
-+++ src/plugins/exiv2/Makefile.in
-@@ -312,11 +312,11 @@ plugin_LTLIBRARIES = \
-  libextractor_exiv2.la
- 
- libextractor_exiv2_la_LDFLAGS = \
--  $(XTRA_CPPLIBS) -lpthread \
-+  $(XTRA_CPPLIBS) ${PTHREAD_LDFLAGS} \
-   $(PLUGINFLAGS) $(retaincommand)
- 
- libextractor_exiv2_la_LIBADD = \
--  $(top_builddir)/src/main/libextractor.la -lpthread
-+  $(top_builddir)/src/main/libextractor.la ${PTHREAD_LIBS}
- 
- libextractor_exiv2_la_SOURCES = \
- exiv2extractor.cc exv_conf.h exv_msvc.h \
diff --git a/devel/libextractor/patches/patch-ae b/devel/libextractor/patches/patch-ae
deleted file mode 100644
index 5aa5d8a953a..00000000000
--- a/devel/libextractor/patches/patch-ae
+++ /dev/null
@@ -1,13 +0,0 @@
-$NetBSD: patch-ae,v 1.9 2008/08/03 05:07:00 bjs Exp $
-
---- configure.orig	2008-08-03 00:56:36.000000000 -0400
-+++ configure
-@@ -36940,7 +36940,7 @@ _ACEOF
- 
- 
- 
--if test "x$USE_INCLUDED_LIBINTL" == "xyes"
-+if test "x$USE_INCLUDED_LIBINTL" = "xyes"
- then
-   CPPFLAGS='-I$(top_srcdir)/intl '"$CPPFLAGS"
- fi