update to version 3.8.8, partially by sno@

Upstream Changelog:

NEW FEATURES AND MAJOR CHANGES

* Aaron Sigel performed a security audit of RT and pointed out
  a number of potential improvements which have been addressed

* Charts improvements

    * Time-based charts can now show "hourly" goupings.
    * ChartFont option is now hash with font per language.
    * Two default fonts are shipped with RT to cover most
      supported languages.
    * The table of chart results now contains links to tickets
      matching a given row.
    * Timezones support, but protected with config option.
    * Better scaling of Y axis.
    * X axis labels are now vertical if there is not enough
      space to display them horizontally.

* RTAddressRegexp option improvements

    * No default value anymore.
    * If no value is set then RT will attempt to calculate the right value
      from the user-defined queue addresses.
    * On create/update/people pages RT now checks addresses
      users enter and stop users from entering known
      addresses for RT queues.

* Admin UI improvements

    * Improved display of the "About this RT" page.
    * More pages in the Admin UI have been switched to generic
      code to list objects (like tickets in search results)
    * Display formats for these objects are now configurable
      in the config file (%AdminSearchResultFormat)
    * More columns in column maps for objects other than
      tickets.

* Custom fields ordering and application improvements

    * Queue specific custom fields now can be placed above
      global, below or even in the middle. Order of global
      custom fields stays the same in all queues, but a custom
      field that is applied to particular queues can be placed
      differently in each queue.
    * Make it possible to apply a CF globally from 'Applies To'
      page.
    * RT no longer allows you to apply a CF globally and to queues
      at the same time. When CF is applied globally it is
      un-applied from specific queues first.

* Refactored simple (googleish) search

    * new options in the config to control defaults
    * new keywords to search for particular things

* RSS feeds now contain embedded single-query authentication strings
* We've Introduced a config option to prevent adding the
  RT-Originator header in outgoing mails.
* New MessageBoxIncludeSignature* options
* LogoutRefresh config option to control how long to wait
  before going back to login
* New config option for AttachmentUnits
* New config option for AlwaysDownloadAttachments
* RT now requires your current password to change any password
* Improved LinkValueTo and returned back functionality

    * if LinkValueTo starts with __CustomField__ then don't
      escape it, but make sure it's not a JS link
    * escape links using HTML escaping
    * don't wrap into <a> with empty href if link is empty

* Added DefaultMailPrecedence and DefaultErrorMailPrecedence
  config options
* Squelch watchers on update. This makes doing silent
  Updates possible
* New web handler: bin/fastcgi_server
* Refactored Elements/ShowUser so it's easy to add custom
  formats. Several performance improvements in this code.
* MERGE_CACHE to cache information about merged tickets and
  lower logs and DB impact on re-checks
* Made NotifyActor into a User Preference
* If the MIME entity has header X-RT-Squelch, do not send
  the message
* Improved print layouts
* Serve images in js and css dirs as static files,
  so browsers cache them more agressively
* Added HasAttribute and HasNoAttribute to TicketSQL
* New faster and less memory hungry TicketsMaps - First, Prev,
  Next and Last links when you view tickets from the current
  search. Size is now limited by a new config option. Floating
  window is used to build the links.

CLEANUPS AND SMALL IMPROVEMENTS

* Updated doc/Security with more modern security tips
* Made the plaintext mono feature work in IE.
* Better timezone handling in Tools/Reports/ResolvedByDates.html
* Make sure we don't serve files outside RT's paths
* Additional checks to make sure that credentials
  are sent to RT on Login
* Moved CustomField column map from tickets' to generic
* Make height, width, href and alt of the logo configurable
* Load as much as possible when a web-handler with forks
  is used, this increase memory sharing across processes
* A link provided for approvals templates to whoever worked
  the approval
* Global __WebRequestPath__ and __WebRequestPathDir__
  column map entries
* Process custom fields in ModifyDates.html
* Handle Ccs and AdminCcs of the queue in SkipNotification
  feature
* Sort callbacks within a root only, respect plugins
  order
* Add some wording to the check boxes on the reply pages
* Reduce whitespace on bottom of boxes as was earlier
* Use smaller margin for reminders display to save space
* Use a reasonable length for scrip descriptions
* Removed a lie about RT CLI still being "unsupported"
* User friendlier errors handling thrown by Calendar::Simple
* Split some CSS from themes into base/xxx.css
* Googleish search was making incorrect assumptions
  about RT::User and RT::Group's Load function
  returning a boolean not a list. This was throwing
  (harmless, but ugly) errors.
* Don't apply order on collections if sorting is not
  allowed
* Removed the "URL" parameter to 'Logout' as it had no
  legitimate use.
* make instal and testdeps tests to avoid some versions
  of modules that are known to be buggy or incompatible,
  for example DBD::Oracle 1.23

BUG FIXES

* properly use AND/OR when content is searched and
  DontSearchFileAttachments option is enabled
* Make sure Merge only possible when user has Modify
  right on both tickets
* Fixes for UseSQLForACLChecks option, it was possible
  to construct a query and see tickets an user has no
  right to see. Lots of tests have been added to make
  sure it wouldn't happen again.
* SQL used for ACL checks has been refactored to get
  more effective queries. Especially when list of
  potential owners is built for the query builder.
* Unified API for tables with disabled column and
  fixes when ->Count could return bigger value
  when some CFs are disabled.
* I18N was transcoding attachments to UTF-8 one line
  at a time. This doesn't work at all for UTF-16 and
  probably other encodings.
* Fixed encoding problem when loading a dump file
  produced by rt-dump-database.
* A closing </li> was missing in PreviewScrips comp
* Fixed config loading when Fcntl module or other exporting
  symbols is loaded. Load was failing with "Not a SCALAR
  reference" error.
* Returned back effective SQL when searching by CFs with
  = or != operator
* Fixed error on login when user make mistake in password
  and he entered character out of ASCII range.
* Honor a user's MessageBoxRichTextHeight setting
* Fixed query builder behaviour with NULLs and '' (empty values)
* Fixed potential information loose on incorrect GnuPG mails
* Fixed display-all-rows in Dashboards
* Fixed JS escaping issues
* Set context object in OCFV::CustomFieldObj
* Sessions ended up in /tmp/ in some cases
* Fixed safe_run_child when code dies between fork and exec,
  deals with "mysql server has gone away" error
* fix Jumbo reloading and losing message content
* Stop infinite looping when you have global custom
  fields and no Queue restriction
* Fixed sorting of custom fields in Results.tsv
* Set of fixes for Unicode characters in emails
  and tests covering these changes
* Don't create handles we don't need, we can hit limit
* Prevent servers using GnuPG from running out of file handles

TRANSLATION

Updates merged from launchpad and two new languages: nn.po
and pt_PT.po. Thanks to all contributors.

CALLBACKS

* AboutThisUser in ShowPeople box
* Between the GnuPG and message rows
* AfterSubject
* Before and After CustomFields
* Before and After TransactionCustomFields
* AfterAddress in PreviewScrips
* At the top of ticket summary columns
* For adding links for attachment downloads
* At the bottom of the logout box
* Pass more information to the FormStart callback
  in Ticket/Update.html
* AfterMessageBox on ticket create page
* ShowTransaction/AfterAnchor
* In EditDates and ShowDates
* Pass a reference to the signature in MessageBox's callback
* For inserting text after the transaction's description
* AfterUpdateType in Jumbo.html and Update.html

4 files changed, 39 insertions, 18 deletions

diff --git a/devel/rt3/Makefile b/devel/rt3/Makefile
index 6645a4f8e66..31d31a2cbd7 100644
--- a/devel/rt3/Makefile
+++ b/devel/rt3/Makefile
@@ -1,9 +1,8 @@
-# $NetBSD: Makefile,v 1.43 2010/04/13 21:06:30 spz Exp $
+# $NetBSD: Makefile,v 1.44 2010/09/17 21:41:54 spz Exp $
 
-DISTNAME=		rt-3.8.7
+DISTNAME=		rt-3.8.8
 CATEGORIES=		devel
 MASTER_SITES=		http://download.bestpractical.com/pub/rt/release/
-PKGREVISION=		2
 
 MAINTAINER=		spz@NetBSD.org
 HOMEPAGE=		http://bestpractical.com/rt/
@@ -18,9 +17,8 @@ USE_TOOLS+=	perl:run
 USE_LANGUAGES+=	c
 
 # Core dependencies:
-DEPENDS+=	p5-Digest-[0-9]*:../../security/p5-Digest
-DEPENDS+=	p5-Digest-MD5>=2.27:../../security/p5-Digest-MD5
-DEPENDS+=	p5-DBI>=1.37:../../databases/p5-DBI
+DEPENDS+=	{perl>=5.7.3,p5-Digest-[0-9]*}:../../security/p5-Digest
+DEPENDS+=	{perl>=5.8.1,p5-Digest-MD5>=2.27}:../../security/p5-Digest-MD5
 DEPENDS+=	p5-Class-ReturnValue>=0.40:../../devel/p5-Class-ReturnValue
 DEPENDS+=	p5-TimeDate-[0-9]*:../../time/p5-TimeDate
 DEPENDS+=	p5-DBIx-SearchBuilder>=1.54:../../databases/p5-DBIx-SearchBuilder
@@ -30,7 +28,7 @@ DEPENDS+=	p5-HTML-Scrubber>=0.08:../../www/p5-HTML-Scrubber
 DEPENDS+=	p5-HTTP-Server-Simple>=0.34:../../www/p5-HTTP-Server-Simple
 DEPENDS+=	p5-HTTP-Server-Simple-Mason>=0.09:../../www/p5-HTTP-Server-Simple-Mason
 DEPENDS+=	p5-Log-Dispatch>=2.0:../../devel/p5-Log-Dispatch
-DEPENDS+=	p5-Locale-Maketext>=1.06:../../misc/p5-Locale-Maketext
+DEPENDS+=	{perl>=5.10.0,p5-Locale-Maketext>=1.06}:../../misc/p5-Locale-Maketext
 DEPENDS+=	p5-Locale-Maketext-Lexicon>=0.32:../../misc/p5-Locale-Maketext-Lexicon
 DEPENDS+=	p5-Locale-Maketext-Fuzzy>=0.02:../../misc/p5-Locale-Maketext-Fuzzy
 DEPENDS+=	p5-MIME-tools>=5.411.1:../../mail/p5-MIME-tools
@@ -60,12 +58,14 @@ DEPENDS+=	p5-GDGraph-[0-9]*:../../graphics/p5-GDGraph
 DEPENDS+=	p5-GDTextUtil-[0-9]*:../../graphics/p5-GDTextUtil
 DEPENDS+=	p5-Text-WikiFormat>=0.76:../../textproc/p5-Text-WikiFormat
 DEPENDS+=	p5-Module-Refresh>=0.03:../../devel/p5-Module-Refresh
-DEPENDS+=	p5-Encode>=2.13:../../textproc/p5-Encode
+DEPENDS+=	{perl>=5.10.1,p5-Encode>=2.13}:../../textproc/p5-Encode
 
 # Mailgate dependencies:
 DEPENDS+=	p5-HTML-Tree>=3.18:../../www/p5-HTML-Tree
 DEPENDS+=	p5-HTML-Format>=2.03:../../www/p5-HTML-Format
 DEPENDS+=	p5-libwww>=5.76:../../www/p5-libwww
+
+# CLI dependencies
 DEPENDS+=	p5-Term-ReadKey>=2.21:../../devel/p5-Term-ReadKey
 
 # Dashboard dependencies:
@@ -87,7 +87,7 @@ DEPENDS+=	p5-Apache-DBI>=0.92:../../databases/p5-Apache-DBI
 DEPENDS+=	p5-Apache-DBI>=0.92:../../databases/p5-Apache-DBI
 .elif !empty(PKG_OPTIONS:Mfastcgi)
 DEPENDS+=	p5-FCGI>=0.67:../../www/p5-FCGI
-DEPENDS+=	p5-CGI>=3.38:../../www/p5-CGI
+DEPENDS+=	{perl>=5.10.1,p5-CGI>=3.38}:../../www/p5-CGI
 .endif
 PLIST_VARS+=	speedycgi
 .if !empty(PKG_OPTIONS:Mspeedycgi)
@@ -146,4 +146,5 @@ post-extract:
 
 .include "Makefile.install"
 
+.include "../../databases/p5-DBI/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git a/devel/rt3/Makefile.install b/devel/rt3/Makefile.install
index c270bc7a0a0..7d847acc2fe 100644
--- a/devel/rt3/Makefile.install
+++ b/devel/rt3/Makefile.install
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile.install,v 1.14 2009/12/04 09:30:20 spz Exp $
+# $NetBSD: Makefile.install,v 1.15 2010/09/17 21:41:54 spz Exp $
 
 .include "dirs.mk"
 
@@ -53,10 +53,15 @@ CONF_FILES_PERMS+=	${RT_EXAMPLE_DIR}/${_file_}	\
 
 RT_ETC_FILES=		acl.Oracle acl.Pg acl.mysql constraints.mysql	\
 			drop.Oracle initialdata schema.Oracle schema.Pg	\
-			schema.SQLite schema.mysql-4.0 schema.mysql-4.1
+			schema.SQLite schema.mysql-4.0 schema.mysql-4.1 \
+			upgrade/3.8-branded-queues-extension            \
+			upgrade/3.8-ical-extension                      \
+			upgrade/shrink_cgm_table.pl                     \
+			upgrade/split-out-cf-categories                 \
+			upgrade/upgrade-mysql-schema.pl
 RT_UPGRADE_DIRS=	3.3.0 3.3.11 3.5.1 3.7.1 3.7.3 3.7.10 3.7.15	\
-			3.7.19 3.7.81 3.7.82 3.7.85 3.7.86 3.7.87 \
-			3.8.0 3.8.1 3.8.2 3.8.3 3.8.4 3.8.6
+			3.7.19 3.7.81 3.7.82 3.7.85 3.7.86 3.7.87       \
+			3.8.0 3.8.1 3.8.2 3.8.3 3.8.4 3.8.6 3.8.8
 
 MESSAGE_SUBST+=		RTVARDIR=${RT_VAR_DIR:Q} RTSHAREDIR=${RT_SHARE_DIR:Q}
 
diff --git a/devel/rt3/PLIST b/devel/rt3/PLIST
index 333dadbe061..3d8bf375e6a 100644
--- a/devel/rt3/PLIST
+++ b/devel/rt3/PLIST
@@ -1,4 +1,4 @@
-@comment $NetBSD: PLIST,v 1.16 2009/12/04 09:30:20 spz Exp $
+@comment $NetBSD: PLIST,v 1.17 2010/09/17 21:41:54 spz Exp $
 bin/mason_handler.fcgi
 ${PLIST.speedycgi}bin/mason_handler.scgi
 bin/mason_handler.svc
@@ -109,9 +109,11 @@ lib/rt3/RT/I18N/it.po
 lib/rt3/RT/I18N/ja.po
 lib/rt3/RT/I18N/nb.po
 lib/rt3/RT/I18N/nl.po
+lib/rt3/RT/I18N/nn.po
 lib/rt3/RT/I18N/pl.po
 lib/rt3/RT/I18N/pt.po
 lib/rt3/RT/I18N/pt_BR.po
+lib/rt3/RT/I18N/pt_PT.po
 lib/rt3/RT/I18N/rt.pot
 lib/rt3/RT/I18N/ru.pm
 lib/rt3/RT/I18N/ru.po
@@ -260,6 +262,8 @@ sbin/rt-validator
 share/doc/rt3/README
 share/examples/rt3/RT_Config.pm
 share/examples/rt3/RT_SiteConfig.pm
+share/rt3/etc/3.8-branded-queues-extension
+share/rt3/etc/3.8-ical-extension
 share/rt3/etc/acl.Oracle
 share/rt3/etc/acl.Pg
 share/rt3/etc/acl.mysql
@@ -271,6 +275,9 @@ share/rt3/etc/schema.Pg
 share/rt3/etc/schema.SQLite
 share/rt3/etc/schema.mysql-4.0
 share/rt3/etc/schema.mysql-4.1
+share/rt3/etc/shrink_cgm_table.pl
+share/rt3/etc/split-out-cf-categories
+share/rt3/etc/upgrade-mysql-schema.pl
 share/rt3/etc/upgrade/3.3.0/acl.Informix
 share/rt3/etc/upgrade/3.3.0/acl.Oracle
 share/rt3/etc/upgrade/3.3.0/acl.Pg
@@ -310,6 +317,7 @@ share/rt3/etc/upgrade/3.8.3/content
 share/rt3/etc/upgrade/3.8.3/schema.Pg
 share/rt3/etc/upgrade/3.8.4/content
 share/rt3/etc/upgrade/3.8.6/content
+share/rt3/etc/upgrade/${PKGVERSION}/content
 share/rt3/html/Admin/CustomFields/GroupRights.html
 share/rt3/html/Admin/CustomFields/Modify.html
 share/rt3/html/Admin/CustomFields/Objects.html
@@ -468,6 +476,7 @@ share/rt3/html/Elements/EditCustomFieldSelect
 share/rt3/html/Elements/EditCustomFieldText
 share/rt3/html/Elements/EditCustomFieldWikitext
 share/rt3/html/Elements/EditLinks
+share/rt3/html/Elements/EditPassword
 share/rt3/html/Elements/EditTimeValue
 share/rt3/html/Elements/EmailInput
 share/rt3/html/Elements/Error
@@ -499,6 +508,7 @@ share/rt3/html/Elements/QueryString
 share/rt3/html/Elements/QueueSummary
 share/rt3/html/Elements/QuickCreate
 share/rt3/html/Elements/Quicksearch
+share/rt3/html/Elements/RT__CustomField/ColumnMap
 share/rt3/html/Elements/RT__Group/ColumnMap
 share/rt3/html/Elements/RT__Queue/ColumnMap
 share/rt3/html/Elements/RT__Scrip/ColumnMap
@@ -543,6 +553,7 @@ share/rt3/html/Elements/ShowCustomFields
 share/rt3/html/Elements/ShowLink
 share/rt3/html/Elements/ShowLinks
 share/rt3/html/Elements/ShowMemberships
+share/rt3/html/Elements/ShowRelationLabel
 share/rt3/html/Elements/ShowSearch
 share/rt3/html/Elements/ShowUser
 share/rt3/html/Elements/ShowUserConcise
@@ -944,12 +955,14 @@ share/rt3/html/NoAuth/css/3.5-default/ticket.css
 share/rt3/html/NoAuth/css/3.5-default/titlebox.css
 share/rt3/html/NoAuth/css/3.5-default/transactions.css
 share/rt3/html/NoAuth/css/autohandler
+share/rt3/html/NoAuth/css/base/misc.css
 share/rt3/html/NoAuth/css/dhandler
 share/rt3/html/NoAuth/css/print.css
 share/rt3/html/NoAuth/css/web2/InHeader
 share/rt3/html/NoAuth/css/web2/admin.css
 share/rt3/html/NoAuth/css/web2/base.css
 share/rt3/html/NoAuth/css/web2/boxes.css
+share/rt3/html/NoAuth/css/web2/collection.css
 share/rt3/html/NoAuth/css/web2/forms.css
 share/rt3/html/NoAuth/css/web2/images/dhandler
 share/rt3/html/NoAuth/css/web2/images/source/background-gradient.png
@@ -1012,6 +1025,7 @@ share/rt3/html/NoAuth/js/scriptaculous/effects.js
 share/rt3/html/NoAuth/js/scriptaculous/scriptaculous.js
 share/rt3/html/NoAuth/js/titlebox-state.js
 share/rt3/html/NoAuth/js/util.js
+share/rt3/html/NoAuth/rss/dhandler
 share/rt3/html/Prefs/Elements/Tabs
 share/rt3/html/Prefs/MyRT.html
 share/rt3/html/Prefs/Other.html
@@ -1063,6 +1077,7 @@ share/rt3/html/Search/Elements/PickBasics
 share/rt3/html/Search/Elements/PickCFs
 share/rt3/html/Search/Elements/PickCriteria
 share/rt3/html/Search/Elements/ResultViews
+share/rt3/html/Search/Elements/ResultsRSSView
 share/rt3/html/Search/Elements/SearchPrivacy
 share/rt3/html/Search/Elements/SearchesForObject
 share/rt3/html/Search/Elements/SelectAndOr
diff --git a/devel/rt3/distinfo b/devel/rt3/distinfo
index 4b9c2c7e1f5..bb04537362b 100644
--- a/devel/rt3/distinfo
+++ b/devel/rt3/distinfo
@@ -1,8 +1,8 @@
-$NetBSD: distinfo,v 1.17 2010/04/13 21:06:30 spz Exp $
+$NetBSD: distinfo,v 1.18 2010/09/17 21:41:54 spz Exp $
 
-SHA1 (rt-3.8.7.tar.gz) = 9de5860c5c58d40c5f6914cdde807ecc66a68f20
-RMD160 (rt-3.8.7.tar.gz) = 269b7a7ef18afa6f1191c77bf7cadbbb7ef698d1
-Size (rt-3.8.7.tar.gz) = 3372703 bytes
+SHA1 (rt-3.8.8.tar.gz) = be3ac598dcbf584f9bcd9a49248a9ccd3affb330
+RMD160 (rt-3.8.8.tar.gz) = de1efb75969d10c274ab48ef488e27f82fcb1a61
+Size (rt-3.8.8.tar.gz) = 5109734 bytes
 SHA1 (patch-aa) = 23964ba8d686931e1f92be88fa3a5d5e06070fce
 SHA1 (patch-ab) = 0cbfa31fb20b2c53e7beeed5591437361bbcf173
 SHA1 (patch-ac) = a330a62fba92f98ec3d590efccbc7607aebb3854