diff options
| author | agc <agc> | 2002-09-04 14:47:32 +0000 |
|---|---|---|
| committer | agc <agc> | 2002-09-04 14:47:32 +0000 |
| commit | 5c18ecbd1e9c2dd9ee1b1599ca35d0578b2e188d (patch) | |
| tree | c5f617edba6ae81af7be6e5d984ab9fdbe5a97f4 /graphics/kdegraphics2 | |
| parent | c1e1344cf693a2f7f40a257987f12caad992a0fc (diff) | |
| download | pkgsrc-5c18ecbd1e9c2dd9ee1b1599ca35d0578b2e188d.tar.gz | |
Apply patches from Lubomir Sedlacik <salo@Xtrmntr.org> in PR 18115 to
generalise the linker flags used to export symbols by setting them on
a per-OS basis.
> many packages force -Wl,-export-dynamic which is not portable outside GNU ld
> and cause problems e.g. on Solaris. some of these packages use if
> conditionals either only for NetBSD or except SunOS, but the state is not
> coherent and it may complicate later when support for new OS is added to
> pkgsrc (e.g. ongoing work on HP-UX support).
>
> jlam proposed the following framework in discussion on tech-pkg:
>
> http://mail-index.netbsd.org/tech-pkg/2002/06/21/0009.html
>
> now, ${EXPORT_SYMBOLS_LDFLAGS} is used instead of directly defining
> -Wl,-export-dynamic which is set in appropriate defs.*.mk to reasonable
> values. packages should be converted to this framework by:
>
> 1) replacing LDFLAGS+= -Wl,-export-dynamic and LIBS+= -export-dynamic with:
>
> LDFLAGS+= ${EXPORT_SYMBOLS_LDFLAGS}
>
> 2) for use in patchfiles, add this variable to MAKE_ENV if needed:
>
> MAKE_ENV+= EXPORT_SYMBOLS_LDFLAGS=${EXPORT_SYMBOLS_LDFLAGS}
>
> 3) replace occurances of -Wl,-export-dynamic and -export-dynamic in patch
> files with:
>
> $(EXPORT_SYMBOLS_LDFLAGS)
Diffstat (limited to 'graphics/kdegraphics2')
| -rw-r--r-- | graphics/kdegraphics2/Makefile | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/graphics/kdegraphics2/Makefile b/graphics/kdegraphics2/Makefile index 4766bd0d181..8fc584517a2 100644 --- a/graphics/kdegraphics2/Makefile +++ b/graphics/kdegraphics2/Makefile @@ -1,4 +1,4 @@ -# $NetBSD: Makefile,v 1.8 2002/03/13 17:37:11 fredb Exp $ +# $NetBSD: Makefile,v 1.9 2002/09/04 14:47:37 agc Exp $ DISTNAME= kdegraphics-2.2.2 PKGREVISION= 1 @@ -16,11 +16,8 @@ USE_BUILDLINK_ONLY= YES CONFIGURE_ARGS+= --without-kamera # requires gPhoto2, gpio -.include "../../mk/bsd.prefs.mk" - -.if ${OPSYS} == "NetBSD" -LIBS= -Wl,--export-dynamic -.endif +# Ensure we export symbols in the linked shared object. +LDFLAGS+= ${EXPORT_SYMBOLS_LDFLAGS} .include "../../graphics/tiff/buildlink.mk" .include "../../x11/kde2/buildlink.mk" |