diff options
| author | fredb <fredb@pkgsrc.org> | 2002-12-20 17:54:27 +0000 |
|---|---|---|
| committer | fredb <fredb@pkgsrc.org> | 2002-12-20 17:54:27 +0000 |
| commit | d5cfb80689d5a734270787c8f330d13d753bd543 (patch) | |
| tree | d230cb6717e2525528c959b151cb46862da0770b /graphics/png/Makefile | |
| parent | 59fc77c6a23e70d50a082893d64129be2020d93a (diff) | |
| download | pkgsrc-d5cfb80689d5a734270787c8f330d13d753bd543.tar.gz | |
Fix another bug in png_do_read_filler() regarding 16-big *grayscale*
images (and bump package to 1.2.5nb2). The following is taken directly
from the png-implement mailing list...
Date: Fri, 20 Dec 2002 11:26:31 -0500
From: Glenn Randers-Pehrson <glennrp@comcast.net>
Reply-To: png-implement@ccrc.wustl.edu
To: png-implement@ccrc.wustl.edu
Subject: Re: [png-implement] bug in png_read_filler() with 16-bit samples
At 01:01 AM 12/5/02 -0500, Glenn Randers-Pehrson wrote:
>A bug has turned up in png_read_filler() with 16-bit samples.
>The starting offsets for the loops are calculated incorrectly
>which causes a buffer overrun beyond the beginning of the row
>buffer.
>
>To fix, at lines 1968 and 1990,
>change "row_width * 3" to "row_width * 6"
>and at lines 1969 and 1991,
>change "row_width;" to "row_width * 2;"
This is only half of the story. Adding an alpha channel to
16-bit *grayscale* images with png_do_read_filler() exhibits
the same bug, and pngcrush crashes if I try to do it.
To fix, at lines 1892, 1893, 1910, and 1911 of pngrtran.c
change "row_width" to "row_width * 2"
Note that applications that do not add an alpha channel via
png_set_filler(), and any applications that do, but reduce 16-bit
samples to 8 bit via png_set_strip_16() are invulnerable to
the bug. Pngcrush is the only application that I know of
that uses png_set_filler() without also using png_set_strip_16().
Glenn
--
Send the message body "help" to png-implement-request@ccrc.wustl.edu
Diffstat (limited to 'graphics/png/Makefile')
| -rw-r--r-- | graphics/png/Makefile | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/graphics/png/Makefile b/graphics/png/Makefile index 9ee5fb8bc3d..5994badf1ab 100644 --- a/graphics/png/Makefile +++ b/graphics/png/Makefile @@ -1,10 +1,10 @@ -# $NetBSD: Makefile,v 1.45 2002/12/19 21:25:09 fredb Exp $ +# $NetBSD: Makefile,v 1.46 2002/12/20 17:54:27 fredb Exp $ # On update, don't forget to increase shared library major/minor's in # accordance with changes (patch-aa). DISTNAME= libpng-1.2.5 PKGNAME= ${DISTNAME:S/lib//} -PKGREVISION= 1 +PKGREVISION= 2 CATEGORIES= graphics MASTER_SITES= ${MASTER_SITE_SOURCEFORGE:=libpng/} \ http://www.libpng.org/pub/png/src/ \ |