diff options
author | gdt <gdt@pkgsrc.org> | 2020-03-26 12:44:46 +0000 |
---|---|---|
committer | gdt <gdt@pkgsrc.org> | 2020-03-26 12:44:46 +0000 |
commit | 52742a8b782dfe5134e35ca5593ae0d6f0de1933 (patch) | |
tree | 2bcf5cd573eddb9c100f585018d5c1f1c83a37ab /mk/compiler | |
parent | 1d32710cc7960ed845602a4a80b1432b1899280b (diff) | |
download | pkgsrc-52742a8b782dfe5134e35ca5593ae0d6f0de1933.tar.gz |
mk/compiler/gfortran.mk: Add comment about gcc 4.8 handling
The code maps gcc-4.8.x to "4", and then won't find gcc4. This is a
bug, but it may be that it's just as well to never match 4.X of any
kind, and use 7 anyway. Explain this issue with a \todo to fix the
bug or document the consequences as intended.
(This is a comment-only change.)
Diffstat (limited to 'mk/compiler')
-rw-r--r-- | mk/compiler/gfortran.mk | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/mk/compiler/gfortran.mk b/mk/compiler/gfortran.mk index a532f0540ba..2c11f70219f 100644 --- a/mk/compiler/gfortran.mk +++ b/mk/compiler/gfortran.mk @@ -1,4 +1,4 @@ -# $NetBSD: gfortran.mk,v 1.14 2020/03/26 12:42:02 gdt Exp $ +# $NetBSD: gfortran.mk,v 1.15 2020/03/26 12:44:46 gdt Exp $ # # Copyright (c) 2005 The NetBSD Foundation, Inc. # All rights reserved. @@ -36,6 +36,9 @@ COMPILER_GFORTRAN_MK= defined # If pkgsrc base compiler is GCC, match the gfortran requirement as closely as # possible. Otherwise, default to a mainstream version and hope for the best. # If base compiler is clang, we really should use flang rather than gfortran. +# \todo Perhaps adjust this so that gcc-4.8.3 maps to 48, or document that 4.8 +# is so old that we intend what seems like a bug to choose the modern version +# in that case. POSSIBLE_GFORTRAN_VERSION?= ${CC_VERSION:S/gcc-//:C/.[0-9].[0-9]$//} .if !empty(PKGSRC_COMPILER:Mgcc) && \ |