summaryrefslogtreecommitdiff
path: root/mk/configure
diff options
context:
space:
mode:
authorrillig <rillig@pkgsrc.org>2006-10-21 10:37:48 +0000
committerrillig <rillig@pkgsrc.org>2006-10-21 10:37:48 +0000
commitedbaa664148c23b9e2c15d2dcae86bf2d3eda89e (patch)
tree586ffc76762f23d553cda8634d6d3d503ff7e05f /mk/configure
parent517fa1fce883ebe0ab55787a52c8f67a2c988c25 (diff)
downloadpkgsrc-edbaa664148c23b9e2c15d2dcae86bf2d3eda89e.tar.gz
Documented a not-so-easily-fixed bug that occurs when stripping comments
off a line.
Diffstat (limited to 'mk/configure')
-rw-r--r--mk/configure/check-portability.sh4
1 files changed, 3 insertions, 1 deletions
diff --git a/mk/configure/check-portability.sh b/mk/configure/check-portability.sh
index 59c2ea785ae..dd1d2c6dc0b 100644
--- a/mk/configure/check-portability.sh
+++ b/mk/configure/check-portability.sh
@@ -1,4 +1,4 @@
-# $NetBSD: check-portability.sh,v 1.2 2006/10/12 20:36:34 rillig Exp $
+# $NetBSD: check-portability.sh,v 1.3 2006/10/21 10:37:48 rillig Exp $
#
# This program checks the extracted files for portability issues that
# are likely to result in false assumptions by the package.
@@ -50,6 +50,8 @@ check_shell() {
# a safe usage of $RANDOM, it will pass the test.
# Strip comments.
+ # Note: this has the side-effect that the # in $# is also
+ # regarded as a comment.
line="${line%%#*}"
# Check for $RANDOM, which is specific to ksh and bash.