summaryrefslogtreecommitdiff
path: root/mk/pkgformat
diff options
context:
space:
mode:
authorgdt <gdt>2016-09-19 12:26:08 +0000
committergdt <gdt>2016-09-19 12:26:08 +0000
commit85c8d12a807fe42384fc9dffaba69fc20abaca35 (patch)
tree1a40c1e6795ae9c0a4a8903144c1fe769f45976b /mk/pkgformat
parent200e039d3d18bfe6c421af1ca1178af8bf6014fa (diff)
downloadpkgsrc-85c8d12a807fe42384fc9dffaba69fc20abaca35.tar.gz
Omit pkg_tarup during replace in destdir mode
In destdir mode (the default), make replace creates the replacement binary package without modifying the installed system, and then installs it via pkg_add -u. Thus, the new package is known to have built and packaged ok before the system is changed, and the risk of trouble is low; thus the benefit of tarring up the installed package is very low, especially since the newly-tarred-up package is removed by "make clean". Using pkg_tarup costs cycles to run and more importantly causes users to have to install it since it is not an automatic dependency. In addition, binary packages are now kept by default when building, so the old version should be accessible in case of trouble. This commit does not change the non-destdir case. Almost no one uses that method, and the relative benefit of tarup is much higher.
Diffstat (limited to 'mk/pkgformat')
-rw-r--r--mk/pkgformat/pkg/replace.mk4
1 files changed, 2 insertions, 2 deletions
diff --git a/mk/pkgformat/pkg/replace.mk b/mk/pkgformat/pkg/replace.mk
index 14da7155630..1ef8637a690 100644
--- a/mk/pkgformat/pkg/replace.mk
+++ b/mk/pkgformat/pkg/replace.mk
@@ -1,4 +1,4 @@
-# $NetBSD: replace.mk,v 1.3 2016/04/10 15:58:03 joerg Exp $
+# $NetBSD: replace.mk,v 1.4 2016/09/19 12:26:08 gdt Exp $
#
# _pkgformat-destdir-replace:
@@ -22,9 +22,9 @@ _pkgformat-replace: \
replace-fixup-installed-info \
.PHONY
+# tarup is omitted for DESTDIR, because the benefits are very small
_pkgformat-destdir-replace: \
replace-names \
- replace-tarup \
replace-destdir \
.PHONY