diff options
| author | rillig <rillig@pkgsrc.org> | 2005-11-18 11:07:27 +0000 |
|---|---|---|
| committer | rillig <rillig@pkgsrc.org> | 2005-11-18 11:07:27 +0000 |
| commit | 3285f86cb5f6e56cd112c03f8425483f4dbc158a (patch) | |
| tree | b7058f28b63209a8257c6b8c8ac675c944aee307 /mk/scripts | |
| parent | ea089f3e2cda74cfada24b1d8dc5c20ab55fb263 (diff) | |
| download | pkgsrc-3285f86cb5f6e56cd112c03f8425483f4dbc158a.tar.gz | |
Added a few FIXMEs at places where this program might fail unexpectedly.
Diffstat (limited to 'mk/scripts')
| -rwxr-xr-x | mk/scripts/mkdatabase | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/mk/scripts/mkdatabase b/mk/scripts/mkdatabase index b738dfb06c9..845e5a688c4 100755 --- a/mk/scripts/mkdatabase +++ b/mk/scripts/mkdatabase @@ -1,5 +1,5 @@ #!/bin/sh -# $NetBSD: mkdatabase,v 1.8 2005/11/18 10:58:37 rillig Exp $ +# $NetBSD: mkdatabase,v 1.9 2005/11/18 11:07:27 rillig Exp $ # # Script for generating a database with complete dependency information # for a particular package @@ -139,6 +139,7 @@ yes) set -v;; esac if [ ! -d "$TMPDIR" ]; then + # FIXME: wouldn't it be better to fail in this case? mkdir -p "$TMPDIR" fi @@ -151,6 +152,8 @@ case ${DATABASE} in ;; *) + # FIXME: wouldn't it be better to fail in this case? + # make sure we have the full path to the database file DATABASE=`pwd`/${DATABASE} ;; @@ -172,6 +175,7 @@ if [ $append_flag = yes ]; then case $debug_flag in yes) echo "Looking for $pkgpath before appending";; esac + # FIXME: $pkgpath may contain special regex characters. if grep "^index $pkgpath " "${DATABASE}" >/dev/null 2>&1 ; then echo "$prompt $pkgpath has already been depended. Skipping..." exit 0 |